Landing code in curl

Daniel Stenberg
Daniel StenbergSegfault manufacturer at wolfSSL
Landing code in
Daniel Stenberg
Daniel Stenberg
Q&A in the end!Q&A in the end!
Lessons on how to code – you know
that already
URLs to the various resources – you
can find them
Discussions on what tools to use –
use whatever you like
This presentation will not include
2,200 contributors – 200 new/year
820 authors – 100 new/year
15 active maintainers
30-50 in progress Pull-Requests in GitHub at all times
You are not alone
Community & communication in curl
The curl-library mailing list
Questions, support, brainstorms,
suggestions, ideas, debugging,
roadmap, feedback
Issues and Pull-Requests on
Bugs and improvements
#curl IRC channel on
Chit chat - anything
Security problems
We’re nice to each other
Code of Conduct
Clone the github git repository
Since you’re going to change code, make your own fork
Get the curl project’s code, not from anyone else hosting it
Get the latest / master
Get the curl code
Build the unmodified version first
Verifies you have the infra setup accordingly
Autotools (configure), cmake and Windows build systems
are supported
‘make test’
Build curl
Most of the code is C89
Code style
Update or add tests?
Change the curl code
./configure --enable-debug
make checksrc
make test
Test your curl code
Commit the change in a local git branch
Gold points: follow the git message
Git push the commit(s) in your curl fork
Commit and push the codeCommit and push the code
Submit your dedicated branch in a pull request to curl/curl
Listen to feedback, amend the branch to adapt
The PR will trigger a large amount of CI jobs, tests and
Watch incoming CI job results, amend the branch to adapt
It might take a while to get human response
Create a Pull Request on curl
No CLA or form to sign to contribute code
By submitting code, you are assumed to have the right to
For a large change, you can add your copyright line
Must not interfere with or be incompatible with license
curl copyright and license
Each PR triggers 90+ builds
Tests, sanitizers and analyses are run on many platforms
with numerous setups and different configs
Unfortunately, CI jobs sometimes fail as false positives
Follow-up commits to the branch restarts the CI builds
The curl CI system
Who reviews Pull Requests?Who reviews Pull Requests?
Anyone can
Everyone is encouraged to
Maintainers tend to watch out for “their areas”
Daniel most likely will
Who decides what’s a good new feature?
It must beIt must be URL/transferURL/transfer relatedrelated
It is aIt is a discussiondiscussion – argue for your point– argue for your point
DanielDaniel has the final sayhas the final say
Old decisions can beOld decisions can be brought backbrought back
If you disagree with a comment/remark: argue your case
For small incremental changes, do a follow-up commit and
For larger changes, consider squashing commits and force-
push a new take – to simplify the review process
Did I mention ‘make checksrc’ ?
Amend a Pull Request
Once all feedback and test failures are addressed
Bug-fixes can get merged any at point in the release cycle
Features can only get merged when the feature-window is
Someone will merge it with a “Closes #1234” GitHub
Merging a Pull Request into curl
The next PR will be easier!
The first one is the hardestThe first one is the hardest
The second time you know what to expectThe second time you know what to expect
Consider reviewing other PRsConsider reviewing other PRs
Help us improve docs for other first-timersHelp us improve docs for other first-timers
Everything is merged via PRsEverything is merged via PRs
The same procedures and rules apply to everyone
All commits merged into the master branch
At the time of the release
There’s always another chance in the next release!
We do releases every eight weeks
Contents of a curl release
“scratch your own itch”
Existing issues on GitHub
Need ideas of what to work on?
We are all on the same team
Ask when in doubt
We love you for helping out and being one of us
We want you to succeed!
Commercial curl support!
Daniel Stenberg
Thank you!Thank you!
This presentation and its contents are
licensed under the Creative Commons
Attribution 4.0 license:
1 of 30

More Related Content

Similar to Landing code in curl(20)

Let me tell you about curlLet me tell you about curl
Let me tell you about curl
Daniel Stenberg210 views
The state of curl 2022The state of curl 2022
The state of curl 2022
Daniel Stenberg43 views
curl security - curl up 2022curl security - curl up 2022
curl security - curl up 2022
Daniel Stenberg28 views
Writing clean code in C# and .NETWriting clean code in C# and .NET
Writing clean code in C# and .NET
Dror Helper13.9K views
Bit Rot in the DocsBit Rot in the Docs
Bit Rot in the Docs
Sarah Maddox2.4K views
curl experiments - curl up 2022curl experiments - curl up 2022
curl experiments - curl up 2022
Daniel Stenberg24 views
Lecture 9 Professional PracticesLecture 9 Professional Practices
Lecture 9 Professional Practices
Sur College of Applied Sciences592 views
When it all GOes rightWhen it all GOes right
When it all GOes right
Pavlo Golub8 views
Intro. to Git and GithubIntro. to Git and Github
Intro. to Git and Github
Olmo F. Maldonado193 views
 GraphQL-ify your APIs - Devoxx UK 2021 GraphQL-ify your APIs - Devoxx UK 2021
GraphQL-ify your APIs - Devoxx UK 2021
Soham Dasgupta102 views
How to write good quality codeHow to write good quality code
How to write good quality code
Hayden Bleasel882 views
mastering libcurl part 1mastering libcurl part 1
mastering libcurl part 1
Daniel Stenberg36 views
Git best practices 2016Git best practices 2016
Git best practices 2016
Otto Kekäläinen2.7K views
SEO for Large WebsitesSEO for Large Websites
SEO for Large Websites
Dominic Woodman1.4K views
Agile androidAgile android
Agile android
Godfrey Nolan1.4K views

More from Daniel Stenberg(10)

mastering libcurl part 2mastering libcurl part 2
mastering libcurl part 2
Daniel Stenberg14 views
curl - openfourm europe.pdfcurl - openfourm europe.pdf
curl - openfourm europe.pdf
Daniel Stenberg44 views
HTTP/3 in curl - curl up 2022HTTP/3 in curl - curl up 2022
HTTP/3 in curl - curl up 2022
Daniel Stenberg119 views
HTTP/3, QUIC and streamingHTTP/3, QUIC and streaming
HTTP/3, QUIC and streaming
Daniel Stenberg1.8K views
Writing safe and secure codeWriting safe and secure code
Writing safe and secure code
Daniel Stenberg877 views
The state of curl 2019The state of curl 2019
The state of curl 2019
Daniel Stenberg984 views
Säker kod (secure code)Säker kod (secure code)
Säker kod (secure code)
Daniel Stenberg242 views
Daniel Stenberg6K views

Landing code in curl