Paweł Skotnicki: Masz zacząć pracę z legacy code? Nie wiesz, gdzie najlepiej zrobić refactor? A może zaczynasz nowy projekt, który, tym razem, ma utrzymywać najwyższą jakość kodu? Istnieje sporo narzędzi, które mają w tym pomóc, a my często o nich zapominamy. Przedstawię lub przypomnę część z nich.

1. PHP Static Code Analysis
by Paweł Skotnicki

2. About me
PHP Developer @ The Software House
PHPers Silesia co-organizer

3. Code Quality ?

5. Static Code Analysis

6. Tools ?

7. jakzal/phpqa
https://github.com/jakzal/phpqa
docker pull jakzal/phpqa
docker run -it --rm -v $(pwd):/project -w /project jakzal/
phpqa …

8. Linter (php -l)
php -l Bar.php
Parse error: syntax error, unexpected '}', expecting ',' or ';' in
Bar.php on line 11
Errors parsing Bar.php

9. PHP Coding Standards Fixer
(php-cs-fixer)
php-cs-fixer --dry-run --using-cache=no --rules=@PSR1,@PSR2
fix ./
Loaded config default.
1) /project//Bar.php
Checked all files in 0.015 seconds, 8.000 MB memory used

10. PHP Copy/Paste Detector
(phpcpd)
phpcpd src/
phpcpd —min-lines=5 src/

11. PHPCPD
phpcpd --exclude=Behat --regexps-exclude="#.*Spec.php#" src/
phpcpd 3.0.0 by Sebastian Bergmann.
Found 8 clones with 397 duplicated lines in 14 files:
- /project/src/Sylius/Component/Order/Model/Order.php:306-387
/project/src/Sylius/Component/Order/Model/OrderItem.php:
277-358
[…]
0.33% duplicated lines out of 121377 total lines of code.

12. PHPCPD

13. PHPCPD
phpcpd --min-tokens=60 ./cpd

14. PHPCPD
phpcpd --min-tokens=60 ./cpd
phpcpd 3.0.0 by Sebastian Bergmann.
0.00% duplicated lines out of 46 total lines of code.
Time: 17 ms, Memory: 2.00MB

15. PHPCPD --fuzzy
phpcpd --fuzzy --min-tokens=60 ./cpd
phpcpd 3.0.0 by Sebastian Bergmann.
Found 1 clones with 20 duplicated lines in 2 files:
- /project/cpd/a.php:4-24
/project/cpd/b.php:4-24
43.48% duplicated lines out of 46 total lines of code.
Time: 22 ms, Memory: 2.00MB

16. PHP Mess Detector (phpmd)
phpmd [filename|directory] [report format] [ruleset file]
phpmd src/ text codesize,unusedcode,naming

17. PHPMD - Rules
Clean Code
Code Size
Controversial
Design
Naming
Unused Code

18. Cyclomatic Complexity
Complexity is determined by the number of decision points in a
method plus one for the method entry.
The decision points are 'if', 'while', 'for', and 'case labels’.

19. The method example() has a Cyclomatic Complexity of 11.

20. NPath Complexity
The NPath complexity of a method is the number of acyclic
execution paths through that method.

21. The method bar() has an NPath complexity of 4.

22. PHPMD
phpmd src/ text codesize --exclude Sylius/Behat
/src/Sylius/Bundle/AddressingBundle/DependencyInjection/
Configuration.php:68 The method addResourcesSection()
has 112 lines of code. Current threshold is set to 100. Avoid
really long methods.
/src/Sylius/Bundle/AttributeBundle/Form/Type/AttributeType/
SelectAttributeType.php:77 The method configureOptions()
has a Cyclomatic Complexity of 10. The configured cyclomatic
complexity threshold is 10.
[…]

23. churn-php

24. PhpCodeFixer
phpcf [--target VERSION] [--max-size SIZE] FILES...

25. deprecation-detector

26. Usage

27. Just tools

28. Thank you