Fixing the Java Serialization Mess

Fixing the Java Serialization mess
Pierre Ernst, HackFest.ca 2016

https://goo.gl/rOpF0u
Introduction to Java serialization
Attack vectors
Serialization Gadgets
• Demo: Denial of Service
Deserialization endpoints
• Demo: JMX (CVE-2016-3427)
Mitigation
• Against Serialization Gadgets
• Against Deserialization endpoints
• Demo: Bypassing Apache TomEE look-ahead class name blacklist
• New concept: Look-ahead method blacklist
Agenda

Software development background
Secure Code Review
Found security vulnerabilities in applications made by:
Pierre Ernst
linkedin.com/in/pernst
@e_rnst
Source:
http://www.wordle.net

https://research.trust.salesforce.com/
Salesforce is hiring application security engineers for:
• Enterprise Security (Vendor applications)
• Product Security (Salesforce web applications)
• Infrastructure Security (Salesforce network and Linux environment).
Contact:
James Sale, Principal Technical Recruiter
jsale@salesforce.com
415-633-6059
Trust team
Salesforce
linkedin.com/in/jamesgsale

The Big Picture
Java Serialization 101
00000000 AC ED 00 05 73 72 00 11 62 6F 6E 68 6F 6D 6D 65 ....sr..bonhomme
00000010 2E 43 61 72 6E 61 76 61 6C 20 51 75 65 62 65 63 .Carnaval Quebec
00000020 20 02 00 00 78 70 ...xp
serialize deserialize

Java Serialization 101
Convert Java instance to/from a binary stream
• Used for persistence (file, database blob)
• Used for transmission (RMI: Remote Method Invocation)
Java API:
• ObjectOutputStream: to serialize (write)
• ObjectInputStream: to deserialize (read)
• JVM knows how to (de)serialize primitive types
• JVM uses reflection and Unsafe to (de)serialize members of any given class.
• Must implements interface java.io.Serializable

Introduction to Java serialization
Attack vectors
Serialization Gadgets
• Demo: Denial of Service
Deserialization endpoints
• Demo: JMX (CVE-2016-3427)
Mitigation
• Against Serialization Gadgets
• Against Deserialization endpoints
• Demo: Bypassing Apache TomEE look-ahead class name blacklist
• New concept: Look-ahead method blacklist

What could possibly go wrong?
Some classes require special handling
• writeObject() and readObject() methods
• e.g.: java.math.BigDecimal
An application is vulnerable if:
• deserializing untrusted input,
• and existing classes on the classpath have “unsecure” readObject() method
The readObject() methods can be chained, abused
• “gadget” in reference to ROP gadgets
• Similarly, some other methods can also be abused (TBD later):
“Magic Methods”

Prior Art (pre-2016)
Date Type Product Researcher(s) Reference
Apr 2005 DOS JRE Marc Schönefeld CVE-2004-2540
Aug 2008 Applet->RCE JRE Sami Koivu CVE-2008-5353
Apr 2010 Applet->RCE JRE Sami Koivu CVE-2010-0094
Mar 2010 DOS Sun Java Web Console Luca Carettoni Source Code
Sept 2011 RCE Spring Framework Wouter Coekaerts CVE-2011-2894
Oct 2012 RCE IBM Cognos BI Pierre Ernst CVE-2012-4858
Feb 2013 File Write->RCE Apache OpenJPA Pierre Ernst CVE-2013-1768
Mar 2013 File Write->RCE Apache Tomcat Pierre Ernst CVE-2013-2185
July 2015 RCE Apache Groovy "cpnrodzc7" CVE-2015-3253
Aug 2015 Buffer Overflow->RCE Android Or Peles & Roee Hay CVE-2015-3837
Nov 2015 RCE Apache Commons Collections Chris Frohoff & Gabriel
Lawrence
CVE-2015-7450
Nov 2015 DOS JRE Wouter Coekaerts Source Code

Attack Surfaces: Endpoints Vs. Gadgets
Attacker Vulnerable Service
Malicious serialized input
(Vulnerable.class)
JVM
Deserialization
(bonhomme.Carnaval.
class)
classpath
Vulnerable
bonhomme.Carnaval instance =
(bonhomme.Carnaval)in.readObject();
Calls “magic” method
private void readObject
(ObjectInputStream in) {
}
1
2

What are the “Magic” methods?
• readObject()
• readResolve()
• validateObject()
• readObjectNoData()
• readExternal()
• finalize()
It has a “magic” method that can be abused
Class is vulnerable if:
• <init>()

File I/O
Network I/O
Code injection
Denial of service
…
Any side effect with security impact
How can magic methods be abused?

Pervasive problem
• com.sun.xml.internal.ws.protocol.xml.XMLMessageException
• java.util.concurrent.CopyOnWriteArrayList
• java.util.logging.LogRecord
• java.util.PriorityQueue
• org.apache.catalina.tribes.membership.MemberImpl
Java Memory Exhaustion
private void readObject(ObjectInputStream in)
throws IOException, ClassNotFoundException {
int len = in.readInt();
this.parameters = new Object[len];
// ...
}
Controlled by attacker
Memory exhaustion

java.io.ObjectInputStream ois =
new java.io.ObjectInputStream(/* contains user’s input */)
ois.readObject();
/* OR */
ois.readUnshared();
It deserializes user’s input
Endpoint is vulnerable if:

Fixed in Java 8 Update 91 (April 2016)
JMX = Java Management eXtensions
• API for managing/monitoring resources
• Client-Server on TCP/IP
• Optional features:
• TLS socket
• Authentication
JMX untrusted deserialization
CVE-2016-3427
!

Tomcat JMX
Retrieving all the session ids
Abusing Existing Features
Prior JMX vulnerabilities

Only vulnerable when authentication is not enabled
Source:
• Exploiting JMX RMI
• Class MLet
RCE with MLet
Prior JMX vulnerabilities
evil.org victim.com
JMX connect
createMBean
javax.management.loading.MLet
load
evil bean invoke

How many times did you read “RMI” ?
• JMX connection strings is future-proof
• Might use some other transport technologies in the future
• But it relies on RMI for now.
We can use RMI directly to connect to a JMX server
a.k.a JMX “URLs”
JMX Connection Strings
service:jmx:rmi://bonhomme.local:10002/jndi/rmi://bonhomme.local:10001/jmxrmi
rmi://bonhomme.local:10002
rmi://bonhomme.local:10001/jmxrmi
JMX endpoint
Naming Registry

Registry registry = LocateRegistry.getRegistry("bonhomme.local", 10001);
RMIServer rmiServer = (RMIServer) registry.lookup("jmxrmi");
RMIConnection rmiConnection = rmiServer.newClient(new String[]{
"tomcat", "secret"});
(directly)
Connecting to JMX with RMI
service:jmx:rmi://bonhomme.local:10002/jndi/rmi://bonhomme.local:10001/jmxrmi

RMI:
Client-Server network protocol
RPC-style
Uses serialization
What is RMI again?
00000000 50 AC ED 00 05 77 22 A1 F2 A2 CB 82 19 D4 02 D0 P....w".........
00000010 70 E5 1A 00 00 01 57 52 A7 43 A2 80 01 FF FF FF p.....WR.C......
00000020 FF F0 E0 74 EA AD 0C AE A8 75 72 00 13 5B 4C 6A ...t.....ur..[Lj
00000030 61 76 61 2E 6C 61 6E 67 2E 53 74 72 69 6E 67 3B ava.lang.String;
00000040 AD D2 56 E7 E9 1D 7B 47 02 00 00 70 78 70 00 00 ..V...{G...pxp..
00000050 00 02 74 00 06 74 6F 6D 63 61 74 74 00 06 73 65 ..t..tomcatt..se
00000060 63 72 65 74 cret
RMI Call

https://docs.oracle.com/javase/8/docs/api/javax/management/remote/rmi/RMIServer.html
RMIServer API
Deserialization happens before authentication can even take place

The Blame Game
Where do we fix it?
“Applications should never
deserialize untrusted input”
1
2
“3rd party libraries should only
have secure magic methods”
vs
.

In both places!
Defense in Depth

Does the class really need to be serializable?
Can we add input validation?
• Prevent path traversal
• Prevent resource exhaustion
• …
Making “magic” methods more secure

bonhomme.Carnaval obj = (bonhomme.Carnaval)ois.readObject();
Fix: Java API change
today
bonhomme.Carnaval obj =
ois.readObject(bonhomme.Carnaval.class);
tomorrow?

Mitigation: Sandboxing
Deserialization inside a block protected by a Security Manager
Could prevent “malicious” calls
• File R/W access
• Process creation
• Network access
• …
Not recommended:
• Hard to fine-tune: what is legitimately required?
• Known to be broken
e.g. CVE-2013-4444 code inside finalize() can be abused

Mitigation: Class Name Input Validation
Look-ahead Java deserialization, Jan 2013, Pierre Ernst
Concept used by various validation libraries
• SerialKiller, by Luca Carettoni
• contrast-rO0 by Contrast Security
• JDK enhancement proposal #290 and CERT Secure Coding SER12-J
We want to validate which classes get deserialized
Object Serialization Stream Protocol defines a class description
00000000 AC ED 00 05 73 72 00 11 62 6F 6E 68 6F 6D 6D 65 ....sr..bonhomme
00000010 2E 43 61 72 6E 61 76 61 6C 20 51 75 65 62 65 63 .Carnaval Quebec
00000020 20 02 00 00 78 70 ...xp
So we could use our own binary parser to decide whether we should stop reading …
… or use existing Java API that allows us to add our own validation hook.
TC_NULL
STREAM_MAGICSTREAM_VERSIONTC_OBJECTTC_CLASSDESC className
serialVersionUID
classDescFlagsfieldsTC_ENDBLOCKDATA
className

Callback provided by Java
Normally used for custom class loading
Adding your own validation hook
Look-ahead Java deserialization
public class LookAheadObjectInputStream extends ObjectInputStream {
@Override
protected Class<?> resolveClass(ObjectStreamClass desc) {
if ( ! desc.getName().equals("bonhomme.Carnaval") ) {
throw new InvalidClassException(
"Unauthorized deserialization attempt",
desc.getName());
}
return super.resolveClass(desc);
}
}

• White-listing classes that are OK to deserialize
• Tedious, Impossible in real life scenario?
• Black-listing classes known to have “bad” “magic” methods
• a.k.a. Whack-a-mole
• Known to be broken
RSA conference
2016-03-04
Alvaro Muñoz
Christian Schneider
Two ways of validating class names
Look-ahead Java deserialization
public class NestedProblems implements Serializable{
private void readObject(ObjectInputStream in) {
ObjectInputStream ois = new ObjectInputStream(
/* attacker controlled input */);
ois.readObject();
}
}

org.apache.webbeans.inject.impl.InjectionPointImpl
org.apache.webbeans.inject.instance.InstanceImpl
org.apache.webbeans.event.EventImpl
• Fixed in Apache TomEE 7.0.1 (June 2016)
• Fixed in Apache OpenWebBeans 1.5.0 (October 2015)
Only an issue if using the black list mode
Black List mode
Class Name Input Validation Bypass
new

Mitigation: Look-ahead Method Blacklist Input Validation
Black List
• method1
• method2
Magic methods?
Class x.y.z
accept
reject
blacklisted methods?
yes yes
no no
Called methods
• methodA
• methodB
Analyze
Magic method

Check it out
Source code with POC implementation published

Mitigation
Putting everything together
Security Manager
Look-ahead Class name validation
• Whitelisting
• Blacklisting
Look-ahead Method blacklisting
P
!

Serialization:
1.Don’t use it
2.Class name whitelisting
3.Method blacklisting

Fixing the Java Serialization Mess

More Related Content

What's hot

Similar to Fixing the Java Serialization Mess

More from Salesforce Engineering

Recently uploaded

Fixing the Java Serialization Mess

Editor's Notes