My First Real Pull Request
Ikuru K
What was it that I did?
● Christopher Wellons' (@skeeto) opengl demo
did not run on my old machine.
● I created a patch that allows software rendering
of the program for machines that have mesa
10.3.2
Flow of the story
● Read the interesting blog post
<http://nullprogram.com/blog/2015/06/06/> and
decided to try it on my machine.
● Git-clone'd the repo, ran the code and got
initialization failed message.
Raised an Issue on Github
Got an immediate reply
Did as he suggested, and it worked!
Made a pull request so that
environment var is set by make it
self
● https://github.com/skeeto/opengl-demo/pull/4
Got a suggestion that I should also
mention as such in README, so
made another commit
@skeeto said he will merge my
contribution if I squash the two
commits together!
How I squashed commits
● Checked out head of @skeeto's master
● Did: merge –squash <mybranch>
● And pushed to the branch that I have requested
the pull
Merged! But...?
Resulting Commit After @skeeto
adjustment
● https://github.com/skeeto/opengl-
demo/commit/c2373b8d941c18bd3b4deaf438f4c60ff0df8e98
Lessons Learned
● Casually raising issues on Github is a nice thing
that I do not need to be shy about.
● Proper commit messages are important, also
for commits being squashed.
● Thanks, especially to @skeeto for the valuable
lesson!

First Real Pull Request Ever

  • 1.
    My First RealPull Request Ikuru K
  • 2.
    What was itthat I did? ● Christopher Wellons' (@skeeto) opengl demo did not run on my old machine. ● I created a patch that allows software rendering of the program for machines that have mesa 10.3.2
  • 3.
    Flow of thestory ● Read the interesting blog post <http://nullprogram.com/blog/2015/06/06/> and decided to try it on my machine. ● Git-clone'd the repo, ran the code and got initialization failed message.
  • 4.
    Raised an Issueon Github
  • 5.
  • 6.
    Did as hesuggested, and it worked!
  • 7.
    Made a pullrequest so that environment var is set by make it self ● https://github.com/skeeto/opengl-demo/pull/4
  • 8.
    Got a suggestionthat I should also mention as such in README, so made another commit
  • 9.
    @skeeto said hewill merge my contribution if I squash the two commits together!
  • 10.
    How I squashedcommits ● Checked out head of @skeeto's master ● Did: merge –squash <mybranch> ● And pushed to the branch that I have requested the pull
  • 11.
  • 12.
    Resulting Commit After@skeeto adjustment ● https://github.com/skeeto/opengl- demo/commit/c2373b8d941c18bd3b4deaf438f4c60ff0df8e98
  • 13.
    Lessons Learned ● Casuallyraising issues on Github is a nice thing that I do not need to be shy about. ● Proper commit messages are important, also for commits being squashed.
  • 14.
    ● Thanks, especiallyto @skeeto for the valuable lesson!