Downloaded 13 times
Uploaded byMamata Gelanee
Baroda code smell and refactoring
This document discusses code smells and refactoring. It defines code smells as structures in code that violate design principles and negatively impact quality. Refactoring is restructuring code without changing external behavior. Several types of code smells are described, such as long methods, long parameter lists, duplicate code, and switch statements. For each smell, symptoms and potential remedies like extracting methods or replacing conditionals with polymorphism are provided. The document emphasizes that most of a software's lifecycle is spent on maintenance, so reducing code smells through refactoring is important.
More Related Content
Similar to Baroda code smell and refactoring
Baroda code smell and refactoring
- 1. Code smell &Refactoring Mamata Gelanee
- 2. Code Smell arecertain structures in the code that indicate violation of fundamental design principles and negatively impact design quality. Refactoring is a disciplined technique for restructuring an existing body of code, altering its internal structure without changing its external behavior.
- 3. “A code smellis a surface indication that usually corresponds to a deeper problem in the system” - Martin Flower
- 4. “Code as SOLIDdeveloper not STUPID one!” - William Durand
- 5. SOLID* ● Single Responsibility ●Open Close principle ● Interface Segregation ● Dependency Inversion principle ● Liskov Substitution principle *This are the principles, not laws.
- 6. STUPID ● Singleton ● TightCoupling ● Untestability ● Premature Optimization ● Indescriptive Naming
- 7. Levels of Codesmell There are three levels of code smell: 1. Method level 2. Class level 3. Application level
- 8. Long class - Singleresponsibility - Readability - Untestability - Extract Class - Extract Subclass - Inline Class - Collapse Hierarchy Symptoms Remedy
- 9. Long Method - Donot have single responsibility - Readability - Untestability - Extract Method - Replace temp with query - Split temporary variables - Separate query from modifiers Symptoms Remedy
- 10. Long Parameter list -More than 3 parameter in constructor or method - No Readability - Use Builder pattern - Replace parameter with object - Preserve whole object Symptoms Remedy
- 11.
- 12. Primitive Obsession - Alots of primitives in code - Use of constants for sub-type like, USER_MANAGER = 1 USER_EMPLOYEE = 2 - Replace Type Code with class, subclass or state/strategy pattern - Replace parameter with object Symptoms Remedy
- 13.
- 14. Duplicate Code - Samecode structure in more than one place - Same expression in two sibling class - Extract Method or Class - Pull up field or method Symptoms Remedy
- 15.
- 16. Switch statements - Obviouslywhen you see switch everywhere in your code - Use enums - Replace type code with sub class - Replace type code with state/strategy - Replace conditional with polymorphism Symptoms Remedy *If you have only few cases that affects single method only, then polymorphism is overkill.
- 17.
- 18.
- 19. Refused Bequest - Whenyour subclass has a behaviour inherited from parent which is not needed. - Push down a method or field Symptoms Remedy
- 21. Oddball Solution Move methodor Move class
- 22.
- 23. Speculative Generality - Oh!We might need this feature in future. - Collapse Hierarchy - Inline Class - Remove extra parameter from method Symptoms Remedy
- 24. Lazy Class - Eachclass you create costs money to maintain and understand. A class that does nothing. - Collapse Hierarchy - Inline Class Symptoms Remedy
- 25. Comments - Too muchcomments in code. - Add comments only where needed - Class name or method name should be descriptive as we do not need to add comments for what they are doing. Symptoms Remedy Comments are for Human, not for Machine.
- 26. 80%time of softwarelifecycle, is a maintenance, only while 20% of time, we develop a software!
- 27.
- 28.
- 29.
- 30.
- 31.
- 33.
- 34. Thanks! Software Engineer, Mastercard Transactionsolution pvt. Ltd., Vadodara - Gujarat AndiGeeky @MamataGelanee andigeeky.wordpress.com/ mamatagelanee07
Editor's Notes
- #2 Add GDG Baroda logo