Slides about code review, object calisthenics, clean code, small commit, definition of Done. Un all this and you will have a powerful code review.

2. Tips to improve your code
review
Wagner Mendes Voltz – Fusca
wagner@db1.com.br

3. Topics
• Code review
• Object Calisthenics
• DoD – Definition of Done
• Small commits

4. Code review
http://geek-and-poke.com/geekandpoke/2012/4/4/recently-during-code-review.html

5. Object Calisthenics
https://giphy.com/gifs/exercise-loop-the-simpsons-4KkSbPnZ5Skec

6. Object Calisthenics
• Jeff Bay
• 9 rules

7. Only One Level
Of Indentation
Per Method

9. Don’t Use The
ELSE Keyword

10. Wrap All
Primitives And
Strings

12. First Class
Collections

13. One Dot Per Line

14. buf.append(loc.current.repre
sentation.substring(0, 1));

15. buf.
append(loc.
current.
representation.
substring(0, 1));

16. buf.
append(loc.
current.
representation.
substring(0, 1));

17. Don’t Abbreviate

18. Keep All Entities
Small

19. •No class over 50 lines
•No package over 10 files

20. No Classes With
More Than Two
Instance
Variables

22. No
Getters/Setters/P
roperties

24. Definition of Done (DoD)

25. Small commits
https://giphy.com/gifs/Qr67k2wQggpDG

26. • 5 Reason keeping git commit small
• https://crealytics.com/blog/5-reasons-keeping-git-commits-small/
• Definition of Done – Agile Alliance
• https://www.agilealliance.org/glossary/definition-of-done/
• Thoughtworks Anthology
• https://pragprog.com/titles/twa/thoughtworks-anthology
• Object Calisthenics – Jeff Bay (java)
• https://bolcom.github.io/student-dojo/legacy-code/DevelopersAnonymous-
ObjectCalisthenics.pdf
• Object Calisthenics – Jeff Bay
• https://www.cs.helsinki.fi/u/luontola/tdd-2009/ext/ObjectCalisthenics.pdf

27. • Guilherme Blanco – Php para adultos
• https://www.youtube.com/watch?time_continue=1&v=u-w4eULRrr0
• William Durant – Object Calisthenics
• https://williamdurand.fr/2013/06/03/object-calisthenics/#8-no-classes-with-
more-than-two-instance-variables
• Matheus Gontijo – Object Calisthenics
• https://pt.slideshare.net/matheusgontijo/object-calisthenics-for-magento-
meet-magento-new-york-2017

28. OBRIGADO!
wagner@db1.com.br
wagnerfusca@gmail.com
@tiofusca
https://medium.com/@wagnerfusca