Why is code review necessary / so important? - Improve coding skills. - Discover and remove duplicated helpers, scripts etc. - Maintain uniform coding conventions (naming conventions for variable, methods etc.) - Understand what other people are doing. Assurance that others can cover for you while on vacation.

1. Copyright All Rights Reserved Jobplanet 2015
v.1.0

2.
2015.01.04

3.
!
Hosang

4. Jeon

5.
hosang.jeon@jobpalnet.co.kr
Jobplanet Code Review Strategy

6. Copyright All Rights Reserved Jobplanet 2015
Why

7. is

8. code

9. review

10. necessary

11. /

12. so

13. important?
• Improve coding skills.
!
• Discover and remove duplicated helpers, scripts etc.
!
• Maintain uniform coding conventions (naming conventions for
variable, methods etc.)
!
• Understand what other people are doing.
!
• Assurance that others can cover for you while on vacation.

14. Copyright All Rights Reserved Jobplanet 2015
Another

15. benefit

16. of

17. code

18. review
without code review
Found a bug
with code review
Who did this!!!!
Oops. Did I miss something
while reviewing the codes?
Bugs are NOT the fault of a single programmer.
A good code review culture can detect and resolve problems early.

19. Copyright All Rights Reserved Jobplanet 2015
Code

20. Review

21. Strategy
No pain, No Gain
No thumbs-up, No Merge

22. Copyright All Rights Reserved Jobplanet 2015
Code

23. Review

24. Strategy
Need a “thumbs-up” from at least one of 3 people.
Especially for new features / critical code paths.

25. Copyright All Rights Reserved Jobplanet 2015
While

26. doing

27. code

28. review…⋯
• Share “easy to make mistakes” during code reviews.
• Share “good” code during code reviews.
• Share good discussions during code reviews.
• “Code review example” can be used during candidate screenings
!
• Make “good/not-good code note” for new team members.

29. Copyright All Rights Reserved Jobplanet 2015
감사합니다.