Frappe Open Day - October & November 2018

Refactoring
Code deduplication - Found using AST
https://gist.github.com/adityahase/62f...d37
https://github.com/frappe/frappe/pull/6347

Frappe Recorder
Not enough love
Inexistent UI
Now can EXPLAIN EXTENDED and SHOW PROFILE
(Uses INFORMATION_SCHEMA.PROFILING)

ERPNext Panda
To justify the existence of Frappe Recorder
Inspired from TPC-C/E/H benchmarks
Frappe with PyPy 6.0 - Works on macOS

Markdown Editor
I write. Faris requests changes. I don’t ﬁx.
Rushabh merges.

RedisWrapper
Do not assume existence of superclass of
redis.Redis

Central
ansible 2 to 2.7 porting
“use_slave_for_read_only” ﬁnished
“What one programmer can do in one month, two
programmers can do in two months.” - Fred Brooks

Central as a Service
Cancelled

Patch Performance
v11.0 patch update_total_qty_ﬁeld
Uses INSERT with ON DUPLICATE KEY UPDATE

Prepared Report
Information Loss Issue
Permission Issue
Filter-Data Mismatch Issue
Space Issue
Filters = JSON serialised JSON serialised dict
json.dumps != JSON.stringify

_comments column is just plain stupid
Error reporting is a joke

Security
Two RCE reports
Fake CVE IDs frappe.io/security
Ongoing - Automated SQLi Tests with SQLMap

Coffee Machine
Manifesto
Summary - Don’t f**k up
https://gist.github.com/adityahase/638...0f2

The Hitchhiker's Guide
to the Galaxy
A Trilogy in Five Parts
“In the beginning the Universe was created. This
has made a lot of people very angry and been
widely regarded as a bad move.”

Ame S no
@co gC e
Open Day
October November
2018

Rel e
f a p gi v11.0.3-be .1 to 11.0.3-be .19 | 20
f a p te 10.1.50 to 10.1.58 | 9
er x t i g 11.0.3-be .3to 11.0.3-be .16 | 14
er x s e v10.1.55 to 10.1.65 | 11
---
Tot 54

fi : co n j o .lo f il s
fi (up me g ): mu p ix
fi (t a s): ur b3 ve n 1.23
fi (d o b ): up d ro x 9.1.0
fi (us r at ): f a p s a n a
fi (ma _co n ): ad m in r e r
do p
fi (): ig em y i d se t et g
l a f
fi : p e n s a l o v U
fi (se .p ): ma p 18 co t e
fi : bu p G t o t 2.1.11
fi (t a s): ur b3
fi (li n ): in t i f
fi (): fe h r wa us it re t
fi (pa h): re pa t
fi : ma ca f o w o s a c
fi : se w a d
Ot e M s es - 17

fi : c a g r e c c ge AP to n r e p c o n

Rel e
f a p gi v11.0.3-be .20 to 11.0.3-be .32 | 12
f a p te 10.1.59 to 10.1.66 | 8
er x t i g 11.0.3-be .17 to 11.0.3-be .25 | 9
er x s e v10.1.66 to 10.1.73 | 8
---
Tot 37

Ot e M s xe - 8 fi
c : bu f e n 10
fi : wo r it r i g
wi N b
fi : de p e s ho b 12
fi (ge _ve n): f o h .p i s of
fi (co n a n): in t i
fi : re em s
fi : se _pa h ag re n pa h
fi : be h o-de y

Pro m h s i l t
- Fil A p o l de p. Ema w at h t ot t, be e l o d if or t , le g o h
er : Gu s no li E l re
- s a n -fi SA

Ame S no
@co gC e
Fe d k a c t ti
c i c al s co .
Thank You

Joined on 24 September
As a fresher "

1st day
Quite boring. #

Spent whole day watching tutorial. $

Struggled so much while installing bench.

Installed bench three times.

My ﬁrst project
(Quality management system)
It was comprehensive

Spent one week in research

And ﬁnally started

Second project
Newsletter Unsubscription portal

Project 3
Master-Calendar
Interesting.

Started research.

Go through the workﬂow of calendar view.

Started working.

And then ?

Started again working
on Master-calendar
Go through the full calendar documentation.

Started rewriting the calendar-view.

Struggled little with ﬁeld-map.

Thank you everyone
for your support
Personally want to thanks Shivam, Aditya and Suraj.

Frappé Open Day
November 2018

ERPNext Academy
a.k.a. LMS
Because “Moodle sundar nahi hai”.

Site and Blog
Migration
“Chinmay ne sab permissions tod diya”

- Nabin
“Mujhe pata tha tum kuch na kuch galat karne wale
ho.”

Auto test-instance
deployment
Kyuki locally clone karke test kaun karega?

The only other screenshot I have

Conference Video
Edits
Cause sacriﬁcing all your system resources to
JavaScript isn’t enough

12 videos,
27 hours of rendering
Thanks, Obama

frappe.io CVE Page
https://frappe.io/security

Email Drafts
Galat hai, but chalta hai, toh sahi hai.

–Aditya Hase, circa 2018
“Yeh jitna bhi mera time liya hai, sab daily work
summary mein daalega tu.”

Open Day Nov 2018
By Deepesh Garg

Script Report for Sales Analytics

Script report for Purchase Analytics

Script report for Stock Analytics

Script Report for Production Analytics

Improved documentation for how to write script reports

Sales Invoice dashboard link ﬁx
• Use frappe.run_serially() to resolve this issue

Bug Fixes
• Accounts Receivable Summary print showing zero value bug fix.

• Paid amount not updating bug fix in fees.

• Currency symbol not showing based on company default bug fix in
sales person wise transaction summary.

• Customer Filter fix in stock projected quantity report

• Table header not printed on each page on printing report.

• Newsletter not accessible via setup bug fix.

• Salary Slip earnings and deductions table fix.

• List view currency bug fix for purchase receipt and delivery note.

• Bank Statement transaction entry bug fix

Accounts Receivable Report Based On Payment Terms

Fixed Assets Depreciation
• Wrote test cases for diﬀerent ﬁxed asset depreciation
methods like Written down value, Straight line method,
Double decline

• Removed serialised assets form asset depreciation cycle.

Customer/Supplier dashboard for multi company setup
• Show company wise annual billing and total unpaid for a
customer

Linked company address with pos proﬁle

Deduction reports
• Provident Fund deduction report

• Income Tax deduction report

• Professional Tax deduction report

• Total payment report based on payment terms

Security
- Minor XSS Issues
- Jinja Template Hack

Quill
- Table support
- HTML Editing

DataTable
- Hyperlist
- Multiple Filters
- Fixed Total Row

Email
- File attachments
- Email snowballing

UI Tests
- Cypress
- Isolated
- No timeouts

SDLC
- Planning
- Implementation
- Testing
- Documentation
- Maintenance

Work Done
● Quality Management System
● Bootstrap v3.3.1 > v3.3.7
● Dark Mode
● Support Enhancement and Service Level Agreements

Bootstrap v3.3.1 > v3.3.7
● Switched to compiling Bootstrap from Leaner Style Sheets (.less) unlike using
Cascading Style Sheets (.css).
● Not much of a difference but it’ll be handy for customization and defining
sizes.
● Now bootstrap is not bundled in desk.css but as a standalone css file.

Dark Mode
● Dark UI for desk finally!
● Merged maximum of the css files into desk css and not applying multiple css
files.
● Also use the variables.less file for customization not “style” tag.
● If any further customizations, don’t forget to edit the dark variables file as well.

Support Enhancement and Service Level Agreement
● Currently working on the Service Level Agreements enhancement for
Support.
● Automated tagging of Issue level.
● Countdown timer for time to respond and resolve.

What lies next..
● Not much work done, hoping to accelerate my work pace.
● Currently looking forward to working in SaaS team.
● Have a few ideas hoping to get it in PoC stage soon as UI IS FINALLY
DONE.

Open Day
November 2018
@Mangesh-Khairnar

★ Reports
○ Defined Contribution Pension Scheme
○ Employee Insurance Policy Deductions
○ ECS format for RBI (Text Report)
Enterprise TMC

Insurance
★ Insurance Type
★ Insurance Company
★ Employee Insurance

Order Ledger(Under Development)
★ Sales Ledger Entry
★ Purchase Ledger Entry

Mentoring
What I should do more

Pull Requests
No more merging with red flags
Need habit formation

Frappe Open Day
Oct-Nov 2018
Rohit

User Permissions
Fixed patch by Nabin and Suraj

Vulnerability Issues for Child Table
Fake Parent
No permissions for
child table

Added Group by Voucher (Consolidated)

Other Fixes
• Date between ﬁlters not working for the
report.
• Dashboard links shows all the data.
• Sales analytics report not able to export
• Links in the prepared report.
• Web form grid view for text editor showing
toolbar
• Replaced frappe.model.get_value and
frappe.client.get_list for single doctype to
avoid permissions issue.

Other Fixes
• Fetch from works after submission of the
document
• Stock value difference calculation issue for
negative inventory with Nabin.
• Increased global search data limit.
• Added currency filter in the consolidated financial
statement report to fix multi-currency issue
• Address not set using API
• Added disabled field in the address form
• Company dashboard sales count showing incorrect
value.
• Tax withholding, tds is applying on the tax amount

Operation Team
• Testing
• Code Review
• PR merging
• Release
• Deploy
• Support

Thanks :)
Coolest thing is client satisfaction not our satisfaction.

Open Day
October-November 2019
Rushabh Mehta

Oct-Nov
• OSI Days
• Code Sprint + Conference
• Partnerships
• //Seibert/Media
• New Laptop and Back Again
• Discussions X 100

Don’t Repeat Yourself
Monolith = Accumulated Learning

Nomadic Tribes
Pastoral Settlement
Agricultural Settlement
City-State
Nation State
Empire
Skill
Systems

Why Empires Win?
How did Humans win?
How did the Europeans win?
How did the Americans win?

Better Systems
Scientiﬁc Method

Frappe Tools
10X More Productive

Operational Excellence
High Quality Service and Communication

The Way We Work
Open, Honest and Transparent

Organization Structure
Distributed, Autonomous, Connected

Frappe Community
Fun, Learn, Improve, Prosper, Grow

Mission and Purpose
Gain Knowledge and Share It

Topics
● 3 months at Frappe.
● Work before Conference.
● Work during Conference.
● Work after Conference.
● Current work and Future plans.

3 Months At Frappe
● Successfully adapted this work culture.
● Learned a lot from the senior members.
● Biggest learning curve, yet ;)
● Great exposure (where else does a fresher get to interact with
clients from multiple countries).
● Excelled at BombSquad.

Work Before Conference
● Was a member of FrappeJS team.
● Made Data-Import in Frappe Accounting.
● Did FrappeJS and Frappe Accounting Documentation.
● Sat with Faris for some minor bug fixes.
● Productivity was less as I was still learning JS and what we had
to do in Accounting was still unclear.

Frappe
Accounting :
Data Import

Frappe
Accounting :
Handling
Errors in
Data-Import

Documentation :
Frappe Accounting

Work During Conference:
● Was part of the Live Streaming team.
● Went to the venue one day before for testing.
● These 2 days were the most stressful days, each day came with a
new set of problems. The master audio was not working the first
day, net fibre cable broke the other day, camera setup was a
pain, our mics were not working as the batteries were left inside
after the last conference, have to run to the control area every
time to adjust lighting, the list goes on and on……...
● All things considered, did a decent job if not excellent.
● Slept like a baby the day after :)

Work After Conference
● Went to the Dark side with Ameya i.e Switched to
team DevOps.
● The first thing that Ameya did on my laptop was
‘sudo apt install vim’ (installing vim).
● Shadowed him for a week and learned all the basic
essentials required (basically learning vim).
● For another 1-2 weeks, stuck in the vicious cycle of release and
deploy.

Executing Bench Commands Remotely
CLI command: bench remote COMMAND [OPTION]
Parameters:
command: The command to be executed on the remote instance
Returns:
Prints the ansible output
Examples:
- bench remote update --server 'frappe.erpnext.com'
- bench remote setup requirements --server 'frappe.erpnext.com'
- bench remote build --server 'frappe.erpnext.com'
- bench remote migrate --site 'frappe.io' --server 'frappe.erpnext.com'

Support Issues
Support Issues that required:
● migration of sites from v10 to v11.
● Setting up a test instance.
● One of the issue was the ssl certification was not getting
completed as the customer has set up a load
balancer on a single server which was blocking
the packets. The first thought that came to my
mind was ->

Current Work And Future Plans
● Currently working with chinmay on frappe-bot which will create
a test instance on a server for a PR when you type
‘@frappe-bot create test instance py2/3’.
● Attending wednesday training sessions as there’s so much to
learn about the product.
● Completing the Release and Deploy to-do list which goes on till
the end of december.
● Keeping a log of the daily work done.

Open Day
Conference to Now, 2018

In the works
Topic Level Separation Inside Course
Test Cases
Review by Team
Pull Request

Permission Issues
! User permission structure was not import friendly
! Required tracking of doctype name changes
! “If owner” permission override was not working as expected
! User permission was not contextual
! Users were not able to figure out the reason of restriction

Permission Issues
! User permission structure was not import friendly
! Required tracking of doctype name changes
! “If owner” permission override was not working as expected
! User was not able to figure out the reason of restriction
Solution
! https://github.com/frappe/frappe/pull/6397

Post transition and delete option

Other Improvements
! Enabled keep-alive feature to avoid unwanted network calls
! Post/Comment permission fixes

Zarrar
Open Day November’18
Frappe/ ERPNext

Fixes…
Preserve Naming Series while deleting in bulk.
Timeline date fix [minor - showed “invalid date”]
Option to route form to success link added in webform.
Duplicate row below a selected row in grid table.
Delete Events if its reference doc is deleted.

Fixes…
GST reports not showing data in their fields.
Setup wizard silently failing because of taxes_setup file.
Scan Barcode field added in transaction DocType.
Display ‘Discount Amount’ in print without taxes table.
TDS calculation fix - taxes calculated before net_total was set

Salvaging code from Frappekt
anko
Top based login
Oath based
Generating ui from meta
Kotlin coroutines
Android specific approach

Hurdles
No proper guide or tutorials yet to achieve significant feat.
khttp, retrofit, etc known kotlin libraries for http request are
android specific
Abstracting the code to be shared without knowledge of swift.

Hurdles
Maps API that is common for both else separate
implementation for android & iOS? Mapbox yet to try.
Ktor supposedly should solve the problem doesn’t have good
guidelines to achieve multiplatform-ness

What I did most of the time… !
Reading… a lot of blogs and documentation regarding kotlin.
Reverse Engineering demo apps that were built using Kotlin/Native
Reading and learning Swift - pretty similar to kotlin from a
glance view. Has lot of syntactic difference though.

Achievement
Nothing major, a simple android app (not platform
independent code) that can log in to frappe. A map view to
see our current location.
Note:- Leaflet could be used for map but via web view.
Manipulating markers or highlighting path will need work

Awakening
Writing code in Python and Javascript is 100x more enjoyable and
gives back fruitful result soon than developing mobile app.
Updating and matching kotlin version and gradle and android sdk
for my pie - to download stuff and install it.

Frappe Open Day - October & November 2018

Recommended

Recommended

More Related Content

What's hot

What's hot (20)

Similar to Frappe Open Day - October & November 2018

Similar to Frappe Open Day - October & November 2018 (20)

Recently uploaded

Recently uploaded (20)

Frappe Open Day - October & November 2018