37. 3737
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd src
phpcpd 4.1.0 by Sebastian Bergmann.
Found 14 clones with 548 duplicated lines in 24 files:
- /app/src/Model/Table/ConferencePagesTable.php:51-105 (54 lines)
/app/src/Model/Table/PagesTable.php:44-98
~~~~~~~~~~~
- /app/src/Controller/ConferenceAttendeeTypesController.php:104-131 (27 lines)
/app/src/Controller/ConferenceAttendeeTypesController.php:143-170
~~~~~~~~~~~
- /app/src/Classes/ForteeUtil.php:73-109 (36 lines)
/app/src/Classes/ImageFetcher.php:277-313
~~~~~~~~~~~
1.08% duplicated lines out of 50840 total lines of code.
Average size of duplication is 39 lines, largest clone has 54 of lines
fortee
forteeのチェック結果
38. 3838
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd src
phpcpd 4.1.0 by Sebastian Bergmann.
Found 14 clones with 548 duplicated lines in 24 files:
- /app/src/Model/Table/ConferencePagesTable.php:51-105 (54 lines)
/app/src/Model/Table/PagesTable.php:44-98
~~~~~~~~~~~
- /app/src/Controller/ConferenceAttendeeTypesController.php:104-131 (27 lines)
/app/src/Controller/ConferenceAttendeeTypesController.php:143-170
~~~~~~~~~~~
- /app/src/Classes/ForteeUtil.php:73-109 (36 lines)
/app/src/Classes/ImageFetcher.php:277-313
~~~~~~~~~~~
1.08% duplicated lines out of 50840 total lines of code.
Average size of duplication is 39 lines, largest clone has 54 of lines
fortee
コード解析するためのツールを
詰め込んだコンテナ
39. 3939
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd src
phpcpd 4.1.0 by Sebastian Bergmann.
Found 14 clones with 548 duplicated lines in 24 files:
- /app/src/Model/Table/ConferencePagesTable.php:51-105 (54 lines)
/app/src/Model/Table/PagesTable.php:44-98
~~~~~~~~~~~
- /app/src/Controller/ConferenceAttendeeTypesController.php:104-131 (27 lines)
/app/src/Controller/ConferenceAttendeeTypesController.php:143-170
~~~~~~~~~~~
- /app/src/Classes/ForteeUtil.php:73-109 (36 lines)
/app/src/Classes/ImageFetcher.php:277-313
~~~~~~~~~~~
1.08% duplicated lines out of 50840 total lines of code.
Average size of duplication is 39 lines, largest clone has 54 of lines
fortee
14個の重複コードを検出。24ファイル、合計548⾏が対象
40. 4040
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd src
phpcpd 4.1.0 by Sebastian Bergmann.
Found 14 clones with 548 duplicated lines in 24 files:
- /app/src/Model/Table/ConferencePagesTable.php:51-105 (54 lines)
/app/src/Model/Table/PagesTable.php:44-98
~~~~~~~~~~~
- /app/src/Controller/ConferenceAttendeeTypesController.php:104-131 (27 lines)
/app/src/Controller/ConferenceAttendeeTypesController.php:143-170
~~~~~~~~~~~
- /app/src/Classes/ForteeUtil.php:73-109 (36 lines)
/app/src/Classes/ImageFetcher.php:277-313
~~~~~~~~~~~
1.08% duplicated lines out of 50840 total lines of code.
Average size of duplication is 39 lines, largest clone has 54 of lines
fortee
テーブルオブジェクトなので
ある程度はしょうがないかな
41. 4141
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd src
phpcpd 4.1.0 by Sebastian Bergmann.
Found 14 clones with 548 duplicated lines in 24 files:
- /app/src/Model/Table/ConferencePagesTable.php:51-105 (54 lines)
/app/src/Model/Table/PagesTable.php:44-98
~~~~~~~~~~~
- /app/src/Controller/ConferenceAttendeeTypesController.php:104-131 (27 lines)
/app/src/Controller/ConferenceAttendeeTypesController.php:143-170
~~~~~~~~~~~
- /app/src/Classes/ForteeUtil.php:73-109 (36 lines)
/app/src/Classes/ImageFetcher.php:277-313
~~~~~~~~~~~
1.08% duplicated lines out of 50840 total lines of code.
Average size of duplication is 39 lines, largest clone has 54 of lines
fortee
同じコントローラーの中に
27⾏の重複があるだと!?
42. 4242
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd src
phpcpd 4.1.0 by Sebastian Bergmann.
Found 14 clones with 548 duplicated lines in 24 files:
- /app/src/Model/Table/ConferencePagesTable.php:51-105 (54 lines)
/app/src/Model/Table/PagesTable.php:44-98
~~~~~~~~~~~
- /app/src/Controller/ConferenceAttendeeTypesController.php:104-131 (27 lines)
/app/src/Controller/ConferenceAttendeeTypesController.php:143-170
~~~~~~~~~~~
- /app/src/Classes/ForteeUtil.php:73-109 (36 lines)
/app/src/Classes/ImageFetcher.php:277-313
~~~~~~~~~~~
1.08% duplicated lines out of 50840 total lines of code.
Average size of duplication is 39 lines, largest clone has 54 of lines
fortee
こちらは違うファイルで36⾏の重複が!
46. 4646
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd src
phpcpd 4.1.0 by Sebastian Bergmann.
Found 14 clones with 548 duplicated lines in 24 files:
- /app/src/Model/Table/ConferencePagesTable.php:51-105 (54 lines)
/app/src/Model/Table/PagesTable.php:44-98
~~~~~~~~~~~
- /app/src/Controller/ConferenceAttendeeTypesController.php:104-131 (27 lines)
/app/src/Controller/ConferenceAttendeeTypesController.php:143-170
~~~~~~~~~~~
- /app/src/Classes/ForteeUtil.php:73-109 (36 lines)
/app/src/Classes/ImageFetcher.php:277-313
~~~~~~~~~~~
1.08% duplicated lines out of 50840 total lines of code.
Average size of duplication is 39 lines, largest clone has 54 of lines
fortee
50,840⾏の中、重複があったコードは1.08%
重複コードの平均⾏数は39⾏で、最⼤54⾏が重複している
47. 4747
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd .
phpcpd 4.1.0 by Sebastian Bergmann.
Found 184 clones with 9893 duplicated lines in 142 files:
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:166-524 (358 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:170-528
~~~~~~~~~~
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:321-561 (240 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:334-574
~~~~~~~~~~~
- /app/xxxxxx/controllers/xxxxxx.php:909-1084 (175 lines)
/app/xxxxxx/controllers/xxxxxx.php:1247-1422
~~~~~~~~~~
8.41% duplicated lines out of 112932 total lines of code.
Average size of duplication is 54 lines, largest clone has 358 of lines
Web App 2
Web App 2のチェック結果
48. 4848
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd .
phpcpd 4.1.0 by Sebastian Bergmann.
Found 184 clones with 9893 duplicated lines in 142 files:
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:166-524 (358 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:170-528
~~~~~~~~~~
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:321-561 (240 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:334-574
~~~~~~~~~~~
- /app/xxxxxx/controllers/xxxxxx.php:909-1084 (175 lines)
/app/xxxxxx/controllers/xxxxxx.php:1247-1422
~~~~~~~~~~
8.41% duplicated lines out of 112932 total lines of code.
Average size of duplication is 54 lines, largest clone has 358 of lines
Web App 2
184個の重複コードを検出。142ファイル、合計9,893⾏が対象
49. 4949
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd .
phpcpd 4.1.0 by Sebastian Bergmann.
Found 184 clones with 9893 duplicated lines in 142 files:
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:166-524 (358 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:170-528
~~~~~~~~~~
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:321-561 (240 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:334-574
~~~~~~~~~~~
- /app/xxxxxx/controllers/xxxxxx.php:909-1084 (175 lines)
/app/xxxxxx/controllers/xxxxxx.php:1247-1422
~~~~~~~~~~
8.41% duplicated lines out of 112932 total lines of code.
Average size of duplication is 54 lines, largest clone has 358 of lines
Web App 2
Viewのファイルなんかも
重複に引っかかってはいるが‧‧‧
50. 5050
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd .
phpcpd 4.1.0 by Sebastian Bergmann.
Found 184 clones with 9893 duplicated lines in 142 files:
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:166-524 (358 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:170-528
~~~~~~~~~~
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:321-561 (240 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:334-574
~~~~~~~~~~~
- /app/xxxxxx/controllers/xxxxxx.php:909-1084 (175 lines)
/app/xxxxxx/controllers/xxxxxx.php:1247-1422
~~~~~~~~~~
8.41% duplicated lines out of 112932 total lines of code.
Average size of duplication is 54 lines, largest clone has 358 of lines
Web App 2
Fatかつ重複したコントローラ‧‧‧
51. 5151
重複コードはあるか?
% docker run --rm -v ${PWD}:/app blue-goheimochi/php-code-analyzer phpcpd .
phpcpd 4.1.0 by Sebastian Bergmann.
Found 184 clones with 9893 duplicated lines in 142 files:
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:166-524 (358 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:170-528
~~~~~~~~~~
- /app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:321-561 (240 lines)
/app/xxxxxx/xxxxxx/xxxxxx/xxxxxx.php:334-574
~~~~~~~~~~~
- /app/xxxxxx/controllers/xxxxxx.php:909-1084 (175 lines)
/app/xxxxxx/controllers/xxxxxx.php:1247-1422
~~~~~~~~~~
8.41% duplicated lines out of 112932 total lines of code.
Average size of duplication is 54 lines, largest clone has 358 of lines
Web App 2
112,932⾏の中、重複があったコードは8.41%
重複コードの平均⾏数は54⾏で、最⼤358⾏が重複している
53. 5353
terryyin/lizard
• Lizard is an extensible Cyclomatic Complexity
Analyzer for many programming languages
• PHP以外の⾔語も解析できるPythonのツール
• 循環的複雑度を計測できる
• 循環的複雑度
• if/else, for, switchなどの数を計測
• コードがどれだけ複雑か?の指標
循環的複雑度は?