SPRINT 139 REVIEW
- Sprint Ending June 22, 2020
June 24, 2020
Meeting Start: 10:30 am EST
2
SPEAKERS
● Overview (Oleg Barenboim)
● UI (Harpreet Kataria)
● Providers (Adam Grare)
● Platform (Joe VLcek)
● API (Alberto Bellotti)
3
4
* Note that some PRs are double labeled or have no labels. Beginning with Sprint 127, archived and forked repos are
excluded.
Repository Files
Lines of
Code Rating
Total
Issues
Complexity
Issues
Duplication
Issues
Bug Risk
Issues
Style
Issues
Test
Coverage
ManageIQ/manageiq 1721 82922 A 1069 473 296 40 260 NA
ManageIQ/manageiq-schema 862 18150 B 296 72 194 2 28 82.49
ManageIQ/manageiq-api 242 8351 B 210 104 97 7 2 95.44
ManageIQ/manageiq-ui-classic 2841 125151 C 5051 2377 962 204 682 NA
ManageIQ/manageiq-ui-service 409 13193 C 204 180 24 0 0 NA
ManageIQ/manageiq-automation_engine 204 8238 C 177 145 23 2 7 85.31
ManageIQ/manageiq-providers-amazon 124 4623 B 83 52 17 1 13 63.31
ManageIQ/manageiq-providers-ansible_tower 75 1813 A 26 15 9 1 1 83.2
ManageIQ/manageiq-providers-azure 101 3937 C 75 51 15 4 5 74.54
ManageIQ/manageiq-providers-azure_stack 76 1406 A 17 13 0 0 4 NA
ManageIQ/manageiq-providers-google 84 1644 A 16 11 2 0 3 79.14
ManageIQ/manageiq-providers-kubernetes 81 3482 C 49 41 3 1 4 77.37
ManageIQ/manageiq-providers-lenovo 113 3671 A 52 10 38 0 4 48.5
ManageIQ/manageiq-providers-nuage 81 1581 B 20 8 11 0 1 91.73
ManageIQ/manageiq-providers-openshift 63 1281 A 8 4 2 1 1 38.65
ManageIQ/manageiq-providers-openstack 206 10601 B 231 136 79 3 13 73.08
ManageIQ/manageiq-providers-ovirt 126 6642 B 102 70 7 0 25 75.19
ManageIQ/manageiq-providers-redfish 68 1169 C 23 6 16 0 1 70.63
ManageIQ/manageiq-providers-scvmm 67 1683 B 25 14 4 0 7 70.57
ManageIQ/manageiq-providers-vmware 160 7907 C 210 156 26 2 26 66.45
6
PRs (UI, SUI, UI/REACT Components, API ): PRs (UI, SUI, UI/REACT Components): 41 Bugs: 13, Enhancements: 11, Cleanup:
15, Others: 2
Bugs
● Display a validation success message upon DDF credential validation (#7094)
● Rename the features_tree when not in edit mode under Access Control (#7127)
● Don't render empty cd-rom table in VM reconfigure screen (#7110)
● Don't set default value for non-applicable fields (#442)
Enhancements
● Adding parts for NSX-T provider (#7145)
● Add region id to Provider summary (#7101)
● Change to support simplified direct link for assignments (#7100)
● Chargeback Rate: Added support for direct links new/copy to work (#7099)
● Catalog Item: allow for selecting / deselecting whole tenant subtree (#7142)
● Menu - update collapsed user icon (#7122)
● [url_validation.js] Allow for file:// urls (#7105)
UI
(Harpreet Kataria)
7
Chargeback Rate: Added support for direct links new/copy to work (#7099) & Catalog Item: allow for selecting / deselecting
whole tenant subtree (#7142)
Examples of the links:
http://localhost:3000/chargeback_assignment?type=Compute
http://localhost:3000/chargeback_assignment?type=Storage
http://localhost:3000/chargeback_rate/new
http://localhost:3000/chargeback_rate/copy/1
http://localhost:3000/chargeback_rate/edit/1
UI
(Harpreet Kataria)
8
Catalog Item: allow for selecting / deselecting whole tenant subtree (#7142)
UI
(Harpreet Kataria)
9
Menu - update collapsed user icon (#7122)
Before After
UI
(Harpreet Kataria)
10
[url_validation.js] Allow for file:// urls (#7105)
UI
(Harpreet Kataria)
11
Amazon
● Add a bidirectional link between CloudNetworks and CloudRouters (#621)
● Add the new EU South (Milan) region (#630)
Azure
● Change the VmOrTemplate#uid_ems to the Azure VmId attribute (#399)
Google
● Fix GCE instance provisioning not getting assigned external IPs (#144)
PROVIDERS
(Adam Grare)
12
OpenShift
● Save the cluster version and cluster ID (#182)
Ovirt
● Collect VM CPU Affinity (#503, #502)
VMware
● Collect DNS and Route info for VM NICs without smartstate (#591)
● Fix parsing of CustomAttributes (#589)
PROVIDERS
(Adam Grare)
13
42 PRs merged
Enhancements:
● Support OpenID-Connect with the Self Service UI manageiq-appliance/287, manageiq-documentation/1460
● Create env vars to override the full worker image ref manageiq/20297
● Use controllerutil.CreateOrUpdate to maintain postgresql and memcached resources manageiq-pods/542, manageiq-pods/547, manageiq-pods/555
Bugs:
● Conditionally add the messaging environment vars to worker containers manageiq/20268
● Explicitly disable systemd support in podified env manageiq/20277
● Add missing compliance events for container project and physical server manageiq/20267
● Add a flag to gate deploying kafka and zookeeper manageiq-pods/543
Build Improvements:
● Add manifest for gems and npm packages manageiq-rpm_build/64
● Move changelog to a separate file to allow customization manageiq-rpm_build/61
● Move ovirt-ansible-roles requires from kickstart to manageiq-gemset manageiq-rpm_build/58
● Update to CentOS 8.2 manageiq-rpm_build/67
● Run bundle with systemd group manageiq-rpm_build/62
● Remove bundle without config setting manageiq-rpm_build/65
PLATFORM
(Joe VLcek)
14
● Enhanced error messages upon tag assignment failure (Yuri R.) #843
POST /api/vms/54/tags
{
“action” : “assign”,
“resources” : [
“category” : “team”,
“name” : “it_pnp”
]
}
{
“results” : [
{
“success” : “false”,
“message” : “Assigning Tag: category: ‘team’ name: ‘it_pnp’ - FAILED. Tag category ‘team’ not found in region 0”
}
]
}
API
(Alberto Bellotti)
15
● Added an authentication section in product_info (Alberto B.) #856
Needed for the Self-Service UI and other API driven SPAs to handle different authentication mechanisms for login.
GET /api/product_info
{
"name" : "ManageIQ",
"name_full" : "ManageIQ",
"copyright" : "Copyright (c) 2019 ManageIQ. Sponsored by Red Hat Inc.",
"support_website" : "http://www.manageiq.org",
"support_website_text" : "ManageIQ.org",
"branding_info" : { … },
"authentication" : {
"mode" : "httpd",
"oidc_enabled" : true,
"saml_enabled" : false,
"sso_enabled" : true
}
}
API
(Alberto Bellotti)
16
Questions? Discussion?
Sprint 140 Review - July 8
Meeting Start: 10:30 am EST
THANK YOU
manageiq.org github.com/ManageIQ
twitter.com/ManageIQ gitter.im/ManageIQ/manageiq
facebook.com/manageiq talk.manageiq.org
youtube.com/user/ManageIQVideolinkedin.com/company/manageiq

Sprint 139

  • 1.
    SPRINT 139 REVIEW -Sprint Ending June 22, 2020 June 24, 2020 Meeting Start: 10:30 am EST
  • 2.
    2 SPEAKERS ● Overview (OlegBarenboim) ● UI (Harpreet Kataria) ● Providers (Adam Grare) ● Platform (Joe VLcek) ● API (Alberto Bellotti)
  • 3.
  • 4.
    4 * Note thatsome PRs are double labeled or have no labels. Beginning with Sprint 127, archived and forked repos are excluded.
  • 5.
    Repository Files Lines of CodeRating Total Issues Complexity Issues Duplication Issues Bug Risk Issues Style Issues Test Coverage ManageIQ/manageiq 1721 82922 A 1069 473 296 40 260 NA ManageIQ/manageiq-schema 862 18150 B 296 72 194 2 28 82.49 ManageIQ/manageiq-api 242 8351 B 210 104 97 7 2 95.44 ManageIQ/manageiq-ui-classic 2841 125151 C 5051 2377 962 204 682 NA ManageIQ/manageiq-ui-service 409 13193 C 204 180 24 0 0 NA ManageIQ/manageiq-automation_engine 204 8238 C 177 145 23 2 7 85.31 ManageIQ/manageiq-providers-amazon 124 4623 B 83 52 17 1 13 63.31 ManageIQ/manageiq-providers-ansible_tower 75 1813 A 26 15 9 1 1 83.2 ManageIQ/manageiq-providers-azure 101 3937 C 75 51 15 4 5 74.54 ManageIQ/manageiq-providers-azure_stack 76 1406 A 17 13 0 0 4 NA ManageIQ/manageiq-providers-google 84 1644 A 16 11 2 0 3 79.14 ManageIQ/manageiq-providers-kubernetes 81 3482 C 49 41 3 1 4 77.37 ManageIQ/manageiq-providers-lenovo 113 3671 A 52 10 38 0 4 48.5 ManageIQ/manageiq-providers-nuage 81 1581 B 20 8 11 0 1 91.73 ManageIQ/manageiq-providers-openshift 63 1281 A 8 4 2 1 1 38.65 ManageIQ/manageiq-providers-openstack 206 10601 B 231 136 79 3 13 73.08 ManageIQ/manageiq-providers-ovirt 126 6642 B 102 70 7 0 25 75.19 ManageIQ/manageiq-providers-redfish 68 1169 C 23 6 16 0 1 70.63 ManageIQ/manageiq-providers-scvmm 67 1683 B 25 14 4 0 7 70.57 ManageIQ/manageiq-providers-vmware 160 7907 C 210 156 26 2 26 66.45
  • 6.
    6 PRs (UI, SUI,UI/REACT Components, API ): PRs (UI, SUI, UI/REACT Components): 41 Bugs: 13, Enhancements: 11, Cleanup: 15, Others: 2 Bugs ● Display a validation success message upon DDF credential validation (#7094) ● Rename the features_tree when not in edit mode under Access Control (#7127) ● Don't render empty cd-rom table in VM reconfigure screen (#7110) ● Don't set default value for non-applicable fields (#442) Enhancements ● Adding parts for NSX-T provider (#7145) ● Add region id to Provider summary (#7101) ● Change to support simplified direct link for assignments (#7100) ● Chargeback Rate: Added support for direct links new/copy to work (#7099) ● Catalog Item: allow for selecting / deselecting whole tenant subtree (#7142) ● Menu - update collapsed user icon (#7122) ● [url_validation.js] Allow for file:// urls (#7105) UI (Harpreet Kataria)
  • 7.
    7 Chargeback Rate: Addedsupport for direct links new/copy to work (#7099) & Catalog Item: allow for selecting / deselecting whole tenant subtree (#7142) Examples of the links: http://localhost:3000/chargeback_assignment?type=Compute http://localhost:3000/chargeback_assignment?type=Storage http://localhost:3000/chargeback_rate/new http://localhost:3000/chargeback_rate/copy/1 http://localhost:3000/chargeback_rate/edit/1 UI (Harpreet Kataria)
  • 8.
    8 Catalog Item: allowfor selecting / deselecting whole tenant subtree (#7142) UI (Harpreet Kataria)
  • 9.
    9 Menu - updatecollapsed user icon (#7122) Before After UI (Harpreet Kataria)
  • 10.
    10 [url_validation.js] Allow forfile:// urls (#7105) UI (Harpreet Kataria)
  • 11.
    11 Amazon ● Add abidirectional link between CloudNetworks and CloudRouters (#621) ● Add the new EU South (Milan) region (#630) Azure ● Change the VmOrTemplate#uid_ems to the Azure VmId attribute (#399) Google ● Fix GCE instance provisioning not getting assigned external IPs (#144) PROVIDERS (Adam Grare)
  • 12.
    12 OpenShift ● Save thecluster version and cluster ID (#182) Ovirt ● Collect VM CPU Affinity (#503, #502) VMware ● Collect DNS and Route info for VM NICs without smartstate (#591) ● Fix parsing of CustomAttributes (#589) PROVIDERS (Adam Grare)
  • 13.
    13 42 PRs merged Enhancements: ●Support OpenID-Connect with the Self Service UI manageiq-appliance/287, manageiq-documentation/1460 ● Create env vars to override the full worker image ref manageiq/20297 ● Use controllerutil.CreateOrUpdate to maintain postgresql and memcached resources manageiq-pods/542, manageiq-pods/547, manageiq-pods/555 Bugs: ● Conditionally add the messaging environment vars to worker containers manageiq/20268 ● Explicitly disable systemd support in podified env manageiq/20277 ● Add missing compliance events for container project and physical server manageiq/20267 ● Add a flag to gate deploying kafka and zookeeper manageiq-pods/543 Build Improvements: ● Add manifest for gems and npm packages manageiq-rpm_build/64 ● Move changelog to a separate file to allow customization manageiq-rpm_build/61 ● Move ovirt-ansible-roles requires from kickstart to manageiq-gemset manageiq-rpm_build/58 ● Update to CentOS 8.2 manageiq-rpm_build/67 ● Run bundle with systemd group manageiq-rpm_build/62 ● Remove bundle without config setting manageiq-rpm_build/65 PLATFORM (Joe VLcek)
  • 14.
    14 ● Enhanced errormessages upon tag assignment failure (Yuri R.) #843 POST /api/vms/54/tags { “action” : “assign”, “resources” : [ “category” : “team”, “name” : “it_pnp” ] } { “results” : [ { “success” : “false”, “message” : “Assigning Tag: category: ‘team’ name: ‘it_pnp’ - FAILED. Tag category ‘team’ not found in region 0” } ] } API (Alberto Bellotti)
  • 15.
    15 ● Added anauthentication section in product_info (Alberto B.) #856 Needed for the Self-Service UI and other API driven SPAs to handle different authentication mechanisms for login. GET /api/product_info { "name" : "ManageIQ", "name_full" : "ManageIQ", "copyright" : "Copyright (c) 2019 ManageIQ. Sponsored by Red Hat Inc.", "support_website" : "http://www.manageiq.org", "support_website_text" : "ManageIQ.org", "branding_info" : { … }, "authentication" : { "mode" : "httpd", "oidc_enabled" : true, "saml_enabled" : false, "sso_enabled" : true } } API (Alberto Bellotti)
  • 16.
    16 Questions? Discussion? Sprint 140Review - July 8 Meeting Start: 10:30 am EST
  • 17.
    THANK YOU manageiq.org github.com/ManageIQ twitter.com/ManageIQgitter.im/ManageIQ/manageiq facebook.com/manageiq talk.manageiq.org youtube.com/user/ManageIQVideolinkedin.com/company/manageiq