ManageIQ Sprint 135 Review

1. SPRINT 135 REVIEW
- Sprint Ending April 27, 2020
April 29, 2020
Meeting Start: 10:30 am EST

2. 2
SPEAKERS
● Overview (Oleg Barenboim)
● UI (Harpreet Kataria)
● Providers (Adam Grare)
● Platform (Joe VLcek)
● Developer (Jason Frey)

3. 3

4. 4
* Note that some PRs are double labeled or have no labels. Beginning with Sprint 127, archived and forked repos are
excluded.

5. Repository Files
Lines of
Code Rating
Total
Issues
Complexity
Issues
Duplication
Issues
Bug Risk
Issues
Style
Issues Coverage
ManageIQ/manageiq 1741 83313 A 1060 476 287 40 257 NA
ManageIQ/manageiq-schema 850 17719 B 283 68 185 2 28 82.56
ManageIQ/manageiq-api 240 7850 B 200 96 95 7 2 95.29
ManageIQ/manageiq-ui-classic 2913 126553 C 4931 2420 972 194 565 53.84
ManageIQ/manageiq-ui-service 408 13083 C 201 177 24 0 0 NA
ManageIQ/manageiq-automation_engine 204 8296 C 179 147 23 2 7 85.9
ManageIQ/manageiq-content 1548 9383 C 192 77 100 5 10 97.74
ManageIQ/manageiq-providers-amazon 124 4638 B 83 52 17 1 13 64.41
ManageIQ/manageiq-providers-ansible_tower 75 1802 A 24 15 7 1 1 83.23
ManageIQ/manageiq-providers-azure 101 3954 C 75 51 15 4 5 74.01
ManageIQ/manageiq-providers-foreman 56 803 A 11 7 2 0 2 65.38
ManageIQ/manageiq-providers-google 84 1649 A 15 10 2 0 3 77.46
ManageIQ/manageiq-providers-kubernetes 77 3189 C 44 36 3 1 4 84.09
ManageIQ/manageiq-providers-lenovo 113 3671 A 52 10 38 0 4 48.5
ManageIQ/manageiq-providers-nuage 83 1603 B 22 8 13 0 1 91.52
ManageIQ/manageiq-providers-openshift 58 1138 B 9 5 2 1 1 34.79
ManageIQ/manageiq-providers-openstack 202 10372 B 227 133 79 3 12 73.17
ManageIQ/manageiq-providers-ovirt 126 6637 B 102 70 7 0 25 74.56
ManageIQ/manageiq-providers-redfish 69 1286 B 19 6 12 0 1 70.61
ManageIQ/manageiq-providers-scvmm 67 1683 B 25 14 4 0 7 70.11
ManageIQ/manageiq-providers-vmware 160 7737 C 208 153 26 2 27 57.06

6. 6
USER INTERFACE
(Harpreet Kataria)
PRs (UI, SUI, UI/REACT Components, API ): 29 Bugs: 16, Enhancements: 10, Refactoring: 1, others: 2
Bugs
● Add ability for displaying Search bar in the screens without listnav (#6810)
● Fix TreeBuilder#post_check to actually reverse! the nodes (#6979)
Enhancements
● Replace angular-based fonticon picker with a react component (#6985)
● Menu - sort Providers menu together, singular (#6994)
● Converted existing Region edit form to DDF/React/API form (#6978)
● API: check_compliance action support added to following:
○ Host (#811)
○ Instances (#809)
○ Providers (#803)
○ Template (#799)
● API: add tags as lan subcollection (#804)
● API: Adding support for filter_expression in the groups (#806)

7. 7
USER INTERFACE
(Harpreet Kataria)
Menu - sort Providers menu together, singular (#6994)
Before After

8. 8
USER INTERFACE
(Harpreet Kataria)
Add ability for displaying Search bar in the screens without listnav (#6810)

9. 9
USER INTERFACE
(Harpreet Kataria)
API: check_compliance action support
Example of running check_compliance for multiple hosts
curl --user admin:smartvm -i -X POST -H "Accept: application/json" http://localhost:3000/api/hosts -d '{"action":"check_compliance",
"resources": [{"href" : "http://localhost:3000/api/hosts/25"},{"href" : "http://localhost:3000/api/hosts/26"}]}'

10. 10
USER INTERFACE
(Harpreet Kataria)
API: Adding support for filter_expression in the groups (#806)
curl --user admin:smartvm -i -X POST -H "Accept: application/json" http://localhost:3000/api/groups -d '{"action":"create", "resources" :
[{"description": "Test_group", "filters" : {"belongsto":[ "/managed/infra/1", "/managed/infra/2"]},"filter_expression":{"exp": {"and": [{"CONTAINS":
{"tag":"managed-location","value":"ny"}}]} }}]}'
Group Add with expression thru UI

11. 11
Amazon
● Allow targeted refresh of classic Elastic IPs (#618)
○ Classic EIPs don’t have an allocationId which we were using as the manager_ref for the target
○ Dan allowed for allocationId and publicIP to be used which allows both to be targets
Ansible Tower
● Prevent invalid YAML in a Job Template from causing the whole refresh to fail (#218)
○ If the Job Template extra_vars had invalid YAML an exception was raised that caused the whole
refresh to error out
○ Now only invalid job templates will be skipped and the rest of the refresh will complete
successfully
PROVIDERS
(Adam Grare)

12. 12
Kubernetes
● Refactor the main Parser (#370)
○ Remove code specific to legacy refresh that is no longer used
○ Allow for more re-use when parsing watch notifications
Nuage
● Allow for nuage provider to be run from cross_repo-tests
○ Use bundle config to set the BUNDLE_WITH so cross_repo picks it up (#208)
○ Call before_install.sh for all plugins allowing nuage to install qpid_proton (#61)
PROVIDERS
(Adam Grare)

13. 13
PLATFORM
(Joe VLcek)
37 PRs merged
Enhancement:
● Don't run worker pods as root manageiq/20095
● Display warnings for invalid attributes activerecord-virtual_attributes/67
● Bump manageiq-appliance_console to v5.4.0 https://github.com/ManageIQ/manageiq-appliance/pull/279
● Messaging configuration https://github.com/ManageIQ/manageiq-appliance_console/pull/114
Bugs:
● Remove VimString objects from Notification.options manageiq-schema/469
● Use CONTAINER_IMAGE_TAG for worker deployment tag manageiq/20094
● Add an owner reference to the orchestrator pod for all created objects manageiq/20070
● Fixed cockpit process starting manageiq/20077
● Handle user create race condition manageiq/20097

14. 14
PLATFORM
(Joe VLcek)
Build Improvements:
● Create BUILD file for SUI manageiq-pods/463
● Remove postgresql-devel rpm container-amazon-smartstate/8
● Use handsoap gem from rubygems.manageiq.org container-amazon-smartstate/7
● Remove .bowerrc manageiq-appliance/280
Rails 5.2 Upgrade:
● delete MiqExpression#merge_where_clauses to simplify report generation manageiq/20052

15. 15
PLATFORM
(Joe VLcek)
ManageIQ Pods:
Enhancements:
● Watch on all resource types in case of accidental deletion of resources 429
● Update operator-sdk to 0.15.1 432
● Added olm files 446
● Use defaults for missing cr values 451
● Parameterize the orchestrator liveness probe initial delay in the operator 459, 456
● Don't run the app as root 466 468, container-httpd/45
Bug Fixes:
● Encode httpd and postgresql conf as static strings in functions 454
● Send the image tag to the operator 465
● Define and use a role for the orchestrator 440 , 449
Cleanup:
● Change kind to ManageIQ 444
● Add missing httpd readiness probe 458
● add app_name parameter to teardown script 455
● Regenerate the csv files 450
● Regenerate crds to pick up new API field. 445

16. 16
New repositories
● manageiq-rpm_build
○ Scripts for building ManageIQ into RPMs for appliances
○ Moving appliances to an RPM based system for easier maintenance and upgrades
● .github
○ Standard repo for org-level default health files (e.g. CONTRIBUTING.md)
○ https://help.github.com/en/github/building-a-strong-community/creating-a-default-commu
nity-health-file
● ansible-manageiq-automate & ansible-manageiq-vmdb
○ Repositories transferred from github.com/syncrou’s personal account
○ Roles transferred from galaxy.ansible.com/syncrou to galaxy.ansible.com/manageiq
○ Old roles are deprecated, but still usable.
○ Thank you Drew B!
DEVELOPER
(Jason Frey)

17. 17
Enhancements:
● manageiq-cross_repo-tests: Run before_install for all plugins not just core [#61]
Other:
● rubygems.manageiq.org now has new hosting
DEVELOPER
(Jason Frey)

18. 18
Questions? Discussion?
Sprint 136 Review - May 13
Meeting Start: 10:30 am EST

19. THANK YOU
manageiq.org github.com/ManageIQ
twitter.com/ManageIQ gitter.im/ManageIQ/manageiq
facebook.com/manageiq talk.manageiq.org
youtube.com/user/ManageIQVideolinkedin.com/company/manageiq