SPRINT 126 REVIEW
- Sprint Ending December 9, 2019
December 11, 2019
Meeting Start: 10:30 am EST
2
--Hammer-9releasedJul24
--IvanchukBeta1releasedJul29
--IvanchukBeta2releasedAug14
--Hammer-10releasedAug15
--IvanchukRC1releasedAug27
--Hammer-11releasedSep09
--Ivanchuk-1releasedSep18
3
* Note that some PRs are double labeled or have no labels.
4
Repo Health Report - Code Climate
Repository Files Code Smells Duplication Other Issues % Coverage
manageiq 1,705 295 -6 284 -5 470 42 n/a --
manageiq-content 1,604 71 1 132 12 24 0 97% 0%
manageiq-providers-amazon 127 50 0 18 0 15 0 59% 1%
manageiq-providers-ansible_tower 75 13 0 7 0 4 0 82% 0%
manageiq-providers-azure 99 45 -1 15 0 11 0 79% 1%
manageiq-providers-foreman 47 8 0 2 0 4 0 59% 1%
manageiq-providers-google 85 10 0 2 0 3 0 77% 1%
manageiq-providers-kubernetes 86 37 0 5 0 7 -1 65% 0%
manageiq-providers-lenovo 115 10 0 38 0 5 0 90% 0%
manageiq-providers-nuage 84 7 0 13 0 2 0 91% 1%
manageiq-providers-openshift 62 5 0 4 0 2 0 78% 2%
manageiq-providers-openstack 204 129 3 83 -2 20 0 72% 1%
manageiq-providers-ovirt 121 60 -11 7 -13 20 -3 72% 0%
manageiq-providers-scvmm 63 12 0 4 0 3 0 71% 1%
manageiq-providers-vmware 158 217 4 30 4 72 3 70% -1%
manageiq-ui-classic 2,862 2,099 -2 973 10 1,771 78 n/a --
manageiq-ui-service 417 178 0 24 0 0 0 n/a --
5
OVERVIEW
● Community (Carol Chen)
● UI (Harpreet Kataria)
● Providers (Adam Grare)
● Automate (Tina Fitzgerald)
● Platform (Joe VLcek)
● QE (Mike Shriver)
● Summary
6
COMMUNITY UPDATE
(Carol Chen)
● Introduce a new provider: Microsoft Azure Stack (#773)
○ https://www.manageiq.org/blog/2019/12/introducing-new-provider-microsoft-azure-stack/
● Add an authentication configuration example (#774)
○ https://www.manageiq.org/blog/2018/01/troubleshooting-auth/
● ManageIQ + Ansible booth at DevConf.CZ
○ https://www.devconf.info/cz/
○ Jan 24-25, 2020 in Brno, Czech Republic
○ Booth volunteers appreciated!
7
USER INTERFACE
(Harpreet Kataria)
PRs (UI, SUI, UI/REACT Components, V2V): 44 Bugs: 5, Enhancements: 3, Technical Debt/cleanup: 25/2, test: 5,
others: 4
Bugs
● Multiple issues fixed on action edit screen (#6499)
● Machine Credential: don't access options hash when null (#6466)
● Make Save button respond properly on changes in User's Available Groups (#6369)
● Disable Save/Reset buttons after discarding changes for Subscription (#6292)
● CustomButtonSet - handle deleted custom buttons still in button_order (#19573)
● Dialog#destroy should ignore resource actions linking nonexisting entities (#19574)
Enhancements
● V2V: Rename max_concurrent_tasks_per_host setting (#1073)
● V2V: Add popup for warm migrations (#1075)
● Reconfigure: use detailed RBAC features (#6469 , #19566)
8
USER INTERFACE
(Harpreet Kataria)
V2V: Add popup for warm migrations (#1075)
9
USER INTERFACE
(Harpreet Kataria)
Reconfigure: use detailed RBAC features (#6469 , #19566)
Old
New
10
PROVIDERS
(Adam Grare)
Core
● Continue adding queue_name to ems_operations methods (9 more methods this sprint)
○ See this issue for the full list
● Move the logic for queueing C&U target captures into BaseManager::MetricsCapture (#19599)
○ Allow providers to subclass how their captures are queued
● Improve VmScan test coverage for OpenStack and SCVMM (#540, #152)
○ Second to last step in improving pluggability of smartstate scanning (#19469)
OpenStack
● Enable targeted refresh for VolumeTemplates (#541)
○ Improve provisioning from a bootable image that was just created
11
PROVIDERS
(Adam Grare)
Ovirt
● Cleanup settings for ovirt_engine_sdk, it is the only option now (#442)
● Track if a VM configuration change requires a restart (#443)
○ On Ovirt some changes e.g. changing the number of CPUs on a running VM require the VM to be rebooted
before the change takes place
VMware
● Default to streaming refresh (#434)
○ Except for the daily fulls, every refresh is “targeted” and only updates what changed
○ Bypasses MiqQueue for targeted refreshes, updates from vCenter are parsed and saved directly
○ Greatly improved targeted refresh performance, near realtime updates
● Remove the option for legacy refresh for vCloud (#417)
○ Had to implement graph refresh for the Vmware::NetworkManager
○ Removed the legacy RefreshParser code
12
Automate
(Tina Fitzgerald)
6 PRs
● Ansible Service Automate Timeout execution_ttl (#19558) (#393)
● Ansible Playbook Methods - Update Objects (#381)
● Better Error Handling for Orchestration Stack Provisioning Failures (#19555)
● Update Service Dialog with Reconfigure Values (#19178)
● Rename update Method (#19600)
13
PLATFORM
(Joe VLcek)
38 PRs merged
Enhancements:
● Cu capture move capture queue manageiq/19599
● Rails 52 includes and polymorphic associations activerecord-virtual_attributes/57, activerecord-virtual_attributes/39,
activerecord-virtual_attributes/60
● Add queue_name to multiple places manageiq/19608, manageiq/19570,manageiq/19568, manageiq/19604, manageiq/19603, manageiq/19602,
manageiq/19601, manageiq/19595, manageiq/19614, manageiq/19579
● Adding Support for OpenID-Connect Authentication configuration from the CLI manageiq-appliance_console/104, manageiq-appliance/265,
manageiq_docs/1299
● Update to the new cross_repo gem manageiq-cross_repo-test/23
● Remove seed on rails server start in development manageiq/19535
● Drop support for forking workers, use spawn by default manageiq/19556
Bugs:
● Look up worker by guid not pid manageiq/19557
● Fix currency list on new money gem manageiq/19567
● Raise exception if nested file will never be found manageiq/19537
14
PLATFORM
(Joe VLcek)
Technical Debt/Refactoring:
● Rename: ChargebackRateDetailCurrency -> Currency manageiq/19538
● Remove waiting_for_stop_before_restart monitor status manageiq/19605
● Simplify MiqServer#monitor_workers manageiq/19575
● Remove sync_blacklisted_event_names server queue message manageiq/19559
● Remove to_a call in all_ems_in_zone, fix rubocop warnings manageiq/19561
● OrchestrationStack#update_stack_queue manageiq/19578
● duplicate functions manageiq-appliance_console/103
● unused worker OPTIONS_PARSER_SETTINGS manageiq/19593
● was unused as of 681518f6ad manageiq/19569
● unused server options parsing manageiq/19580
Continuous Integration / Testing:
● Remove description from matchers activerecord-virtual_attributes/59
● separate instantiate with monkey patch to simplify activerecord-virtual_attributes/58
● Make the spec for `workers_quiesced?` make a bit more sense manageiq/19571
15
SUMMARY
Sprint 127 Review - January 8
(4 week sprint)
Meeting Start: 10:30 am EST
16
QE
(Mike Shriver)
Welcome to our newest contributor, Devidas Gaikwad
https://github.com/ManageIQ/integration_tests/releases/tag/17.64.0
THANK YOU
manageiq.org github.com/ManageIQ
twitter.com/ManageIQ gitter.im/ManageIQ/manageiq
facebook.com/manageiq talk.manageiq.org
plus.google.com/+ManageiqOrg youtube.com/user/ManageIQVideo
linkedin.com/company/manageiq

Sprint 126

  • 1.
    SPRINT 126 REVIEW -Sprint Ending December 9, 2019 December 11, 2019 Meeting Start: 10:30 am EST
  • 2.
  • 3.
    3 * Note thatsome PRs are double labeled or have no labels.
  • 4.
    4 Repo Health Report- Code Climate Repository Files Code Smells Duplication Other Issues % Coverage manageiq 1,705 295 -6 284 -5 470 42 n/a -- manageiq-content 1,604 71 1 132 12 24 0 97% 0% manageiq-providers-amazon 127 50 0 18 0 15 0 59% 1% manageiq-providers-ansible_tower 75 13 0 7 0 4 0 82% 0% manageiq-providers-azure 99 45 -1 15 0 11 0 79% 1% manageiq-providers-foreman 47 8 0 2 0 4 0 59% 1% manageiq-providers-google 85 10 0 2 0 3 0 77% 1% manageiq-providers-kubernetes 86 37 0 5 0 7 -1 65% 0% manageiq-providers-lenovo 115 10 0 38 0 5 0 90% 0% manageiq-providers-nuage 84 7 0 13 0 2 0 91% 1% manageiq-providers-openshift 62 5 0 4 0 2 0 78% 2% manageiq-providers-openstack 204 129 3 83 -2 20 0 72% 1% manageiq-providers-ovirt 121 60 -11 7 -13 20 -3 72% 0% manageiq-providers-scvmm 63 12 0 4 0 3 0 71% 1% manageiq-providers-vmware 158 217 4 30 4 72 3 70% -1% manageiq-ui-classic 2,862 2,099 -2 973 10 1,771 78 n/a -- manageiq-ui-service 417 178 0 24 0 0 0 n/a --
  • 5.
    5 OVERVIEW ● Community (CarolChen) ● UI (Harpreet Kataria) ● Providers (Adam Grare) ● Automate (Tina Fitzgerald) ● Platform (Joe VLcek) ● QE (Mike Shriver) ● Summary
  • 6.
    6 COMMUNITY UPDATE (Carol Chen) ●Introduce a new provider: Microsoft Azure Stack (#773) ○ https://www.manageiq.org/blog/2019/12/introducing-new-provider-microsoft-azure-stack/ ● Add an authentication configuration example (#774) ○ https://www.manageiq.org/blog/2018/01/troubleshooting-auth/ ● ManageIQ + Ansible booth at DevConf.CZ ○ https://www.devconf.info/cz/ ○ Jan 24-25, 2020 in Brno, Czech Republic ○ Booth volunteers appreciated!
  • 7.
    7 USER INTERFACE (Harpreet Kataria) PRs(UI, SUI, UI/REACT Components, V2V): 44 Bugs: 5, Enhancements: 3, Technical Debt/cleanup: 25/2, test: 5, others: 4 Bugs ● Multiple issues fixed on action edit screen (#6499) ● Machine Credential: don't access options hash when null (#6466) ● Make Save button respond properly on changes in User's Available Groups (#6369) ● Disable Save/Reset buttons after discarding changes for Subscription (#6292) ● CustomButtonSet - handle deleted custom buttons still in button_order (#19573) ● Dialog#destroy should ignore resource actions linking nonexisting entities (#19574) Enhancements ● V2V: Rename max_concurrent_tasks_per_host setting (#1073) ● V2V: Add popup for warm migrations (#1075) ● Reconfigure: use detailed RBAC features (#6469 , #19566)
  • 8.
    8 USER INTERFACE (Harpreet Kataria) V2V:Add popup for warm migrations (#1075)
  • 9.
    9 USER INTERFACE (Harpreet Kataria) Reconfigure:use detailed RBAC features (#6469 , #19566) Old New
  • 10.
    10 PROVIDERS (Adam Grare) Core ● Continueadding queue_name to ems_operations methods (9 more methods this sprint) ○ See this issue for the full list ● Move the logic for queueing C&U target captures into BaseManager::MetricsCapture (#19599) ○ Allow providers to subclass how their captures are queued ● Improve VmScan test coverage for OpenStack and SCVMM (#540, #152) ○ Second to last step in improving pluggability of smartstate scanning (#19469) OpenStack ● Enable targeted refresh for VolumeTemplates (#541) ○ Improve provisioning from a bootable image that was just created
  • 11.
    11 PROVIDERS (Adam Grare) Ovirt ● Cleanupsettings for ovirt_engine_sdk, it is the only option now (#442) ● Track if a VM configuration change requires a restart (#443) ○ On Ovirt some changes e.g. changing the number of CPUs on a running VM require the VM to be rebooted before the change takes place VMware ● Default to streaming refresh (#434) ○ Except for the daily fulls, every refresh is “targeted” and only updates what changed ○ Bypasses MiqQueue for targeted refreshes, updates from vCenter are parsed and saved directly ○ Greatly improved targeted refresh performance, near realtime updates ● Remove the option for legacy refresh for vCloud (#417) ○ Had to implement graph refresh for the Vmware::NetworkManager ○ Removed the legacy RefreshParser code
  • 12.
    12 Automate (Tina Fitzgerald) 6 PRs ●Ansible Service Automate Timeout execution_ttl (#19558) (#393) ● Ansible Playbook Methods - Update Objects (#381) ● Better Error Handling for Orchestration Stack Provisioning Failures (#19555) ● Update Service Dialog with Reconfigure Values (#19178) ● Rename update Method (#19600)
  • 13.
    13 PLATFORM (Joe VLcek) 38 PRsmerged Enhancements: ● Cu capture move capture queue manageiq/19599 ● Rails 52 includes and polymorphic associations activerecord-virtual_attributes/57, activerecord-virtual_attributes/39, activerecord-virtual_attributes/60 ● Add queue_name to multiple places manageiq/19608, manageiq/19570,manageiq/19568, manageiq/19604, manageiq/19603, manageiq/19602, manageiq/19601, manageiq/19595, manageiq/19614, manageiq/19579 ● Adding Support for OpenID-Connect Authentication configuration from the CLI manageiq-appliance_console/104, manageiq-appliance/265, manageiq_docs/1299 ● Update to the new cross_repo gem manageiq-cross_repo-test/23 ● Remove seed on rails server start in development manageiq/19535 ● Drop support for forking workers, use spawn by default manageiq/19556 Bugs: ● Look up worker by guid not pid manageiq/19557 ● Fix currency list on new money gem manageiq/19567 ● Raise exception if nested file will never be found manageiq/19537
  • 14.
    14 PLATFORM (Joe VLcek) Technical Debt/Refactoring: ●Rename: ChargebackRateDetailCurrency -> Currency manageiq/19538 ● Remove waiting_for_stop_before_restart monitor status manageiq/19605 ● Simplify MiqServer#monitor_workers manageiq/19575 ● Remove sync_blacklisted_event_names server queue message manageiq/19559 ● Remove to_a call in all_ems_in_zone, fix rubocop warnings manageiq/19561 ● OrchestrationStack#update_stack_queue manageiq/19578 ● duplicate functions manageiq-appliance_console/103 ● unused worker OPTIONS_PARSER_SETTINGS manageiq/19593 ● was unused as of 681518f6ad manageiq/19569 ● unused server options parsing manageiq/19580 Continuous Integration / Testing: ● Remove description from matchers activerecord-virtual_attributes/59 ● separate instantiate with monkey patch to simplify activerecord-virtual_attributes/58 ● Make the spec for `workers_quiesced?` make a bit more sense manageiq/19571
  • 15.
    15 SUMMARY Sprint 127 Review- January 8 (4 week sprint) Meeting Start: 10:30 am EST
  • 16.
    16 QE (Mike Shriver) Welcome toour newest contributor, Devidas Gaikwad https://github.com/ManageIQ/integration_tests/releases/tag/17.64.0
  • 17.
    THANK YOU manageiq.org github.com/ManageIQ twitter.com/ManageIQgitter.im/ManageIQ/manageiq facebook.com/manageiq talk.manageiq.org plus.google.com/+ManageiqOrg youtube.com/user/ManageIQVideo linkedin.com/company/manageiq