SPRINT 147 REVIEW
- Sprint Ending October 12, 2020
October 14, 2020
Meeting Start: 10:30 am EST
2
SPEAKERS
● Overview
● UI (Harpreet Kataria)
● Providers (Adam Grare)
● Platform (Joe VLcek)
● API (Alberto Bellotti)
3
4
* Note that some PRs are double labeled or have no labels. Beginning with Sprint 127, archived and forked repos are
excluded.
Core Repositories
Repository Files
Lines of
Code Rating
Total
Issues
Complexity
Issues
Duplication
Issues
Bug Risk
Issues
Style
Issues
Test
Coverage
ManageIQ/manageiq 1723 82339 A 1038 466 275 38 259 NA
ManageIQ/manageiq-schema 888 18568 A 235 5 200 2 28 82.27
ManageIQ/manageiq-api 251 8613 A 134 21 103 7 3 94.07
ManageIQ/manageiq-ui-classic 2869 123764 C 4988 2320 953 222 625 NA
ManageIQ/manageiq-ui-service 404 13106 C 203 179 24 0 0 NA
ManageIQ/manageiq-automation_engine 204 8232 C 177 145 23 2 7 85.74
ManageIQ/manageiq-content 1516 9310 B 178 66 98 4 10 97.83
Provider Repositories
Repository Files
Lines of
Code Rating
Total
Issues
Complexity
Issues
Duplication
Issues
Bug Risk
Issues
Style
Issues
Test
Coverage
ManageIQ/manageiq-providers-amazon 127 4677 A 37 5 17 1 14 65.28
ManageIQ/manageiq-providers-ansible_tower 76 1873 A 14 3 9 1 1 83.01
ManageIQ/manageiq-providers-autosde 116 11382 D 167 32 71 0 64 NA
ManageIQ/manageiq-providers-azure 103 3949 A 34 10 15 4 5 74.64
ManageIQ/manageiq-providers-azure_stack 78 1418 A 7 3 0 0 4 NA
ManageIQ/manageiq-providers-foreman 57 867 A 4 0 2 0 2 67.24
ManageIQ/manageiq-providers-google 85 1638 A 6 1 2 0 3 34.87
ManageIQ/manageiq-providers-ibm_cloud 100 1848 A 12 1 8 0 3 52.97
ManageIQ/manageiq-providers-ibm_terraform 43 389 A 2 0 0 0 2 75.38
ManageIQ/manageiq-providers-kubernetes 82 4183 A 15 3 8 1 3 75.71
ManageIQ/manageiq-providers-lenovo 114 3690 A 45 3 38 0 4 48.46
ManageIQ/manageiq-providers-nsxt 94 2459 D 72 1 61 0 10 NA
ManageIQ/manageiq-providers-nuage 84 1758 A 14 2 11 0 1 90.71
ManageIQ/manageiq-providers-openshift 64 1297 A 6 2 2 1 1 39.49
ManageIQ/manageiq-providers-openstack 210 10896 A 133 25 84 3 21 74.05
ManageIQ/manageiq-providers-ovirt 129 6756 A 39 6 7 0 26 75.22
ManageIQ/manageiq-providers-redfish 71 1165 B 17 0 16 0 1 71.13
ManageIQ/manageiq-providers-scvmm 68 1737 A 13 2 4 0 7 70.28
ManageIQ/manageiq-providers-vmware 166 8453 A 100 40 28 2 30 66.32
7
PRs (UI, SUI, UI/REACT Components, API ): PRs (UI, SUI, UI/REACT Components): 44 Bugs: 10, Enhancements: 17,
Dependencies: 8, cleanup: 4, other: 5
Enhancements
● Override Navbar component (#7389)
● Introducing the TreeView component for DDF without React (#7356)
● Added UI support to add/edit OVF Template type Catalog Item(s) (#7370)
● Add console link to Configuration Profile (#7371)
● [IVANCHUK] Support for ovirt native console (#7372)
● Add name to Configuration Profile (#7352)
● Add New Subnet without Cloud Tenant (#7383)
● Implementing storage-resource functionality for block storages (#7342)
● Implementing add/edit new block storage manager functionality(#7345,#7354)
● Add IBM PowerVS to Cloud Volume create form (#7351)
Bugs
● Fix for Configuration Provider appearing twice (#7381)
● /dashboard/logout: don't remember logout as start_url when session invalid (#7388)
UI
(Harpreet Kataria)
8
Add console link to Configuration Profile (#7371)
UI
(Harpreet Kataria)
9
[IVANCHUK] Support for ovirt native console (#7372)
UI
(Harpreet Kataria)
10
Add name to Configuration Profile (#7352)
UI
(Harpreet Kataria)
11
Add New Subnet without Cloud Tenant (#7383)
UI
(Harpreet Kataria)
12
Implementing storage-resource functionality for block storages (#7342)
UI
(Harpreet Kataria)
13
Implementing add/edit new block storage manager functionality(#7345,#7354)
UI
(Harpreet Kataria)
14
Add IBM PowerVS to Cloud Volume create form (#7351)
UI
(Harpreet Kataria)
15
Core
● Refactor combined manager refresh worker queue names (#20345)
○ Previously cloud+network+storage managers had a queue name which was a JSON array
○ Required us to JSON.parse the queue_name for everything
○ Now we simply delegate queue_name_for_ems_refresh to parent_manager
● Fix STI initialization of Authentications (#20635)
○ Authentication#new was ignoring :type and creating everything as AuthUseridPassword
○ This caused providers with AuthToken type authentications to not have an initial auth check
queued
PROVIDERS
(Adam Grare)
16
Amazon
● Fix tenant_id not being set on child managers (#652)
Ansible Tower
● Fix for Refresh Worker not starting up due to zone delegate to provider (#239)
IBM Terraform
● Add a console URL for configuration profiles (#32)
○ Use the provider endpoint and profile id to build a URL to the native provider dashboard
● Set the hostname attribute for a configured system (#34)
PROVIDERS
(Adam Grare)
17
IBM Cloud - Power
● Add hard and soft reset support for instances (#66)
● Add cloud_volume creation (#53) and attach/detach operations (#70)
● Improve error messages for credential validation failures (#79)
● Collect if a cloud_volume is able to be attached to multiple instances (#85)
● Use storage types and flavors when provisioning instances (#57, #58)
IBM Cloud - VPC
● Add StorageManager to VPC collecting cloud_volumes (#54)
● Discover network ports and link to cloud subnets (#69)
● Add 32/64bit attribute to instances (#80)
PROVIDERS
(Adam Grare)
18
VMware vSphere
● Collect VM createDate on vSphere 6.7+ (#645)
● Fix snapshot createTime mismatch causing delete/revert to fail (#633)
● Refactor Vmware::InfraManager#connect method to take a service (#644)
● Fix storages_vms_and_templates join table not being populated by graph refresh (#635)
● Fix DVPortGroup deletion causing the switch to also be deleted (#639)
● Content Library provisioning (#638, #640, #646)
PROVIDERS
(Adam Grare)
19
20
45 PRs merged
Enhancements:
● Prefer ManageIQ::Password over legacy MiqPassword constant manageiq/20631, manageiq-appliance_console/123, manageiq-password/15,
manageiq-password/14, manageiq-password/13, manageiq-password/16
● Remove NTP from core manageiq/20623
● Store the MiqServer GUID for the orchestrator on the CR manageiq-pods/634
Bugs:
● Use inotify to wait for ansible-runner pid file creation manageiq/20666
PLATFORM
(Joe VLcek)
21
Documentation:
● Add section Planning Where to Put a New Virtual Machine PLUS fixing more links 1488
● Update ocp-metrics.md to fix Enabling Cluster Metrics link 1490
● Change RH URLs to relative links within MIQ docs 1489
● Update provisioning_a_vm_using_ssui.md 1483
● Change /self_service to /ui/service 1481
● Updating to fix format and some broken links 1487
● Remove files that are not linked to 1484
PLATFORM
(Joe VLcek)
22
● Enhancement to now allow adding physical storages (Ilya K.) #905
Supporting POST create action on the /api/physical_storages endpoint.
POST /api/physical_storages
{
“name” : “test_storage”,
“ems_id” : “4”,
“physical_storage_family_id” : “1”,
“management_ip” : “192.168.1.201”,
“user” : “test_user”,
“password” : “test_password”
}
Returning the result action signature with the id and href of the task created.
API
(Alberto Bellotti)
23
Questions? Discussion?
Sprint 148 Review - October 28
Meeting Start: 10:30 am EST
THANK YOU
manageiq.org github.com/ManageIQ
twitter.com/ManageIQ gitter.im/ManageIQ/manageiq
facebook.com/manageiq talk.manageiq.org
youtube.com/user/ManageIQVideolinkedin.com/company/manageiq

Sprint 147

  • 1.
    SPRINT 147 REVIEW -Sprint Ending October 12, 2020 October 14, 2020 Meeting Start: 10:30 am EST
  • 2.
    2 SPEAKERS ● Overview ● UI(Harpreet Kataria) ● Providers (Adam Grare) ● Platform (Joe VLcek) ● API (Alberto Bellotti)
  • 3.
  • 4.
    4 * Note thatsome PRs are double labeled or have no labels. Beginning with Sprint 127, archived and forked repos are excluded.
  • 5.
    Core Repositories Repository Files Linesof Code Rating Total Issues Complexity Issues Duplication Issues Bug Risk Issues Style Issues Test Coverage ManageIQ/manageiq 1723 82339 A 1038 466 275 38 259 NA ManageIQ/manageiq-schema 888 18568 A 235 5 200 2 28 82.27 ManageIQ/manageiq-api 251 8613 A 134 21 103 7 3 94.07 ManageIQ/manageiq-ui-classic 2869 123764 C 4988 2320 953 222 625 NA ManageIQ/manageiq-ui-service 404 13106 C 203 179 24 0 0 NA ManageIQ/manageiq-automation_engine 204 8232 C 177 145 23 2 7 85.74 ManageIQ/manageiq-content 1516 9310 B 178 66 98 4 10 97.83
  • 6.
    Provider Repositories Repository Files Linesof Code Rating Total Issues Complexity Issues Duplication Issues Bug Risk Issues Style Issues Test Coverage ManageIQ/manageiq-providers-amazon 127 4677 A 37 5 17 1 14 65.28 ManageIQ/manageiq-providers-ansible_tower 76 1873 A 14 3 9 1 1 83.01 ManageIQ/manageiq-providers-autosde 116 11382 D 167 32 71 0 64 NA ManageIQ/manageiq-providers-azure 103 3949 A 34 10 15 4 5 74.64 ManageIQ/manageiq-providers-azure_stack 78 1418 A 7 3 0 0 4 NA ManageIQ/manageiq-providers-foreman 57 867 A 4 0 2 0 2 67.24 ManageIQ/manageiq-providers-google 85 1638 A 6 1 2 0 3 34.87 ManageIQ/manageiq-providers-ibm_cloud 100 1848 A 12 1 8 0 3 52.97 ManageIQ/manageiq-providers-ibm_terraform 43 389 A 2 0 0 0 2 75.38 ManageIQ/manageiq-providers-kubernetes 82 4183 A 15 3 8 1 3 75.71 ManageIQ/manageiq-providers-lenovo 114 3690 A 45 3 38 0 4 48.46 ManageIQ/manageiq-providers-nsxt 94 2459 D 72 1 61 0 10 NA ManageIQ/manageiq-providers-nuage 84 1758 A 14 2 11 0 1 90.71 ManageIQ/manageiq-providers-openshift 64 1297 A 6 2 2 1 1 39.49 ManageIQ/manageiq-providers-openstack 210 10896 A 133 25 84 3 21 74.05 ManageIQ/manageiq-providers-ovirt 129 6756 A 39 6 7 0 26 75.22 ManageIQ/manageiq-providers-redfish 71 1165 B 17 0 16 0 1 71.13 ManageIQ/manageiq-providers-scvmm 68 1737 A 13 2 4 0 7 70.28 ManageIQ/manageiq-providers-vmware 166 8453 A 100 40 28 2 30 66.32
  • 7.
    7 PRs (UI, SUI,UI/REACT Components, API ): PRs (UI, SUI, UI/REACT Components): 44 Bugs: 10, Enhancements: 17, Dependencies: 8, cleanup: 4, other: 5 Enhancements ● Override Navbar component (#7389) ● Introducing the TreeView component for DDF without React (#7356) ● Added UI support to add/edit OVF Template type Catalog Item(s) (#7370) ● Add console link to Configuration Profile (#7371) ● [IVANCHUK] Support for ovirt native console (#7372) ● Add name to Configuration Profile (#7352) ● Add New Subnet without Cloud Tenant (#7383) ● Implementing storage-resource functionality for block storages (#7342) ● Implementing add/edit new block storage manager functionality(#7345,#7354) ● Add IBM PowerVS to Cloud Volume create form (#7351) Bugs ● Fix for Configuration Provider appearing twice (#7381) ● /dashboard/logout: don't remember logout as start_url when session invalid (#7388) UI (Harpreet Kataria)
  • 8.
    8 Add console linkto Configuration Profile (#7371) UI (Harpreet Kataria)
  • 9.
    9 [IVANCHUK] Support forovirt native console (#7372) UI (Harpreet Kataria)
  • 10.
    10 Add name toConfiguration Profile (#7352) UI (Harpreet Kataria)
  • 11.
    11 Add New Subnetwithout Cloud Tenant (#7383) UI (Harpreet Kataria)
  • 12.
    12 Implementing storage-resource functionalityfor block storages (#7342) UI (Harpreet Kataria)
  • 13.
    13 Implementing add/edit newblock storage manager functionality(#7345,#7354) UI (Harpreet Kataria)
  • 14.
    14 Add IBM PowerVSto Cloud Volume create form (#7351) UI (Harpreet Kataria)
  • 15.
    15 Core ● Refactor combinedmanager refresh worker queue names (#20345) ○ Previously cloud+network+storage managers had a queue name which was a JSON array ○ Required us to JSON.parse the queue_name for everything ○ Now we simply delegate queue_name_for_ems_refresh to parent_manager ● Fix STI initialization of Authentications (#20635) ○ Authentication#new was ignoring :type and creating everything as AuthUseridPassword ○ This caused providers with AuthToken type authentications to not have an initial auth check queued PROVIDERS (Adam Grare)
  • 16.
    16 Amazon ● Fix tenant_idnot being set on child managers (#652) Ansible Tower ● Fix for Refresh Worker not starting up due to zone delegate to provider (#239) IBM Terraform ● Add a console URL for configuration profiles (#32) ○ Use the provider endpoint and profile id to build a URL to the native provider dashboard ● Set the hostname attribute for a configured system (#34) PROVIDERS (Adam Grare)
  • 17.
    17 IBM Cloud -Power ● Add hard and soft reset support for instances (#66) ● Add cloud_volume creation (#53) and attach/detach operations (#70) ● Improve error messages for credential validation failures (#79) ● Collect if a cloud_volume is able to be attached to multiple instances (#85) ● Use storage types and flavors when provisioning instances (#57, #58) IBM Cloud - VPC ● Add StorageManager to VPC collecting cloud_volumes (#54) ● Discover network ports and link to cloud subnets (#69) ● Add 32/64bit attribute to instances (#80) PROVIDERS (Adam Grare)
  • 18.
    18 VMware vSphere ● CollectVM createDate on vSphere 6.7+ (#645) ● Fix snapshot createTime mismatch causing delete/revert to fail (#633) ● Refactor Vmware::InfraManager#connect method to take a service (#644) ● Fix storages_vms_and_templates join table not being populated by graph refresh (#635) ● Fix DVPortGroup deletion causing the switch to also be deleted (#639) ● Content Library provisioning (#638, #640, #646) PROVIDERS (Adam Grare)
  • 19.
  • 20.
    20 45 PRs merged Enhancements: ●Prefer ManageIQ::Password over legacy MiqPassword constant manageiq/20631, manageiq-appliance_console/123, manageiq-password/15, manageiq-password/14, manageiq-password/13, manageiq-password/16 ● Remove NTP from core manageiq/20623 ● Store the MiqServer GUID for the orchestrator on the CR manageiq-pods/634 Bugs: ● Use inotify to wait for ansible-runner pid file creation manageiq/20666 PLATFORM (Joe VLcek)
  • 21.
    21 Documentation: ● Add sectionPlanning Where to Put a New Virtual Machine PLUS fixing more links 1488 ● Update ocp-metrics.md to fix Enabling Cluster Metrics link 1490 ● Change RH URLs to relative links within MIQ docs 1489 ● Update provisioning_a_vm_using_ssui.md 1483 ● Change /self_service to /ui/service 1481 ● Updating to fix format and some broken links 1487 ● Remove files that are not linked to 1484 PLATFORM (Joe VLcek)
  • 22.
    22 ● Enhancement tonow allow adding physical storages (Ilya K.) #905 Supporting POST create action on the /api/physical_storages endpoint. POST /api/physical_storages { “name” : “test_storage”, “ems_id” : “4”, “physical_storage_family_id” : “1”, “management_ip” : “192.168.1.201”, “user” : “test_user”, “password” : “test_password” } Returning the result action signature with the id and href of the task created. API (Alberto Bellotti)
  • 23.
    23 Questions? Discussion? Sprint 148Review - October 28 Meeting Start: 10:30 am EST
  • 24.
    THANK YOU manageiq.org github.com/ManageIQ twitter.com/ManageIQgitter.im/ManageIQ/manageiq facebook.com/manageiq talk.manageiq.org youtube.com/user/ManageIQVideolinkedin.com/company/manageiq