Slides for the Therapeutic Refactoring talk presented at NordicRuby on June 15th, 2012, and Scottish Ruby Conference on June 30th, 2012. The code samples are on github: http://github.com/kytrinyx/therapeutic-refactoring

1. Therapeutic
Refactoring
Katrina Owen
@kytrinyx
github.com/kytrinyx/therapeutic-refactoring

2. Illustration from Am Adult by Allie Brosh
http://hyperboleandahalf.blogspot.com/2010/03/am-adult.html

3. Photo: Johanna Owen 2011

4. Illustration from U B Hatin’ by Allie Brosh
http://hyperboleandahalf.blogspot.com/2010/03/u-b-hatin.html

5. I❤
refactoring

6. Illustration from There’s a Lesson in Here Somewhere, I Think by Allie Brosh
http://hyperboleandahalf.blogspot.com/2010/01/theres-lesson-in-here-somewhere-i-
think.html

7. Illustration from There’s a Lesson in Here Somewhere, I Think by Allie Brosh
http://hyperboleandahalf.blogspot.com/2010/01/theres-lesson-in-here-somewhere-i-
think.html

8. refactoring
is not
rehacktoring

9. A Story
Inspired by true events

10. Illustration from The Scariest Story by Allie Brosh
http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html

11. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

12. Illustration from The Scariest Story by Allie Brosh
http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html

13. Illustration from The Scariest Story by Allie Brosh
http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html

14. Illustration from The Scariest Story by Allie Brosh
http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html

15. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

16. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

17. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

18. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

19. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

20. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

21. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

22. Tests
(the first middle)

23. describe XYZService do
end

24. describe XYZService do
it "works" do
end
end

25. describe XYZService do
subject { XYZService.xyz_filename(stub) }
it "works" do
end
end

26. describe XYZService do
subject { XYZService.xyz_filename(stub) }
it "works" do
end
end

27. describe XYZService do
subject { XYZService.xyz_filename(stub) }
it "works" do
end
end

28. describe XYZService do
subject { XYZService.xyz_filename(stub) }
it "works" do
subject.should eq("something")
end
end

29. subject.should eq
"something"

30. subject.should eq
"whatever"

31. subject.should eq
"freddy"

32. subject.should eq
"something"

33. Failures:
1) XYZService works
Failure/Error:
subject.should eq("something")
Stub received unexpected message :publish_on with (no args)
# ./xyz_service.rb:6:in `xyz_filename'

34. Failures:
1) XYZService works
Failure/Error:
subject.should eq("something")
Stub received unexpected message :publish_on with (no args)
# ./xyz_service.rb:6:in `xyz_filename'

35. Stub received unexpected message
:publish_on
with (no args)

36. Failures:
1) XYZService works
Failure/Error:
subject.should eq("something")
Stub received unexpected message :publish_on with (no args)
# ./xyz_service.rb:6:in `xyz_filename'

37. # ./xyz_service.rb:6

38. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

39. target.publish_on.
strftime("%d")

40. target.publish_on.
strftime("%d")

41. target.publish_on.
strftime("%d")

42. describe XYZService do
subject { XYZService.xyz_filename(stub) }
it "works" do
end
end

43. describe XYZService do
subject { XYZService.xyz_filename(target) }
it "works" do
end
end

44. describe XYZService do
let(:target) do
stub(:target)
end
subject { XYZService.xyz_filename(target) }
it "works" do
subject.should eq("something")
end
end

45. describe XYZService do
let(:target) do
messages = {
}
stub(:target, messages)
end
subject { XYZService.xyz_filename(target) }
it "works" do
subject.should eq("something")
end
end

46. describe XYZService do
let(:target) do
messages = {
:publish_on => ?
}
stub(:target, messages)
end
subject { XYZService.xyz_filename(target) }
it "works" do
subject.should eq("something")
end
end

47. describe XYZService do
let(:target) do
messages = {
:publish_on => Date.new(2012, 3, 14)
}
stub(:target, messages)
end
subject { XYZService.xyz_filename(target) }
it "works" do
subject.should eq("something")
end
end

48. Stub received unexpected message
:xyz_category_prefix
with (no args)

49. ...
:xyz_category_prefix => ?,
...

50. ...
:xyz_category_prefix => 'abc',
...

51. Stub received unexpected message
:kind
with (no args)

52. ...
:kind => ?
...

53. ...
:kind => 'unicorn'
...

54. Stub received unexpected message
:personal?
with (no args)

55. ...
:personal? => ?
...

56. ...
:personal? => false
...

57. Stub received unexpected message
:id
with (no args)

58. ...
:id => ?
...

59. ...
:id => 1337
...

60. Stub received unexpected message
:title
with (no args)

61. ...
:title => ?
...

62. ...
:title => 'magic & superglue'
...

63. Failures:
1) XYZService works
Failure/Error:
subject.should eq("something")
expected: "something"
got: "14abcunicorn_1337_3f4894ca_magicsuper.jpg"
(compared using ==)
# ./xyz_file_spec.rb:18:in `block (2 levels) in
<top (required)>

64. Failures:
1) XYZService works
Failure/Error:
subject.should eq("something")
#WIN
expected: "something"
got: "14abcunicorn_42_3f4894ca_magicsuper.jpg"
(compared using ==)
# ./xyz_file_spec.rb:18:in `block (2 levels) in
<top (required)>

65. let(:target) do
messages = {
:publish_on => Date.new(2012, 3, 14),
:xyz_category_prefix => 'abc',
:kind => 'unicorn',
:personal? => false,
:id => 1337,
:title => 'magic & superglue'
}
stub(:target, messages)
end

66. Failures:
1) XYZService works
Failure/Error:
subject.should eq("something")
expected: "something"
got: "14abcunicorn_1337_3f4894ca_magicsuper.jpg"
(compared using ==)
# ./xyz_file_spec.rb:18:in `block (2 levels) in
<top (required)>

67. Failures:
1) XYZService works
Failure/Error:
subject.should eq("something")
expected: "something"
got: "14abcunicorn_1337_3f4894ca_magicsuper.jpg"
(compared using ==)
# ./xyz_file_spec.rb:18:in `block (2 levels) in
<top (required)>

68. "14abcunicorn_1337_3f4894ca_magicsuper.jpg"

69. 14abcunicorn
_1337_3f4894ca_
magicsuper.jpg

70. subject.should eq
"14abcunicorn_1337_3f4894ca_magicsuper.jpg"

71. expected
"14abcunicorn_1337_3f4894ca_magicsuper.jpg"
got
"14abcunicorn_1337_59a2b50d_magicsuper.jpg"

72. expected
"14abcunicorn_1337_3f4894ca _magicsuper.jpg"
got
"14abcunicorn_1337_59a2b50d _magicsuper.jpg"

73. subject.should eq
" 14abcunicorn_1337_ 3f4894ca _magicsuper.jpg "

74. subject.should match
/ 14abcunicorn_1337_ [0-9a-f]{8} _magicsuper.jpg /

75. .
Finished in 0.00073 seconds
1 example, 0 failures

76. .
#WIN
Finished in 0.00073 seconds
1 example, 0 failures

77. def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end

78. def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end

79. Illustration from The Scariest Story by Allie Brosh
http://hyperboleandahalf.blogspot.com/2011/02/scariest-story.html

80. def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end

81. target.publish_on.
strftime("%d")

82. :publish_on => Date.new(2012, 3, 14)

83. :publish_on => Date.new(2012, 2, 7)

84. def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end

85. target.kind.gsub("_", "")

86. :kind => 'unicorn'

87. :kind => 'magic_unicorn'

88. def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end

89. target.title.
gsub(/[^[a-z]]/i, '').
downcase

90. :title => 'magic & superglue'

91. :title => 'I <3 Sparkles!!1!'

92. Illustration from Bycicle by Allie Brosh
http://hyperboleandahalf.blogspot.no/2010/07/bicycle.html

93. target.title.
gsub(/[^[a-z]]/i, '').
downcase

94. target.title.
gsub(/[^[a-z]]/i, '').
downcase

95. it "works" { ... }
it "leaves square brackets???"

96. it "leaves square brackets???" do
target.stub(:title => 'i[sparkle]s')
end

97. expected
"07abcmagicunicorn_1337_f3b6d325_i[sparkle] .jpg"
to match
/07abcmagicunicorn_1337_[0-9a-z]{8}_isparkles.jpg/

98. it "works"{ ... }
it "leaves square brackets"{ ... }

99. def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end

100. "_%03d" % (target.age || 0)
if target.personal?

101. "_%03d" % (target.age || 0)
if target.personal?

102. it "works" { ... }
it "leaves square brackets"{ ... }
it "personalizes"

103. it "personalizes" do
target.stub(:personal? => true)
end

104. Stub received unexpected message
:age
with (no args)

105. it "personalizes" do
target.stub(:personal? => true)
target.stub(:age? => 42)
end

106. "_%03d" % (target.age || 0)
if target.personal?

107. "_%03d" % (target.age || 0)
if target.personal?

108. it "works"{ ... }
it "leaves square brackets"{ ... }
it "personalizes"{ ... }
it "handles nil age"

109. it "handles nil age" do
target.stub(:personal? => true)
target.stub(:age? => nil)
end

110. def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end

111. length > 9 ? 9 : length

112. :title => 'I <3 Sparkles!!1!'

113. :title => 'I <3 SPARKLY Sparkles!!1!'

114. it "works" { ... }
it "leaves square brackets" { ... }
it "personalizes" { ... }
it "handles nil age" { ... }
it "handles short titles"

115. it "handles short titles" do
target.stub(:title => ‘O HAI’)
end

116. .....
Finished in 0.00386 seconds
5 examples, 0 failures

117. .....
#WIN
Finished in 0.00386 seconds
5 examples, 0 failures

118. Illustration from This is Why I’ll Never be an Adult by Allie Brosh
http://hyperboleandahalf.blogspot.com/2010/06/this-is-why-ill-never-be-adult.html

119. Refactoring
(the second middle)

120. Refactoring
replace method
with method object

121. class XYZFile
end

122. class XYZFile
def initialize(target)
end
end

123. class XYZFile
attr_reader :target
def initialize(target)
@target = target
end
end

124. class XYZFile
attr_reader :target
def initialize(target)
@target = target
end
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end

125. class XYZFile
...
def self.xyz_filename(target)
...
end
end

126. class XYZFile
...
def xyz_filename(target)
...
end
end

127. class XYZFile
...
def name(target)
...
end
end

128. class XYZFile
...
def name
...
end
end

129. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

130. module XYZService
def self.xyz_filename(target)
end
end

131. require_relative './xyz_file'
module XYZService
def self.xyz_filename(target)
end
end

132. require_relative './xyz_file'
module XYZService
def self.xyz_filename(target)
XYZFile.new
end
end

133. require_relative './xyz_file'
module XYZService
def self.xyz_filename(target)
XYZFile.new(target)
end
end

134. require_relative './xyz_file'
module XYZService
def self.xyz_filename(target)
XYZFile.new(target)
(target).name
end
end

135. .....
Finished in 0.00398 seconds
5 examples, 0 failures

136. .....
#WIN
Finished in 0.00398 seconds
5 examples, 0 failures

137. class XYZFile
...
def name
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

138. class XYZFile
...
def name
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

139. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

140. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

141. class XYZFile
...
def name
...
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
...
end
end

142. class XYZFile
...
def name
...
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
...
end
end

143. class XYZFile
...
def name
...
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
...
end
def truncated_title
end
end

144. class XYZFile
...
def name
...
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
...
end
def truncated_title
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
end
end

145. class XYZFile
...
def name...
def truncated_title
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
end
end

146. class XYZFile
...
def name...
def truncated_title
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
end
end

147. class XYZFile
...
def name...
def truncated_title
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
end
end

148. class XYZFile
...
def name...
def truncated_title
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
truncated_title[0..(truncate_to)]
end
end

149. class XYZFile
...
def name...
def truncated_title
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
truncated_title[0..(truncate_to)]
end
end

150. class XYZFile
...
def name
...
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
...
end
def truncated_title...
end

151. class XYZFile
...
def name
...
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title}"
...
end
def truncated_title...
end

152. class XYZFile
...
def name
...
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title}"
...
end
def truncated_title...
end

153. class XYZFile
...
def name
...
filename << "_#{truncated_title}"
...
end
def truncated_title...
end

154. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def truncated_title...
end

155. class XYZFile
...
def truncated_title
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
truncated_title[0..(truncate_to)]
end
end

156. class XYZFile
...
def truncated_title
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
truncated_title[0..(truncate_to)]
end
end

157. target.title.
gsub(/[^[a-z]]/i, '').
downcase

158. target.title.
gsub(/[^[a-z]]/i, '').
downcase

159. target.title.
gsub(/[^[a-z]]/i, '').
downcase

160. target.title.downcase
gsub(/[^[a-z]]/, '')

161. truncated_title[0..(truncate_to)]

162. truncated_title[0..(truncate_to)]

163. truncated_title[0..truncate_to]

164. truncate_to = length > 9 ? 9 : length
truncated_title[0..truncate_to]

165. truncate_to = length > 9 ? 9 : length
truncated_title[0..9]

166. length = truncated_title.length
truncate_to = length > 9 ? 9 : length
truncated_title[0..9]

167. length = truncated_title.length
truncate_to = length > 9 ? 9 : length
truncated_title[0..9]

168. class XYZFile
...
def truncated_title
truncated_title = target.title.downcase.gsub(/[^[a-z]]/, '')
truncated_title[0..truncate_to]
end
end

169. class XYZFile
...
def truncated_title
truncated_title = target.title.downcase.gsub(/[^[a-z]]/, '')
truncated_title[0..truncate_to]
end
end

170. class XYZFile
...
def truncated_title
target.title.downcase.
gsub(/[^[a-z]]/, '')[0..9]
end
end

171. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def truncated_title...
end

172. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def truncated_title...
end

173. class XYZFile
...
def name
...
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
...
end
def truncated_title...
end

174. class XYZFile
...
def name
...
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
...
end
def noise
end
def truncated_title...
end

175. class XYZFile
...
def name
...
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
...
end
def noise
Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]
end
def truncated_title...
end

176. class XYZFile
...
def name
...
filename << "_#{noise}"
...
end
def noise
Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]
end
def truncated_title...
end

177. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def noise...
def truncated_title...
end

178. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def noise...
def truncated_title...
end

179. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def age
"%03d" % (target.age || 0)
end
def noise...
def truncated_title...
end

180. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def age...
def noise...
def truncated_title...
end

181. class XYZFile
...
def name
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def age...
def noise...
def truncated_title...
end

182. class XYZFile
...
def name
filename = "#{publication_day}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def publication_day
target.publish_on.strftime("%d")
end
def age...
def noise...
def truncated_title...
end

183. class XYZFile
...
def name
filename = "#{publication_day}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def publication_day...
def age...
def noise...
def truncated_title...
end

184. class XYZFile
...
def name
filename = "#{publication_day}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def publication_day...
def age...
def noise...
def truncated_title...
end

185. class XYZFile
...
def name
filename = "#{publication_day}"
filename << "#{category}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def category
target.xyz_category_prefix
end
def publication_day...
def age...
def noise...
def truncated_title...

186. class XYZFile
...
def name
filename = "#{publication_day}"
filename << "#{category}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def publication_day...
def category...
def age...
def noise...
def truncated_title...
end

187. class XYZFile
...
def name
filename = "#{publication_day}"
filename << "#{category}"
filename << "#{kind}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def kind
target.kind.gsub("_", "")
end
def publication_day...
def category...
def age...
def noise...

188. class XYZFile
...
def name
filename = "#{publication_day}"
filename << "#{category}"
filename << "#{kind}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def publication_day...
def category...
def kind...
def age...
def noise...
def truncated_title...
end

189. class XYZFile
...
def name
filename = "#{publication_day}"
filename << "#{category}"
filename << "#{kind}"
filename << "_#{age}" if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
return filename
end
def publication_day...
def category...
def kind...
def age...
def noise...
def truncated_title...
end

190. filename = "#{publication_day}"

191. filename = "#{publication_day}"

192. filename = publication_day

193. filename << "#{category}"

194. filename << category

195. filename << "#{kind}"

196. filename << kind

197. filename << "_#{target.id.to_s}"

198. filename << "_#{target.id}"

199. return filename

200. filename

201. class XYZFile
...
def name
filename = publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
filename
end
...
end

202. http://klesgaver.spreadshirt.no/finn-fem-feil-A8534272

203. class XYZFile
...
def name
filename = publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
filename
end
...
end

204. class XYZFile
...
def name
filename = publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
filename
end
...
end

205. class XYZFile
...
def name
filename = publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
filename
end
...
end

206. class XYZFile
...
def name
filename = ""
filename << publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
filename
end
...
end

207. class XYZFile
...
def name
filename = ""
filename << publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
filename
end
...
end

208. class XYZFile
...
def name
filename = ""
filename << publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
filename
end
...
end

209. class XYZFile
...
def name
filename = ""
filename << publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
filename << ".jpg"
filename
end
...
end

210. class XYZFile
...
def name
filename = ""
filename << publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

211. class XYZFile
...
def name
filename = ""
filename << publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

212. class XYZFile
...
def name
filename = ""
filename << publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

213. class XYZFile
...
def name
filename = ""
filename << publication_day
filename << category
filename << kind
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

214. class XYZFile
...
def name
...
filename << publication_day
filename << category
filename << kind
...
end
...
end

215. class XYZFile
...
def name
...
filename << publication_day
filename << category
filename << kind
...
end
def prefix
[publication_day, category, kind].join
end
...
end

216. class XYZFile
...
def name
...
filename << prefix
...
end
def prefix
[publication_day, category, kind].join
end
...
end

217. class XYZFile
...
def name
filename = ""
filename << prefix
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

218. class XYZFile
...
def name
filename = ""
filename << prefix
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

219. class XYZFile
...
def name
filename = []
filename << prefix
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

220. class XYZFile
...
def name
filename = []
filename << prefix
filename << "_#{age}" if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

221. class XYZFile
...
def name
filename = ""
filename << prefix
filename << age if target.personal?
filename << "_#{target.id}"
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

222. class XYZFile
...
def name
filename = []
filename << prefix
filename << age if target.personal?
filename << target.id
filename << "_#{noise}"
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

223. class XYZFile
...
def name
filename = []
filename << prefix
filename << age if target.personal?
filename << target.id
filename << noise
filename << "_#{truncated_title}"
"#{filename}.jpg"
end
...
end

224. class XYZFile
...
def name
filename = []
filename << prefix
filename << age if target.personal?
filename << target.id
filename << noise
filename << truncated_title
"#{filename}.jpg"
end
...
end

225. class XYZFile
...
def name
filename = []
filename << prefix
filename << age if target.personal?
filename << target.id
filename << noise
filename << truncated_title
"#{filename.join("_")}.jpg"
end
...
end

226. class XYZFile
...
def name
filename = []
filename << prefix
filename << age if target.personal?
filename << target.id
filename << noise
filename << truncated_title
"#{filename.join("_")}.jpg"
end
def prefix...
def publication_day...
def category...
def kind...
def age...
def noise...
def truncated_title...
...
end

227. Illustration from About by Allie Brosh
http://hyperboleandahalf.blogspot.com/p/about.html

228. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

229. class XYZFile
...
def name
filename = []
filename << prefix
filename << age if target.personal?
filename << target.id
filename << noise
filename << truncated_title
"#{filename.join("_")}.jpg"
end
def prefix...
def publication_day...
def category...
def kind...
def age...
def noise...
def truncated_title...
...
end

230. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

231. class XYZFile
...
def name
filename = []
filename << prefix
filename << age if target.personal?
filename << target.id
filename << noise
filename << truncated_title
"#{filename.join("_")}.jpg"
end
def prefix...
def publication_day...
def category...
def kind...
def age...
def noise...
def truncated_title...
...
end

232. module XYZService
def self.xyz_filename(target)
# File format:
# [day of month zero-padded][three-letter prefix]
# _[kind]_[age_if_kind_personal]_[target.id]
# _[8 random chars]_[10 first chars of title].jpg
filename = "#{target.publish_on.strftime("%d")}"
filename << "#{target.xyz_category_prefix}"
filename << "#{target.kind.gsub("_", "")}"
filename << "_%03d" % (target.age || 0) if target.personal?
filename << "_#{target.id.to_s}"
filename << "_#{Digest::SHA1.hexdigest(rand(10000).to_s)[0,8]}"
truncated_title = target.title.gsub(/[^[a-z]]/i, '').downcase
length = truncated_title.length
truncate_to = length > 9 ? 9 : length
filename << "_#{truncated_title[0..(truncate_to)]}"
filename << ".jpg"
return filename
end
end

233. class XYZFile
...
def name
filename = []
filename << prefix
filename << age if target.personal?
filename << target.id
filename << noise
filename << truncated_title
"#{filename.join("_")}.jpg"
end
def prefix...
def publication_day...
def category...
def kind...
def age...
def noise...
def truncated_title...
...
end

234. Codejunk
(the ending)

235. Illustration from Chartjunk by Viveka Weiley
http://chartjunk.karmanaut.com/?p=8

236. Illustration from Chartjunk by Viveka Weiley
http://chartjunk.karmanaut.com/test-pattern-retuned/

237. Top 10

238. #10
Lousy Comments

239. module Codejunk
# States the obvious
def state_the_obvious
"whatever"
end
end

240. module Codejunk
# Takes modulus 100
def say_it_again(number)
number % 100
end
end

241. module Codejunk
# Subtracts
def incorrect_comment
1 + 1
end
end

242. module Codejunk
# add
def fuzzy_comment
1 + 1
end
end

243. module Codejunk
# ad too numbers
def bad_comment
1 + 2
end
end

244. #9
Unnecessary Explicit Return

245. module Codejunk
def spurious_return
return "i before e except after c"
end
end

246. #8
Trailing Whitespace

247. module Codejunk ......
..
..
def a_method .
'Use your words' ................
end ...
..
.................
end

248. #7
Commented-Out Code

249. module Codejunk
def tweaked_logic(wday)
# ((7 - wday) % 7) * 1.day
(7 - wday) % 7
end
end

250. module Codejunk
def tweaked_logic(wday)
if false
((7 - wday) % 7) * 1.day
end
(7 - wday) % 7
end
end

251. #6
Needless Parentheses

252. module Codejunk
def spurious_parentheses()
junk()
end
end

253. module Codejunk
def more_spurious_parentheses
(0..(one_method_call)).to_a
end
def one_method_call
(10 - rand(10))
end
end

254. #5
Explicit Default Parameters

255. module Codejunk
def spurious_arguments
[1, 2, 3].join('')
end
end

256. #4
Unnecessary Requires

257. require 'active_support/all'
# Nothing uses active support
module Codejunk
...
end

258. #3
Stringifying Strings

259. module Codejunk
def spurious_string_interpolation
"#{thing}"
end
def thing
"a string"
end
end

260. #2
Too Much Hard Work

261. module Codejunk
def spurious_stringification
"I am #{age.to_s} years old"
end
def age
rand(25) + 15
end
end

262. module Codejunk
def spurious_transformations
[1, 2, 3].map(&:to_s).join
end
end

263. module Codejunk
def spurious_complexity
s = rand(2) == 0 ? "abcde" : "abc"
cutoff = s.length > 4 ? 4 : s.length
s[0..cutoff]
end
end

264. module Codejunk
def spurious_hard_work
s = "I <3 Magic!"
s.gsub(/[^a-z]/i, '').downcase
end
end

265. #1
Duplicated Tests

266. describe Codejunk do
subject { stub.extend(Codejunk) }
it "gets rid of spaces" do
subject.sanitize(" o m g ").should eq('omg')
end
it "gets rid of funky characters" do
subject.sanitize("omg^%#=}{?_").should eq('omg')
end
it "gets rid of numbers" do
subject.sanitize("omg123").should eq('omg')
end
it "downcases everything" do
subject.sanitize("OMG").should eq('omg')
end
end

267. #0
Combine All The Codejunk

268. module Codejunk
def junk
# Subtracts
s = rand(2) == 0 ? "abcde" : "abc"
cutoff = s.length > 4 ? 4 : s.length
s = s[0..cutoff]
s << "#{spurious_string_interpolation()}"
s << "I am #{age.to_s} years old, and "
s << "I <3 Magic!".gsub(/[^a-z]/i, '').downcase
s << "#{(0..(one_method_call)).map(&:to_s).join('')}"
return s
end
end

269. github.com/kytrinyx
/therapeutic-refactoring

270. github.com/kytrinyx
/therapeutic-refactoring

271. github.com/kytrinyx
/therapeutic-refactoring
@kytrinyx
kytrinyx@gmail.com

272. Therapy
(the moral)

274. I❤
refactoring

275. Science!
Working Memory

276. Science!
Problem-Solving Strategies

277. Science!
Worry & Panic

278. Refactoring
makes you smarter!

279. Exobrain

280. Exobrain
counteracts panic

281. Refactoring
makes you happier!

282. Fast Tests

283. Fast Tests
are awesome

284. Happiness

285. Happiness
leads to good design

286. Illustration from God of Cake by Allie Brosh
http://hyperboleandahalf.blogspot.no/2010/10/god-of-cake.html

287. KTHXBYE
Katrina Owen
@kytrinyx
github.com/kytrinyx/therapeutic-refactoring