SlideShare a Scribd company logo
CODE REVIEW CHECKLIST
GENERAL RULES
• DO NOT INSERT CSS STYLES ANYWHERE OTHER THAN APPLICATION.CSS (MELON)
OR SCREEN.CSS / ASSETBUNDLES (YII2)
• DO NOT INSERT JS-CODE ANYWHERE OTHER THAN APPLICATION.JS (MELON) OR JS
FILES, CONNECTED TO ASSETBUNDLES (YII2)
• DO NOT EXECUTE DATABASE DRAWS INSIDE VIEWS. ALL DRAWS MUST BE
PERFORMED IN MODELS / CONTROLLERS / WIDGETS
• DO NOT EXECUTE DATABASE INQUIRIES INSIDE CYCLES. CREATE DRAWING
CONDITIONS CRITERIA INSTEAD.
• AVOID STING CONCATENATION IN LINKS. CREATE LINKS ONLY WITH INNATE TOOLS:
YII – CREATEURL (YII1) OR URL (YII2) CLASS METHODS
ORGANIZATIONAL RULES
• IF THE PROJECT USES THEMES, ALL VIEWS EXCEPT FOR WIDGETS MUST BE
STORED IN THE THEME FOLDER
• INSTEAD OF CDBCRITERIA, USE MELON BUILT-IN SCOPES
• AVOID DUBBING CODE CHAINS. ALL DUBBING PARTS MUST BE TAKEN OUT TO
SEPARATE METHODS / CLASSES / ACTIONS / WIDGETS
• FOR PROCESSING OF LARGE AMOINT OF DATA, USE CDATAPROVIDERITERATOR (YII1)
OR
FOR (YII2)
ActiveRecord::find()->batch(10)
COMPONENTS INSTALLATION RULES
• USE ONLY COMPOSER COMMANDS FOR ADDITION OF NEW
LIBRARIES / EXTENSIONS. IT IS THE ONLY FITTING INSTRUMENT
TO MAINTAIN, UPDATE OR ALTER THE PROJECT’S DEPENDABLES
• ON YOUR LOCAL MACHNE, USE EITHER COMPOSER UPDATE OR
COMPOSER INSTALL
• IN PRODUCTION, USE ONLY COMPOSER INSTALL. THIS COMMAND
WILL INSTALL IDENTICAL VERSIONS OF ALL LIBRARIES, STORED
IN COMPOSER.LOCK
CHECK TOOLS INSTRUCTIONS
FOR AUTO CODE STYLE CHECK IN PHPSTORM:
• INSTALL PHP_CODESNIFFER
• INSTALL PHP_MESSDETECT
• IN PHPSTORM SETTINGS, CONFIGURE EDITOR -> CODE STYLE -> PHP -> SET FROM ->
PREDEFINED STYLES: PSR-1/PSR-2
• FOR (YII1), TICK THE USE TABS BOX
• FOR (YII2), LEAVE IT ON DEFAULT
$ pear install PHP_CodeSniffer
$ pear channel-discover pear.phpmd.org
$ pear channel-discover pear.pdepend.org
$ pear install --alldeps phpmd/PHP_PMD
INSPECT YOUR CODE REGULARLY
WWW.VINTAGE.AGENCY

More Related Content

Similar to Code review process checklist by VINTAGE

WordCamp NYC - DRY CSS
WordCamp NYC - DRY CSSWordCamp NYC - DRY CSS
WordCamp NYC - DRY CSS
Jer Clarke
 
DRY CSS A don’t-repeat-yourself methodology for creating efficient, unified a...
DRY CSS A don’t-repeat-yourself methodology for creating efficient, unified a...DRY CSS A don’t-repeat-yourself methodology for creating efficient, unified a...
DRY CSS A don’t-repeat-yourself methodology for creating efficient, unified a...
Jer Clarke
 
ODD: Extending a Specification 1.3
ODD: Extending a Specification 1.3ODD: Extending a Specification 1.3
ODD: Extending a Specification 1.3
Jonathan Herring
 
Slides-Online-Week2-Website-Frontend-CSS.pptx
Slides-Online-Week2-Website-Frontend-CSS.pptxSlides-Online-Week2-Website-Frontend-CSS.pptx
Slides-Online-Week2-Website-Frontend-CSS.pptx
ahmadraza72678
 
Strategies for SQL Server Index Analysis
Strategies for SQL Server Index AnalysisStrategies for SQL Server Index Analysis
Strategies for SQL Server Index Analysis
Jason Strate
 
Data Extract Views_Katalyst HLS
Data Extract Views_Katalyst HLSData Extract Views_Katalyst HLS
Data Extract Views_Katalyst HLS
Katalyst HLS
 
BEM for Javascript at CampJS III
BEM for Javascript at CampJS IIIBEM for Javascript at CampJS III
BEM for Javascript at CampJS III
Yandex
 
Introduction to cascade style sheets CSS.pdf
Introduction to cascade style sheets CSS.pdfIntroduction to cascade style sheets CSS.pdf
Introduction to cascade style sheets CSS.pdf
Mahmoud268161
 
SSIS by Anjali
SSIS by AnjaliSSIS by Anjali
SSIS by Anjali
GargAnjali
 
ODD: Extending a Specification 1.2
ODD: Extending a Specification 1.2ODD: Extending a Specification 1.2
ODD: Extending a Specification 1.2
Jonathan Herring
 

Similar to Code review process checklist by VINTAGE (10)

WordCamp NYC - DRY CSS
WordCamp NYC - DRY CSSWordCamp NYC - DRY CSS
WordCamp NYC - DRY CSS
 
DRY CSS A don’t-repeat-yourself methodology for creating efficient, unified a...
DRY CSS A don’t-repeat-yourself methodology for creating efficient, unified a...DRY CSS A don’t-repeat-yourself methodology for creating efficient, unified a...
DRY CSS A don’t-repeat-yourself methodology for creating efficient, unified a...
 
ODD: Extending a Specification 1.3
ODD: Extending a Specification 1.3ODD: Extending a Specification 1.3
ODD: Extending a Specification 1.3
 
Slides-Online-Week2-Website-Frontend-CSS.pptx
Slides-Online-Week2-Website-Frontend-CSS.pptxSlides-Online-Week2-Website-Frontend-CSS.pptx
Slides-Online-Week2-Website-Frontend-CSS.pptx
 
Strategies for SQL Server Index Analysis
Strategies for SQL Server Index AnalysisStrategies for SQL Server Index Analysis
Strategies for SQL Server Index Analysis
 
Data Extract Views_Katalyst HLS
Data Extract Views_Katalyst HLSData Extract Views_Katalyst HLS
Data Extract Views_Katalyst HLS
 
BEM for Javascript at CampJS III
BEM for Javascript at CampJS IIIBEM for Javascript at CampJS III
BEM for Javascript at CampJS III
 
Introduction to cascade style sheets CSS.pdf
Introduction to cascade style sheets CSS.pdfIntroduction to cascade style sheets CSS.pdf
Introduction to cascade style sheets CSS.pdf
 
SSIS by Anjali
SSIS by AnjaliSSIS by Anjali
SSIS by Anjali
 
ODD: Extending a Specification 1.2
ODD: Extending a Specification 1.2ODD: Extending a Specification 1.2
ODD: Extending a Specification 1.2
 

Recently uploaded

一比一原版(USYD毕业证)悉尼大学毕业证如何办理
一比一原版(USYD毕业证)悉尼大学毕业证如何办理一比一原版(USYD毕业证)悉尼大学毕业证如何办理
一比一原版(USYD毕业证)悉尼大学毕业证如何办理
k4ncd0z
 
HijackLoader Evolution: Interactive Process Hollowing
HijackLoader Evolution: Interactive Process HollowingHijackLoader Evolution: Interactive Process Hollowing
HijackLoader Evolution: Interactive Process Hollowing
Donato Onofri
 
办理毕业证(NYU毕业证)纽约大学毕业证成绩单官方原版办理
办理毕业证(NYU毕业证)纽约大学毕业证成绩单官方原版办理办理毕业证(NYU毕业证)纽约大学毕业证成绩单官方原版办理
办理毕业证(NYU毕业证)纽约大学毕业证成绩单官方原版办理
uehowe
 
快速办理(Vic毕业证书)惠灵顿维多利亚大学毕业证完成信一模一样
快速办理(Vic毕业证书)惠灵顿维多利亚大学毕业证完成信一模一样快速办理(Vic毕业证书)惠灵顿维多利亚大学毕业证完成信一模一样
快速办理(Vic毕业证书)惠灵顿维多利亚大学毕业证完成信一模一样
3a0sd7z3
 
Bengaluru Dreamin' 24 - Personal Branding
Bengaluru Dreamin' 24 - Personal BrandingBengaluru Dreamin' 24 - Personal Branding
Bengaluru Dreamin' 24 - Personal Branding
Tarandeep Singh
 
Ready to Unlock the Power of Blockchain!
Ready to Unlock the Power of Blockchain!Ready to Unlock the Power of Blockchain!
Ready to Unlock the Power of Blockchain!
Toptal Tech
 
Discover the benefits of outsourcing SEO to India
Discover the benefits of outsourcing SEO to IndiaDiscover the benefits of outsourcing SEO to India
Discover the benefits of outsourcing SEO to India
davidjhones387
 
留学挂科(UofM毕业证)明尼苏达大学毕业证成绩单复刻办理
留学挂科(UofM毕业证)明尼苏达大学毕业证成绩单复刻办理留学挂科(UofM毕业证)明尼苏达大学毕业证成绩单复刻办理
留学挂科(UofM毕业证)明尼苏达大学毕业证成绩单复刻办理
uehowe
 
成绩单ps(UST毕业证)圣托马斯大学毕业证成绩单快速办理
成绩单ps(UST毕业证)圣托马斯大学毕业证成绩单快速办理成绩单ps(UST毕业证)圣托马斯大学毕业证成绩单快速办理
成绩单ps(UST毕业证)圣托马斯大学毕业证成绩单快速办理
ysasp1
 
manuaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaal
manuaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaalmanuaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaal
manuaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaal
wolfsoftcompanyco
 
办理毕业证(UPenn毕业证)宾夕法尼亚大学毕业证成绩单快速办理
办理毕业证(UPenn毕业证)宾夕法尼亚大学毕业证成绩单快速办理办理毕业证(UPenn毕业证)宾夕法尼亚大学毕业证成绩单快速办理
办理毕业证(UPenn毕业证)宾夕法尼亚大学毕业证成绩单快速办理
uehowe
 
快速办理(新加坡SMU毕业证书)新加坡管理大学毕业证文凭证书一模一样
快速办理(新加坡SMU毕业证书)新加坡管理大学毕业证文凭证书一模一样快速办理(新加坡SMU毕业证书)新加坡管理大学毕业证文凭证书一模一样
快速办理(新加坡SMU毕业证书)新加坡管理大学毕业证文凭证书一模一样
3a0sd7z3
 
怎么办理(umiami毕业证书)美国迈阿密大学毕业证文凭证书实拍图原版一模一样
怎么办理(umiami毕业证书)美国迈阿密大学毕业证文凭证书实拍图原版一模一样怎么办理(umiami毕业证书)美国迈阿密大学毕业证文凭证书实拍图原版一模一样
怎么办理(umiami毕业证书)美国迈阿密大学毕业证文凭证书实拍图原版一模一样
rtunex8r
 
存档可查的(USC毕业证)南加利福尼亚大学毕业证成绩单制做办理
存档可查的(USC毕业证)南加利福尼亚大学毕业证成绩单制做办理存档可查的(USC毕业证)南加利福尼亚大学毕业证成绩单制做办理
存档可查的(USC毕业证)南加利福尼亚大学毕业证成绩单制做办理
fovkoyb
 
Should Repositories Participate in the Fediverse?
Should Repositories Participate in the Fediverse?Should Repositories Participate in the Fediverse?
Should Repositories Participate in the Fediverse?
Paul Walk
 
办理新西兰奥克兰大学毕业证学位证书范本原版一模一样
办理新西兰奥克兰大学毕业证学位证书范本原版一模一样办理新西兰奥克兰大学毕业证学位证书范本原版一模一样
办理新西兰奥克兰大学毕业证学位证书范本原版一模一样
xjq03c34
 

Recently uploaded (16)

一比一原版(USYD毕业证)悉尼大学毕业证如何办理
一比一原版(USYD毕业证)悉尼大学毕业证如何办理一比一原版(USYD毕业证)悉尼大学毕业证如何办理
一比一原版(USYD毕业证)悉尼大学毕业证如何办理
 
HijackLoader Evolution: Interactive Process Hollowing
HijackLoader Evolution: Interactive Process HollowingHijackLoader Evolution: Interactive Process Hollowing
HijackLoader Evolution: Interactive Process Hollowing
 
办理毕业证(NYU毕业证)纽约大学毕业证成绩单官方原版办理
办理毕业证(NYU毕业证)纽约大学毕业证成绩单官方原版办理办理毕业证(NYU毕业证)纽约大学毕业证成绩单官方原版办理
办理毕业证(NYU毕业证)纽约大学毕业证成绩单官方原版办理
 
快速办理(Vic毕业证书)惠灵顿维多利亚大学毕业证完成信一模一样
快速办理(Vic毕业证书)惠灵顿维多利亚大学毕业证完成信一模一样快速办理(Vic毕业证书)惠灵顿维多利亚大学毕业证完成信一模一样
快速办理(Vic毕业证书)惠灵顿维多利亚大学毕业证完成信一模一样
 
Bengaluru Dreamin' 24 - Personal Branding
Bengaluru Dreamin' 24 - Personal BrandingBengaluru Dreamin' 24 - Personal Branding
Bengaluru Dreamin' 24 - Personal Branding
 
Ready to Unlock the Power of Blockchain!
Ready to Unlock the Power of Blockchain!Ready to Unlock the Power of Blockchain!
Ready to Unlock the Power of Blockchain!
 
Discover the benefits of outsourcing SEO to India
Discover the benefits of outsourcing SEO to IndiaDiscover the benefits of outsourcing SEO to India
Discover the benefits of outsourcing SEO to India
 
留学挂科(UofM毕业证)明尼苏达大学毕业证成绩单复刻办理
留学挂科(UofM毕业证)明尼苏达大学毕业证成绩单复刻办理留学挂科(UofM毕业证)明尼苏达大学毕业证成绩单复刻办理
留学挂科(UofM毕业证)明尼苏达大学毕业证成绩单复刻办理
 
成绩单ps(UST毕业证)圣托马斯大学毕业证成绩单快速办理
成绩单ps(UST毕业证)圣托马斯大学毕业证成绩单快速办理成绩单ps(UST毕业证)圣托马斯大学毕业证成绩单快速办理
成绩单ps(UST毕业证)圣托马斯大学毕业证成绩单快速办理
 
manuaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaal
manuaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaalmanuaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaal
manuaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaal
 
办理毕业证(UPenn毕业证)宾夕法尼亚大学毕业证成绩单快速办理
办理毕业证(UPenn毕业证)宾夕法尼亚大学毕业证成绩单快速办理办理毕业证(UPenn毕业证)宾夕法尼亚大学毕业证成绩单快速办理
办理毕业证(UPenn毕业证)宾夕法尼亚大学毕业证成绩单快速办理
 
快速办理(新加坡SMU毕业证书)新加坡管理大学毕业证文凭证书一模一样
快速办理(新加坡SMU毕业证书)新加坡管理大学毕业证文凭证书一模一样快速办理(新加坡SMU毕业证书)新加坡管理大学毕业证文凭证书一模一样
快速办理(新加坡SMU毕业证书)新加坡管理大学毕业证文凭证书一模一样
 
怎么办理(umiami毕业证书)美国迈阿密大学毕业证文凭证书实拍图原版一模一样
怎么办理(umiami毕业证书)美国迈阿密大学毕业证文凭证书实拍图原版一模一样怎么办理(umiami毕业证书)美国迈阿密大学毕业证文凭证书实拍图原版一模一样
怎么办理(umiami毕业证书)美国迈阿密大学毕业证文凭证书实拍图原版一模一样
 
存档可查的(USC毕业证)南加利福尼亚大学毕业证成绩单制做办理
存档可查的(USC毕业证)南加利福尼亚大学毕业证成绩单制做办理存档可查的(USC毕业证)南加利福尼亚大学毕业证成绩单制做办理
存档可查的(USC毕业证)南加利福尼亚大学毕业证成绩单制做办理
 
Should Repositories Participate in the Fediverse?
Should Repositories Participate in the Fediverse?Should Repositories Participate in the Fediverse?
Should Repositories Participate in the Fediverse?
 
办理新西兰奥克兰大学毕业证学位证书范本原版一模一样
办理新西兰奥克兰大学毕业证学位证书范本原版一模一样办理新西兰奥克兰大学毕业证学位证书范本原版一模一样
办理新西兰奥克兰大学毕业证学位证书范本原版一模一样
 

Code review process checklist by VINTAGE

  • 2. GENERAL RULES • DO NOT INSERT CSS STYLES ANYWHERE OTHER THAN APPLICATION.CSS (MELON) OR SCREEN.CSS / ASSETBUNDLES (YII2) • DO NOT INSERT JS-CODE ANYWHERE OTHER THAN APPLICATION.JS (MELON) OR JS FILES, CONNECTED TO ASSETBUNDLES (YII2) • DO NOT EXECUTE DATABASE DRAWS INSIDE VIEWS. ALL DRAWS MUST BE PERFORMED IN MODELS / CONTROLLERS / WIDGETS • DO NOT EXECUTE DATABASE INQUIRIES INSIDE CYCLES. CREATE DRAWING CONDITIONS CRITERIA INSTEAD. • AVOID STING CONCATENATION IN LINKS. CREATE LINKS ONLY WITH INNATE TOOLS: YII – CREATEURL (YII1) OR URL (YII2) CLASS METHODS
  • 3. ORGANIZATIONAL RULES • IF THE PROJECT USES THEMES, ALL VIEWS EXCEPT FOR WIDGETS MUST BE STORED IN THE THEME FOLDER • INSTEAD OF CDBCRITERIA, USE MELON BUILT-IN SCOPES • AVOID DUBBING CODE CHAINS. ALL DUBBING PARTS MUST BE TAKEN OUT TO SEPARATE METHODS / CLASSES / ACTIONS / WIDGETS • FOR PROCESSING OF LARGE AMOINT OF DATA, USE CDATAPROVIDERITERATOR (YII1) OR FOR (YII2) ActiveRecord::find()->batch(10)
  • 4. COMPONENTS INSTALLATION RULES • USE ONLY COMPOSER COMMANDS FOR ADDITION OF NEW LIBRARIES / EXTENSIONS. IT IS THE ONLY FITTING INSTRUMENT TO MAINTAIN, UPDATE OR ALTER THE PROJECT’S DEPENDABLES • ON YOUR LOCAL MACHNE, USE EITHER COMPOSER UPDATE OR COMPOSER INSTALL • IN PRODUCTION, USE ONLY COMPOSER INSTALL. THIS COMMAND WILL INSTALL IDENTICAL VERSIONS OF ALL LIBRARIES, STORED IN COMPOSER.LOCK
  • 5. CHECK TOOLS INSTRUCTIONS FOR AUTO CODE STYLE CHECK IN PHPSTORM: • INSTALL PHP_CODESNIFFER • INSTALL PHP_MESSDETECT • IN PHPSTORM SETTINGS, CONFIGURE EDITOR -> CODE STYLE -> PHP -> SET FROM -> PREDEFINED STYLES: PSR-1/PSR-2 • FOR (YII1), TICK THE USE TABS BOX • FOR (YII2), LEAVE IT ON DEFAULT $ pear install PHP_CodeSniffer $ pear channel-discover pear.phpmd.org $ pear channel-discover pear.pdepend.org $ pear install --alldeps phpmd/PHP_PMD
  • 6. INSPECT YOUR CODE REGULARLY WWW.VINTAGE.AGENCY