Atmosphere 2014: Who did this code review, goddammit! - Andrzej Angowski
•
0 likes•214 views
- Who did a code review for this peace, goddammit? - Eh well, you did. - Really? I must have been blind. This simply cannot work! Have you ever heard this discussion before? Studies show that code review main function is not finding bugs. Then what is code review really about? Why most of developers nowadays do it every day? Lecture starts with describing what are the common expectations for code review both from manager’s and developer’s perspective. Then on a contrary speaker tries to persuade the audience what code review is not suited for and why. The lecture concludes on why there is such a similarity between expectations and what code review should not be used for. Andrzej Angowski - The speaker is a Java enthusiast working for the biggest operator of online payments in Poland. He currently holds the role of Senior Java Developer within one of the scrum teams. He is responsible for settlement and reconciliation tools. Previously he worked for international corporation in Telco area creating IPTV middleware as well as data mining and reporting software. He also had an episode with system and network administration. In his spare time he runs carpooling portal and loves to play basketball. He is passionate about automotive and muscle cars in particular. He enjoys spending time with a family and friends.
Recommended
Recommended
More Related Content
Viewers also liked
Viewers also liked (10)
Recently uploaded
Recently uploaded (20)
Atmosphere 2014: Who did this code review, goddammit! - Andrzej Angowski
- 1. Who did this code review, goddammit! Andrzej Angowski
- 2. About me… andrzej.angowski@payu.pl @Linkedin 2Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 3. Agenda 1. Expectatons 2. Reality 3. How to align the two above 3Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 4. Recap @code review 4Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! called pair programming for poor
- 5. Recap @code review 5Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! present @PayU for a long tme
- 6. Recap @code review 6Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! code review AND pair programming
- 7. Expectatons 7Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 8. Expectatons 8Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! not bad by default
- 9. Expectatons 9Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! to low are bad…
- 10. Expectatons 10Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! …to high bad as well
- 11. Expectatons 11Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! they should be just right* ;) *Google’s OKR .6 – .7
- 12. Expectatons – car example 12Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! fast
- 13. Expectatons – car example 13Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! powerful
- 14. Expectatons – car example 14Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! cheap
- 15. Expectatons – car example 15Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! low gasoline consumpton
- 16. 16Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 17. Finding Defects 44% 44% - devops - managers 17Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 18. Code Improvements 39% 31% - devops - managers 18Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 19. Alternatve Solutons 17% 2%* * - no mistake - devops - managers 19Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 20. Knowledge Transfer 8% 20Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! Team Awareness and Transparency 9% Share Code Ownership 6%
- 21. Reality 21Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 22. 22Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 23. Code Improvements 29% 23Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 24. Code Improvement – example 24Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 25. Understanding 22% 25Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! Social Communicaton 16%
- 26. Understanding - example 26Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 27. Finding Defects 27Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! 14%
- 28. Defect – found 28Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 29. Defect – FIXED! 29Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 30. ExpectatonsExpectatons RealityReality 30Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 31. ExpectatonsExpectatons RealityReality 31Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 32. At frst… understand the reason of the change 32Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 33. Reason – ask if not clear! 33Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 34. At second… understand the context of the change 34Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 35. Context – can you spot a defect? 35Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 36. Context – what about now? 36Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 37. At third… widen communicaton channel 37Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 38. Can this be handled face-to-face? 38Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 39. It’s all about… UNDERSTANDING 39Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 40. Additonal tp RESPONSIBILITY is stll yours 40Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 41. Responsibility is yours 41Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! you stll need to test it
- 42. Responsibility is yours 42Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! you are the one to go to if it fails on PROD
- 43. Feeling empowered? 43Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 44. Deploy on PROD without testng? 44Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 45. Additonal tp – other side don’t take someone else’s RESPONSIBILITY 45Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 46. Additonal tp – contnued 46Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! it’s not a must…
- 47. Additonal tp – contnued 47Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit! …but something you want to do! Really!
- 48. Thank you! 48Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 49. Questons? 49Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!
- 50. About me… andrzej.angowski@payu.pl @Linkedin 50Atmosphere, May 2014 Andrzej Angowski – who did this code review, goddammit!