Hands ont3lib_div
Some numbers•   5921 lines•   > 170 methods•   ≈ 30 methods with correct PHPDoc•   39 warnings + 175 weak warnings        ...
Code Coverage• 26 % = 46/176 functions             • Link                            http://bit.ly/pg8Stp
Organizational Mess•   modifyHTMLColor•   strtoupper•   array_merge_recursive_overrule•   writeFile•   linkThisUrl•   imag...
Course Of Action• Public Google Doc with List of All  Methods• Note your moves there• Add your name to the function you wo...
Course Of Action II• Look at the method and what it does  – Is it still needed? Else: Deprecate  – Does the name match? El...
Course Of Action III• Move and rename the function• Run the unit tests• Leave a skeleton of the old function,    – Depreca...
Upcoming SlideShare
Loading in …5
×

t3lib_div refactoring

543 views

Published on

Slides for the T3DD11 workshop about t3lib_div refactoring

0 Comments
0 Likes
Statistics
Notes
  • Be the first to comment

  • Be the first to like this

No Downloads
Views
Total views
543
On SlideShare
0
From Embeds
0
Number of Embeds
3
Actions
Shares
0
Downloads
4
Comments
0
Likes
0
Embeds 0
No embeds

No notes for slide

t3lib_div refactoring

  1. 1. Hands ont3lib_div
  2. 2. Some numbers• 5921 lines• > 170 methods• ≈ 30 methods with correct PHPDoc• 39 warnings + 175 weak warnings http://bit.ly/pg8Stp
  3. 3. Code Coverage• 26 % = 46/176 functions • Link http://bit.ly/pg8Stp
  4. 4. Organizational Mess• modifyHTMLColor• strtoupper• array_merge_recursive_overrule• writeFile• linkThisUrl• imageMagickCommand http://bit.ly/pg8Stp
  5. 5. Course Of Action• Public Google Doc with List of All Methods• Note your moves there• Add your name to the function you work on http://bit.ly/pg8Stp
  6. 6. Course Of Action II• Look at the method and what it does – Is it still needed? Else: Deprecate – Does the name match? Else: Find a new one – Is it covered with unit tests? Else: Write some – Where does the function belong?• Note your findings in the Doc http://bit.ly/pg8Stp
  7. 7. Course Of Action III• Move and rename the function• Run the unit tests• Leave a skeleton of the old function, – Deprecate it – Call the new function inside• Replace occurrences in the Core• Push to Gerrit :-) http://bit.ly/pg8Stp

×