2. Writing Clean Test Code

3. Agenda
● What is Clean Code
● Demo App (AUT)
● Test Code
● Identify Code Smells
● Iteratively Refactor

4. Clean Code
“Clean code is simple and direct. Clean code
reads like well-written prose.”
- Grady Booch
Mentioned in Book “Clean Code: A Handbook of Agile Software Craftsmanship”
by Robert C. Martin

5. Demo App

6. Home Search Results Book Details
Screens

7. Test Code

8. Problem:
No Single Responsibility

9. Problem: No Single Responsibility
● Can change for multiple reasons
● Poor readability and difficult to maintain

10. Page Object Model

11. Page Object Model
● Class that represents Page / UI
Component
● Methods in the class are services offered
by the Page / Component

12. Should Methods Return
Other Page Objects?

13. Pros of Returning Page Objects
● Method conveys correctly what changes
happened on UI
● Allows us to do method chaining

14. Cons of Returning Page Objects
● Pages are tightly coupled
● Special handling is required if same
function have to return different pages
● Duplication of this information as it is
present in both test and page
Page Objects: You're Doing It Wrong by Titus Fortner - https://www.youtube.com/watch?v=vg8um4bYQXI

15. Problem:
Duplication of Locators

16. Problem: Duplication of Locators
● Can change for multiple reasons
● Difficult to maintain

17. Problem:
Missing Simplicity

18. Problem: Missing Simplicity
● Difficult to read and understand the
intent

19. Problem:
Duplication of Code

20. Problem: Unused Imports

21. Problem: Unused Imports
● Causes clutter in the code
● Shows up during search and gives an
incorrect indication that it is being used in
the class

22. Problem: Badly Named
Test Class

23. Problem: Badly Named Test Class
● Difficult to find tests
● Unrelated tests grouped together

24. Note on
Coding Styles & Linting

25. https://vocon-it.com/wp-content/uploads/2016/12/2016-12-28-15_49_04-main-html.png
Coding Style & Linting

26. Is Intent of Test
Getting Conveyed Clearly?

27. Business Layer
Tests Pages
Tests
Business
Layer
Pages
Patterns of a “good” Test Automation Framework by Anand Bagmar -
https://www.youtube.com/watch?v=mNSJuVVq26I

28. Test Code with Business Layer

29. Run Tests after
Small Logical Changes
Commit and Push
Small Changes

30. What more does it take to
write clean tests?

31. Test Code - https://github.com/bitweft/book_information_e2e_tests
Book Information Demo App Code (which includes Espresso tests demo) -
https://github.com/bitweft/book_information_espresso_demo
Clean Code book by Robert C Martin - https://www.amazon.in/Clean-Code-
Robert-C-Martin/dp/8131773388
Page Objects: You're Doing It Wrong by Titus Fortner -
https://www.youtube.com/watch?v=vg8um4bYQXI
Patterns of a “good” Test Automation Framework by Anand Bagmar -
https://www.youtube.com/watch?v=mNSJuVVq26I
References & Links

32. Thank you
@LavanyaMohan210