Successfully reported this slideshow.
We use your LinkedIn profile and activity data to personalize ads and to show you more relevant ads. You can change your ad preferences anytime.

Ruby code review

877 views

Published on

Apresentação no Floripa On Rails sobre code review em ruby. Tenho aprendido muito com code review aqui na Resultados Digitais e a ideia da palestra foi passar um pouco do que tenho aprendido para revisar melhor o código e também construir código mais revisável.

Published in: Software
  • Be the first to comment

Ruby code review

  1. 1. ruby code REVIEW @jonatasdp
  2. 2. current status
  3. 3. blessed :ship:
  4. 4. Developer ||Reviewer
  5. 5. Scenario: developer
  6. 6. your work matters by Kent Beck
  7. 7. meet std-lib
  8. 8. meet std-lib
  9. 9. meet your js framework
  10. 10. meet your web framework
  11. 11. hmm.
  12. 12. knowledge << feedback
  13. 13. learn details
  14. 14. learn even details
  15. 15. feedback matters
  16. 16. feedback matters
  17. 17. feedback = work together
  18. 18. feedback matters
  19. 19. meet your code base
  20. 20. meet your codebase
  21. 21. benchmark EVERYTHING
  22. 22. review before review
  23. 23. review before review
  24. 24. e esse binding.pry aqui? ¬¬
  25. 25. git commit --verbose
  26. 26. gitk
  27. 27. look all PR’s you can!!!
  28. 28. learn from other people
  29. 29. baby steps
  30. 30. avoid same mistake twice
  31. 31. beautiful syntax is basic
  32. 32. will it work?
  33. 33. happy paths are so HAPPY
  34. 34. happy paths are so happy
  35. 35. benchmark your doubts
  36. 36. is the best fit for now?
  37. 37. can I indent your code?
  38. 38. name everything
  39. 39. name your regexes
  40. 40. hack your code
  41. 41. rebase histories in commits
  42. 42. git rebase --interactive
  43. 43. help your reviewer mind
  44. 44. As a developer: provide context enough
  45. 45. Scenario: reviewer
  46. 46. your work matters by Kent Beck
  47. 47. ask if you don’t know
  48. 48. ask. don’t tell.
  49. 49. test/comprove your theory
  50. 50. benchmark things you discover
  51. 51. write beautiful markdown
  52. 52. explain your job on commits
  53. 53. wikify the best knowledge
  54. 54. As a reviewer: “do not believe in perfect Pull Requests” by @joaohornburg
  55. 55. http://shipit.resultadosdigitais.com.br @jonatasdp | ideia.me | jonatas.paganini@resultadosdigitais.com.br Thanks!

×