Code reviews - Leave your ego at the door

3,453 views

Published on

Presentation I held internally at Bigpoint, at the PHP Unconference 2012 in Hamburg (19/08/2012) and at the Barcamp Hamburg (11/03/2012)

Published in: Technology, Business
0 Comments
1 Like
Statistics
Notes
  • Be the first to comment

No Downloads
Views
Total views
3,453
On SlideShare
0
From Embeds
0
Number of Embeds
1,351
Actions
Shares
0
Downloads
24
Comments
0
Likes
1
Embeds 0
No embeds

No notes for slide

Code reviews - Leave your ego at the door

  1. 1. Code Peer ReviewsLeave your ego at the doorFrank SonsSenior Software Engineer
  2. 2. So, what’s this about? Introducing Reviews Collective code ownership Some ways to review code Beware the dragons! 2
  3. 3. A short introduction to reviews Forget about the code for the moment… 3
  4. 4. What’s the idea? Peer review methods are employed to maintain standards, improve performance and provide credibility. 4
  5. 5. Reviews aren’t limited to code… 5
  6. 6. Back to code reviews… IBM: Inspection introduced in 1970s Google: 20% rule used for reviews 6
  7. 7. „That‘s not my code!“Collective code ownership is a mindset 7
  8. 8. What about the ego? „Everyone has the right and freedom to totally suck in private.“ 8
  9. 9. Forget about your ego! „Attempt to be awesome in public and embrace the suck!“ 9
  10. 10. Reviews are knowledge sharing! 10
  11. 11. Share within your team… Product knowledge Technical knowledge Coding Standards Transparency 11
  12. 12. How to reviewA comprehensive overview 12
  13. 13. Ad hoc Just ask someone Takes only a few minutes Happens everywhere Little impact beyond problem Completely informal 13
  14. 14. Peer deskcheck / passaround Asking someone for input Can be done asynchronous Author is not present Good for mentoring and coaching Very informal 14
  15. 15. Pair programming Agile approach Driver and navigator Rapid iterations Cultural change needed Informal review 15
  16. 16. Walkthrough Author explains code Code reading Ideal to present and educate Risk of overlooking critical code Informal, no defined process 16
  17. 17. Team review Used to judge product Check against specifications Preparation needed Review collects data and input Planned and structured 17
  18. 18. Inspection Most formal approach Industry standard Specific roles and trained inspectors Checklist Moderated review 18
  19. 19. “Inspection Walkthrough” Reader doesn‘t know code Experienced dev for „eagle eye“ view Author explains and answers questions Specific code section No leads involved 19
  20. 20. Beware the dragons! It can be tricky… 20
  21. 21. Egoless! My ego is not tied to my „perfect“ or „imperfect“ work product. 21
  22. 22. Avoid the dragons No fingerpointing Leave the egos at the door Resistance to change Lack of knowledge Cultural issues 22
  23. 23. Some things to keep in mind Three to seven participants Not longer than two hours Manager should be involved in planning Find problems, not solutions Review coverage vs. project size 23
  24. 24. JUST DO IT! 24
  25. 25. This helps… 25
  26. 26. I hope you had a good time! Reviews can help your team Reviews are all about the mindset Don‘t fear the dragons 26
  27. 27. Thanks! 27
  28. 28. Bigpoint GmbH Frank SonsSenior Software Engineer Drehbahn 47-48 20354 Hamburg Germany Tel +49 40.88 14 13 - 0Fax +49 40.88 14 13 - 11 f.sons@bigpoint.net www.bigpoint.net Find us on 28

×