According to a 2016 survey by Smart Bear Software code reviews are the #1 way to improve code quality. This presentation will share why you should be reviewing code and some tools and techniques for making your code reviews effective. Presented at OpenWest on 7 June 2018

1. Code Reviews
(Don’t Have to Suck)
Dave Adsit
Lead Architect @ Pluralsight

2. WHY?

4. HOW?

6. • Who - Coder, Reader, Reviewers, Moderator
• How - Multi-hour meeting
• Pros / Cons
Formal Review
Fagan inspection

7. TWO SETS OF EYES

9. OODA Loop
The decision cycle of observe, orient, decide, and act.

10. • Who - You! (and maybe your rubber
duck)
• How - Context shift
• Pros / Cons
Self Review

12. Pull Request
• Who - Coder + 1 or more team members
• How - Branch, PR, Review, Merge
• Pros / Cons

14. Pair Programming
• Who - Two coders
• How - Driver/Navigator
• Pros / Cons

15. Mob Programming
• Who - The Whole Cross-Functional Team
• How - Team
• Pros / Cons

16. TIPS

17. • Create psychological safety
• Be respectful
• Be prepared
• Stay neutral
• Provide constructive criticism
• Stay focused
• Participate
Do

19. • Spend more than 60 minutes reviewing
• Review more than 500 LOC at a time
• Use tools that limit your view of the code
• Waste time on ineffective practices
• Say “you’re wrong”
(instead try “I think that is wrong”)
• Talk too much
Do Not

21. • You are not your code!
• Don’t be a jerk
• Criticism is a gift; though we are often
made uncomfortable giving it
• “Looks good” is not a code review
Remember

23. QUESTIONS?