Ruby on rails, introduction des code smells et de comment faire un refactoring sur ces code smells.

1. Ruby on Rails
4 "Code smells" : un
guide de
simplification

2. Hello !
Je suis Hadrien Blanc
Freelance Software Engineer
@hadrienblanc
2

3. 3

4. Qu'est-ce qu'un "Code Smells" ?
4
It smells good It smells !
The term was popularised by Kent Beck in the late 1990s.
Refactoring: Improving the Design of Existing Code by Martin Fowler.

5. 1. Boolean-Parameter
2. Data Clump
3. Simulated Polymorphism
4. Feature Envy
5. Tools (reek)

6. 1. Boolean-Parameter

7. 1. Boolean-parameter 1/3
7

8. 1. Boolean-parameter 2/3
8

9. 1. Boolean-parameter 2/3
9

10. 1. Boolean-parameter 3/3
10

11. 1. Boolean-parameter 3/3
11

12. 2. Data Clump

13. 2. Data clump 1/4
13

14. 2. Data clump 1/4
14

15. 2. Data clump 2/4
15

16. 2. Data clump 3/4
16

17. 2. Data clump 4/4
17

18. 3. Simulated
Polymorphism

19. 3. Simulated Polymorphism 1/7
19

20. 3. Simulated Polymorphism 2/7
20

21. 3. Simulated Polymorphism 3/7
21

22. 3. Simulated Polymorphism 3/7
22
Objectif :

23. 3. Simulated Polymorphism 4/7
23

24. 3. Simulated Polymorphism 5/7
24

25. 3. Simulated Polymorphism 6/7
25

26. 3. Simulated Polymorphism 7/7
26
Avant / Après

27. 4. Feature Envy

28. 4. Feature Envy 1/7
28

29. 4. Feature Envy 2/7
29

30. 4. Feature Envy 3/7
30

31. 4. Feature Envy 4/7
31

32. 4. Feature Envy 5/7
32

33. 4. Feature Envy 6/7
33

34. 4. Feature Envy 7/7
34

35. 5. Tools

36. Tools : reek
?> reek simcity.rb
tmp/data_clump/simcity.rb -- 2 warnings:
[2, 3, 4, 5]:DataClump: SimCity takes parameters ['color',
'dimention', 'people_inside', 'position'] to 4 methods
[https://github.com/troessner/reek/blob/v5.2.0/docs/Data-Clu
mp.md]
[1]:IrresponsibleModule: SimCity has no descriptive comment
[https://github.com/troessner/reek/blob/v5.2.0/docs/Irresponsible-
Module.md]
36

37. 5. Remarque sur la
magie du naming

38. Remarque : La magie du naming
Utilisation d'un concept mathématique :
Peut-on utiliser un concept plus portée sur la
date ?
38

39. Remarque : La magie du naming
Création d'une abstraction.
Selon le contexte nous pouvons aller plus loin.
39

40. Remarque : La magie du naming
40

41. Hadrien Blanc
@hadrienblanc
blanc.hadrien@gmail.com
41
Merci !

42. Credits
◎ Rails Gem reek https://github.com/troessner/reek
◎ Code clean - Handbook Software Craftsmanship
https://www.amazon.com/Clean-Code-Handbook-Software-Craftsma
nship/dp/0132350882
◎ Refactoring: Improving the Design of Existing Code by Martin
Fowler.
◎ Images : instagram/pejive3
42