Successfully reported this slideshow.
We use your LinkedIn profile and activity data to personalize ads and to show you more relevant ads. You can change your ad preferences anytime.

그래도 다시 코드리뷰

1,428 views

Published on

새로운 환경에서 또 다른 문화의 코드 리뷰를 해보며 느낀점을 공유합니다. 모든 내용은 개인적인 의견입니다.

코드리뷰를 시작하려는 그대에게 : https://www.slideshare.net/JiyeonSeo2/ss-73455188

Published in: Engineering
  • Be the first to comment

그래도 다시 코드리뷰

  1. 1. Code Review2
  2. 2. ? Mar 22, 2017
  3. 3. ~
  4. 4. ~
  5. 5. -> -> -> Github -> Phabricator -> Time zone -> timezone
  6. 6. :
  7. 7. ...
  8. 8. ...
  9. 9. ...
  10. 10. / / w a r n i n g / / (team by team)
  11. 11. ( " " )
  12. 12. Review Status Status .
  13. 13. Review Status In Preparation - . . Needs review - . Needs revision - . Change plans - . . Abandoned - . Accepted - ! .
  14. 14. Review Status In Preparation - Needs review - Needs revision - Change plans - Abandoned - Nil Accepted - Blocker of each status
  15. 15. Review Status In Preparation - Needs review - Needs revision - Change plans - Abandoned - Nil Accepted - Blocker of each status . <-
  16. 16. Review dependency Dependency .
  17. 17. Review dependency Queue .
  18. 18. Review dependency master (1/4) (2/4) (3/4) (4/4) needs review accepted needs revision needs review
  19. 19. Review dependency master (1/4) (2/4) (3/4) (4/4) needs review accepted needs revision needs review <- (1/4) (release)
  20. 20. Review dependency :
  21. 21. Review dependency master (1/4) (2/4) (3/4) (4/4) API API Front (1) - Front (2) -
  22. 22. Review system ( )
  23. 23. ...?
  24. 24. 1. .
  25. 25. ... 1. .
  26. 26. 1. . . .
  27. 27. 1. . , .
  28. 28. 1. . ???
  29. 29. 1. . , . , . :
  30. 30. 1. . ( ) . . . :
  31. 31. 1. . Tips! 1. "[ ] " . 2. . 3. , . :
  32. 32. 2. (integration) . . - " "
  33. 33. 2. CI . .
  34. 34. 2. test
  35. 35. 2. ! !
  36. 36. 3. , , 100 , , ? ... ... ... ...?
  37. 37. 3. " " .
  38. 38. 3. 

  39. 39. 3. , Controller . A 1 B New Controller Utility.someFunction() return Some Response; onClick refresh ( ) ... ( 1 )
  40. 40. 3. , Blame .
  41. 41. 4. , . . . . ( , )
  42. 42. 4. : https://twitter.com/bjlee72/status/1145399466981117952 /
  43. 43. 4. 1. "You" . . , "We" . We can do this way instead of that way. 2. / . "This variable name is extremely vague" . 3. . "THAT IS NOT RIGHT"
  44. 44. 4. ! ! .
  45. 45. 4. 1. 2. 3.
  46. 46. . , . , . . . .
  47. 47. . ( ) ( ) - WIP : Work in Progress / : https://github.com/serverless/serverless/pull/4796
  48. 48. . ( ) ( ) - RFC : Request for comment / : https://github.com/serverless/examples/pull/162
  49. 49. . ( ) ( ) - TY : Thank You! / : https://github.com/facebookincubator/fbt/pull/20
  50. 50. . ( ) ( ) - LGTM : Looks good to me / nit : nit-pick / (?) : https://github.com/babel/babel/pull/9144

×