Successfully reported this slideshow.
Your SlideShare is downloading. ×

Better reviewer

Ad

Better reviewer
By Hieu Nguyen

Ad

WHY?

Ad

How to become
better at code
reviewing?

Ad

Ad

Ad

Ad

Ad

Ad

Ad

Ad

Ad

Ad

Ad

Ad

Ad

Ad

Loading in …3
×

Check these out next

1 of 17 Ad
1 of 17 Ad

Better reviewer

  1. 1. Better reviewer By Hieu Nguyen
  2. 2. WHY?
  3. 3. How to become better at code reviewing?
  4. 4. Good reviewer?
  5. 5. Good review ● Correct ● Insightful ● Professional ● ...
  6. 6. HOW?
  7. 7. ● Better understanding ● More knowledge ● More experience Good reviewer comes from Good developer
  8. 8. Curiosity 1. Why do they do it? 2. Why do they do it like that? 3. If I was them, how will I do it? 4. How is my approach compared to them?
  9. 9. Attitude ● Look at the code, not the people ● No compromise ● Don’t scare of being wrong
  10. 10. HOW?
  11. 11. Make it a habit ● Choose a time ● Choose the PR ● Read the code and review it ● Repeat. Every. Single. Day. ● No excuses
  12. 12. Good developer? ● Read. Read. Read a lot ● Write more (code, articles, books, …)By improving your technical ability
  13. 13. http://aimforsimplicity.com/post/316daysofcode/
  14. 14. Question?
  15. 15. Thank you for listening

Editor's Notes

  • I will not talk about why here as most of us know about why should we do it
  • Because we cannot improve something we don’t know, let’s think about how a reviewer can be called “good” before answering the previous question.
  • Good reviewer is the one who can provide good review, and how is a review that can be called good
  • How to have a review that is correct, insightful and professional?

    Correct comes from knowledge, experience
    Insightful comes from curiosity
    Professional comes from attitude

  • Good reviewer needs to be good developer (even though the opposite is not necessary true). There are no shortcut around that, if you want your review to be good, then you need to strive to be good developer first.

    Though, don’t be discouraged if you think you’re novice. Read more code and review them is also a way to make your code better.
  • If technical ability helps you in creating correct review, then curiosity helps you create insightful one. If you cannot answer any questions in these, ask the creator of the pull request.
  • Given that we know the ability, then how can we achieve them?
  • The most important thing is continuation. Making it a habit will remove the need of willpower, and making reviewing effortless
  • This deserves a book, so I will skim through it

×