Successfully reported this slideshow.

How to Code Review

0

Share

1 of 44
1 of 44

More Related Content

Related Books

Free with a 14 day trial from Scribd

See all

How to Code Review

  1. 1. @dylanninin
  2. 2. OpenPlay 1.0 / - - - … : - http://bit.ly/1TfZFpV
  3. 3. OpenPlay 1.0 - - - … : - http://bit.ly/1Tk7zOX
  4. 4. - if else - - http://bit.ly/1VUBI8f
  5. 5. Rating - rating/motm - rating/motm - … - http://bit.ly/1UE2CCj - http://bit.ly/1PGTPaa
  6. 6. Cub ElasticSearch - - - - … - http://bit.ly/1M25XI1 - http://bit.ly/1M25wxz
  7. 7. Redis pubsub - / - pubsub, list - - http://bit.ly/1M26wSg
  8. 8. Admin Stats - 1.x (MongoDB) —> 2.x (ElasticSearch) - DownloadMixin - crontab -> queue -> queue/msg - http://bit.ly/1VUBrSM - http://bit.ly/1PGTPaa
  9. 9. • • • • • •
  10. 10. Python
  11. 11. >>> import this The Zen of Python, by Tim Peters Beautiful is better than ugly. Explicit is better than implicit. Simple is better than complex. Complex is better than complicated. Flat is better than nested. Sparse is better than dense. Readability counts. Special cases aren't special enough to break the rules. Although practicality beats purity. Errors should never pass silently. Unless explicitly silenced. In the face of ambiguity, refuse the temptation to guess. There should be one-- and preferably only one --obvious way to do it. Although that way may not be obvious at first unless you're Dutch. Now is better than never. Although never is often better than *right* now. If the implementation is hard to explain, it's a bad idea. If the implementation is easy to explain, it may be a good idea. Namespaces are one honking great idea -- let's do more of those!
  12. 12. Hello World
  13. 13. • • • GitHub + Pull Request + Issue • • •
  14. 14. - • • • • • • • • • •
  15. 15. - • • • •
  16. 16. - • • • • • • • ‘TODO’
  17. 17. - • • • • “ “ • API
  18. 18. • • • -
  19. 19. Just Do It
  20. 20. Q & A
  21. 21. Reference • https://en.wikipedia.org/wiki/Code_review • Code Review • What to look for in a Code Review • Stop More Bugs with our Code Review Checklist • code-review-best-practices

×