Successfully reported this slideshow.
We use your LinkedIn profile and activity data to personalize ads and to show you more relevant ads. You can change your ad preferences anytime.

Mastering Code Reviews

16 views

Published on

Does your team do code reviews? If not why? Are you afraid or worried about something? If they do, awesome. Do you want to learn how to improve the process? This session we will dive into the art of the Code Review. We will learn how to avoid pitfalls and how to reap the rewards of this awesome

Published in: Software
  • Be the first to comment

  • Be the first to like this

Mastering Code Reviews

  1. 1. MASTERING CODE REVIEWS DERIK WHITTAKER DERIK.WHITTAKER@GMAIL.COM @DERIKWHITTAKER HTTP://DERIKWHITTAKER.BLOG SENIOR SOFTWARE ENGINEER @ QUICKEN LOANS
  2. 2. PLAN OF ACTION Why do Code Reviews? What Makes a GOOD Code Review? What Makes a BAD Code Review? Explore different TYPES of Code Reviews! Rules of ENGAGEMENT for Code Reviews!
  3. 3. WHAT IS A CODE REVIEW? An examination of code which is intended to find overlooked mistakes which can cause future bugs. With the goal to improve overall quality of code and to share knowledge
  4. 4. WHY DO CODE REVIEWS?
  5. 5. WHY DO CODE REVIEWS? Find potential bugs
  6. 6. WHY DO CODE REVIEWS? Improve System Design
  7. 7. WHY DO CODE REVIEWS? Increase Knowledge Sharing
  8. 8. WHAT MAKES FOR A GOOD CODE REVIEW?
  9. 9. WHAT MAKES FOR A GOOD CODE REVIEW? Have a check list
  10. 10. JAVASCRIPT CHECKLIST IDEAS  Does is pass linting?  Is the code well factored?  Using Promises (or async) vs callbacks  Are variables scoped correctly?  No use of `var`, use Const or Let as appropriate  Has Unit test coverage
  11. 11. WHAT MAKES FOR A GOOD CODE REVIEW? Time Box the Review
  12. 12. WHAT MAKES FOR A GOOD CODE REVIEW? Put in the Effort
  13. 13. WHAT MAKES FOR A GOOD CODE REVIEW? Critique the code, not the coder
  14. 14. WHAT MAKES FOR A GOOD CODE REVIEW? Keeping it Positive
  15. 15. WHAT MAKES FOR A GOOD CODE REVIEW? Attempt to see through the eyes of the Coder
  16. 16. WHAT MAKES FOR A GOOD CODE REVIEW? Ask Productive Questions
  17. 17. WHAT MAKES FOR A BAD CODE REVIEW
  18. 18. WHAT MAKES FOR A BAD CODE REVIEW? Not having a plan
  19. 19. WHAT MAKES FOR A BAD CODE REVIEW? Getting lost in the weeds. (aka focusing on the wrong items)
  20. 20. WHAT MAKES FOR A BAD CODE REVIEW? Attacking the Coder
  21. 21. WHAT MAKES FOR A BAD CODE REVIEW? Talking in Absolutes
  22. 22. WHAT MAKES FOR A BAD CODE REVIEW? Negative Words
  23. 23. WHAT MAKES FOR A BAD CODE REVIEW? Debating Coding Styles
  24. 24. EXPLORE DIFFERENT TYPES OF CODE REVIEWS
  25. 25. EXPLORE DIFFERENT TYPES OF CODE REVIEWS Async Code Reviews!
  26. 26. EXPLORE DIFFERENT TYPES OF CODE REVIEWS Group/Online Review
  27. 27. WHAT THE RULES OF ENGAGEMENT FOR CODE REVIEWS
  28. 28. WHAT THE RULES OF ENGAGEMENT FOR CODE REVIEWS Have a checklist
  29. 29. WHAT THE RULES OF ENGAGEMENT FOR CODE REVIEWS Determine type of code review
  30. 30. WHAT THE RULES OF ENGAGEMENT FOR CODE REVIEWS Determine Comment/Feedback Strategy
  31. 31. WHAT THE RULES OF ENGAGEMENT FOR CODE REVIEWS Determine Requirements for Adopting Feedback
  32. 32. THINGS TO LOOK FOR IN CODE REVIEWS
  33. 33. THINGS TO LOOK FOR IN CODE REVIEWS Logic/Business Bugs
  34. 34. THINGS TO LOOK FOR IN CODE REVIEWS Performance Issues
  35. 35. THINGS TO LOOK FOR IN CODE REVIEWS Overly Complicated/Duplicated Code
  36. 36. THINGS TO LOOK FOR IN CODE REVIEWS Security Concerns
  37. 37. THINGS TO LOOK FOR IN CODE REVIEWS Simplicity over cleverness
  38. 38. THINGS TO LOOK FOR IN CODE REVIEWS Following Existing Patterns

×