Successfully reported this slideshow.
We use your LinkedIn profile and activity data to personalize ads and to show you more relevant ads. You can change your ad preferences anytime.

Educational Code Reviews

Educational Code Reviews at PyCon TW 2018

  • Login to see the comments

  • Be the first to like this

Educational Code Reviews

  1. 1. Educational Code Reviews Adrian Liaw @ PyCon TW 2018
  2. 2. Code Reviews
  3. 3. Why • Ensures quality • Syncs the team • Learn
  4. 4. Wey-Han “Adrian” Liaw 廖偉涵 @adrianliaw2000 adrianliaw
  5. 5. Python • Speaker at previous PyCon TWs • Program Chair at PyCon TW 2018 • Language Coordinator of Python Documentation’s zh_TW translation
  6. 6. Misc. • Classical Pianist
  7. 7. Education • Homeschooled High School Senior • Former Project Reviewer at Udacity
  8. 8. Motivate
  9. 9. Compliment • “Great job on …” • “I really like that you …, outstanding!” • “I wasn’t expecting that you would do … as a …”
  10. 10. Empathise • “Don’t feel bad for not understanding this” • “Believe me, you can do it as well!” • “I know it’s hard, everybody takes time to overcome it”
  11. 11. Guide • “Here’s a hint, you can check out …” • “I encourage you to try searching …, …” • “I challenge you to try out … and see …”
  12. 12. Explain • Explain why for everything • Variable naming, refactoring, using another method, etc. • “The reason is that …” • “It may not seem obvious at first, but …”
  13. 13. Connect • Articles, Talks, Communities, Papers, Videos, etc. • Explain why you connect them • “I suggest you check out this great article, it … very well”
  14. 14. As a Reviewer • It takes patience • It takes practice • It takes …… passion!
  15. 15. • Great job! … • However, … • Finally, …
  16. 16. Thank you @adrianliaw

×