Jakub Vrána: Code Reviews with Phabricator
Upcoming SlideShare
Loading in...5
×
 

Jakub Vrána: Code Reviews with Phabricator

on

  • 431 views

"What's the value of code reviews and how you can do them in Phabricator."

"What's the value of code reviews and how you can do them in Phabricator."

More at http://webexpo.net/prague2013/talk/code-reviews-with-phabricator/

Statistics

Views

Total Views
431
Views on SlideShare
158
Embed Views
273

Actions

Likes
0
Downloads
2
Comments
0

2 Embeds 273

http://webexpo.net 269
http://www.slideee.com 4

Accessibility

Categories

Upload Details

Uploaded via as Adobe PDF

Usage Rights

© All Rights Reserved

Report content

Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

Cancel
  • Full Name Full Name Comment goes here.
    Are you sure you want to
    Your message goes here
    Processing…
Post Comment
Edit your comment

Jakub Vrána: Code Reviews with Phabricator Jakub Vrána: Code Reviews with Phabricator Presentation Transcript

  • Code Reviews with Phabricator Jakub Vrána, WebExpo 2013
  • Phabricator Started as Diffcamp at Facebook Open source Users: Dropbox, Asana, Quora, Uber, … Supports Git, Mercurial, SVN, plain diffs For developers from developers Performs at scale Other tools: GitHub, Critique, …
  • Phabricator Applications Differential: code reviews Diffusion: browse repository Maniphest: tasks and bugs Herald: notifications Owners, Calendar, Wiki, Blog, lots more Conduit: API Arcanist: command line interface
  • Differential: Code, Context Demo
  • Differential: Inline comments Demo
  • Differential: Cross-references Demo
  • Differential: Copies, Moves Demo
  • Diffusion: Stable Links
  • Diffusion: Blame Previous Demo
  • Maniphest: “Not Bad”
  • Herald: Packages
  • Calendar: Reviewer Away
  • Conduit: Method Call
  • Arcanist arc feature: Start working on something arc diff: Send code for review arc land: Publish reviewed code arc cover: Who should review my change arc patch: Apply someone’s revision Several other commands Works on Linux, Mac, Windows
  • Arcanist: Lint
  • Arcanist: Unit Tests Test plan
  • Customization Configuration Extending code Differential fields Remarkup rules Events Custom Arcanist commands Conduit
  • Weaknesses Commit discovery is delayed Some features require manual setup E.g. cross references Hosted repositories should solve both
  • Culture Response within a day Don’t ask for unrelated changes Express strength of your feelings Who reviews the code Who lands the code How is the code tested When is the code linted and tested Pre-commit or post-commit review
  • Thanks