Your SlideShare is downloading. ×
Jakub Vrána: Code Reviews with Phabricator
Upcoming SlideShare
Loading in...5
×

Thanks for flagging this SlideShare!

Oops! An error has occurred.

×
Saving this for later? Get the SlideShare app to save on your phone or tablet. Read anywhere, anytime – even offline.
Text the download link to your phone
Standard text messaging rates apply

Jakub Vrána: Code Reviews with Phabricator

685
views

Published on

"What's the value of code reviews and how you can do them in Phabricator." …

"What's the value of code reviews and how you can do them in Phabricator."

More at http://webexpo.net/prague2013/talk/code-reviews-with-phabricator/

Published in: Technology

0 Comments
3 Likes
Statistics
Notes
  • Be the first to comment

No Downloads
Views
Total Views
685
On Slideshare
0
From Embeds
0
Number of Embeds
5
Actions
Shares
0
Downloads
6
Comments
0
Likes
3
Embeds 0
No embeds

Report content
Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

Cancel
No notes for slide

Transcript

  • 1. Code Reviews with Phabricator Jakub Vrána, WebExpo 2013
  • 2. Phabricator Started as Diffcamp at Facebook Open source Users: Dropbox, Asana, Quora, Uber, … Supports Git, Mercurial, SVN, plain diffs For developers from developers Performs at scale Other tools: GitHub, Critique, …
  • 3. Phabricator Applications Differential: code reviews Diffusion: browse repository Maniphest: tasks and bugs Herald: notifications Owners, Calendar, Wiki, Blog, lots more Conduit: API Arcanist: command line interface
  • 4. Differential: Code, Context Demo
  • 5. Differential: Inline comments Demo
  • 6. Differential: Cross-references Demo
  • 7. Differential: Copies, Moves Demo
  • 8. Diffusion: Stable Links
  • 9. Diffusion: Blame Previous Demo
  • 10. Maniphest: “Not Bad”
  • 11. Herald: Packages
  • 12. Calendar: Reviewer Away
  • 13. Conduit: Method Call
  • 14. Arcanist arc feature: Start working on something arc diff: Send code for review arc land: Publish reviewed code arc cover: Who should review my change arc patch: Apply someone’s revision Several other commands Works on Linux, Mac, Windows
  • 15. Arcanist: Lint
  • 16. Arcanist: Unit Tests Test plan
  • 17. Customization Configuration Extending code Differential fields Remarkup rules Events Custom Arcanist commands Conduit
  • 18. Weaknesses Commit discovery is delayed Some features require manual setup E.g. cross references Hosted repositories should solve both
  • 19. Culture Response within a day Don’t ask for unrelated changes Express strength of your feelings Who reviews the code Who lands the code How is the code tested When is the code linted and tested Pre-commit or post-commit review
  • 20. Thanks