• Share
  • Email
  • Embed
  • Like
  • Save
  • Private Content
Effective Code Review
 

Effective Code Review

on

  • 2,158 views

 

Statistics

Views

Total Views
2,158
Views on SlideShare
1,831
Embed Views
327

Actions

Likes
4
Downloads
0
Comments
0

14 Embeds 327

http://blogs.microsoft.co.il 202
http://urilavi.blogspot.com 84
http://www.slideshare.net 9
http://www.linkedin.com 9
http://www.irefactor.net 6
http://feeds2.feedburner.com 4
http://urilavi.blogspot.in 3
http://urilavi.blogspot.de 3
http://urilavi.blogspot.co.il 2
http://urilavi.blogspot.com.br 1
http://urilavi.blogspot.ca 1
http://www.lmodules.com 1
http://translate.googleusercontent.com 1
http://urilavi.blogspot.it 1
More...

Accessibility

Categories

Upload Details

Uploaded via as Microsoft PowerPoint

Usage Rights

CC Attribution-NonCommercial-NoDerivs LicenseCC Attribution-NonCommercial-NoDerivs LicenseCC Attribution-NonCommercial-NoDerivs License

Report content

Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

Cancel
  • Full Name Full Name Comment goes here.
    Are you sure you want to
    Your message goes here
    Processing…
Post Comment
Edit your comment

    Effective Code Review Effective Code Review Presentation Transcript

    • Code Review
      Principles
      http://www.flickr.com/photos/sebastian_bergmann/3991540987/
    • Important Observation
      Time Restrictions
      http://www.flickr.com/photos/mike-bensalem/3023717032/
    • Psychological Barrier - I
      Hard to concentrate
      Focusing for more than
      a few dozens of minutes
      without any recession
      is hardly possible
      http://www.flickr.com/photos/txd/2681183845/
    • Psychological Barrier - II
      Hard to understand
      To read and to interpret
      somebody else’s logic (code)
      http://www.flickr.com/photos/dhammza/91435718/
    • Effective Code Review
      How?
      Descriptive Abstract
      Focus
      Top-Down Overview
      Bottom-Up Review
      Read & Communicate
      “Drive” the code
      “Understand” the code
      Search for:
      Code Smells
      Violations of OOD and OOP
      Violations of Code Conventions
      Comprehension
    • Descriptive Abstract
      http://www.flickr.com/photos/sskennel/2330323726/
      Short Explanations
      Teach and Mentor
    • Focus
      Focus on Problematic Issues
      Couldn’t
      Make It Straight
      http://www.flickr.com/photos/horiavarlan/4259933101
    • Top Down Overview
      Get High Level Overview
      Sketches
      White Board
      High Level Class Diagram
      Read (a few) Unit Tests
      http://www.nasa.gov/multimedia/imagegallery/image_feature_526.html
      NASA
    • Bottom Up Review
      Continue to review the Code
      Review Unit Tests
      Review Classes & Methods
      Think about Missing
      Unit Tests
      http://www.nasa.gov/multimedia/imagegallery/image_feature_649.html
      NASA/CXC/UMass Amherst/Q.D.Wang et al
    • Drive the Code
      Take Initiative
      Become a “Driver”
      Is it easy to Drive?
      Pair Programming
      Techniques
      http://www.flickr.com/photos/pmarkham/3652471231/
    • Understand the Code (Logic)
      http://www.flickr.com/photos/apperceive/3351889502/
      Read, Read, Read
      Do you understand?
    • Communicate
      Read the Code Loudly
      Ask Questions
      Think Loudly
      http://www.flickr.com/photos/apperceive/3351889502/
    • Code Smells & OO Violations
      S.O.L.I.D
      http://www.flickr.com/photos/katerha/4526272937/
      Long Methods
      Unreadable
      Hard to maintain
      http://www.flickr.com/photos/king-edward/2266814656/
      Duplicate Code
      Binding to Implementation
      Encapsulation Violations
    • Fix It
      http://www.flickr.com/photos/justinbaeder/183930977/
      The “Navigator” takes Comments
      and makes fixes later
      Pair Programming
      Techniques