PHP Unconference 09
Thomas Weinert
Practical Experiences With Pre-Commit Hooks

About Me
● Application Developer
– PHP
– XSLT/XPath
– Javascript
● papaya CMS
– PHP based Content Management System
– uses XSLT for Templates

SVN Hooks
● Shell scripts on server
● For each repository
● Several events
– Pre-/Post-Commit

Pre-Commit
● Before Commit
● Transaction
● Standard error goes to SVN client
● Return value != 0 blocks commit

PHPCodeSniffer
● Ensure coding style
● Block parse errors (Lint)
● Ensure licence infos

Reaction
● Anger
● Acceptance
● Happyness
● Request for more sniffs
– Rules that are not checked are ignored

SVNLook
– On repository
– Read only
– Revision or transaction

papaya Custom Hook
● Calls PHPCodeSniffer only once
● Streamwrapper for SVNLook
● Uses XML response
● Outputs detailed error informations for each file
● Exclude: */external/*

Screenshot: Coding Style Error

Parse Error Sniff
● php -l
● ext/pcntl
● Input/output streams

Screenshot: Parse Error

Commit Message Check
● Kore Nordmann for Arbit(Tracker)
● Connect revision control system to bug tracker
● Readability
● Can not check contents

Screenshot: Bad Message

Rules
● - keyword (ticket): description
● # comment
● Maximum line length

Sample

Reactions
● Rejection and acceptance
● Syntax flame war
● Keyword flame war
● Line break flame war
● Increasing quality

Result
● Two additional keywords for documentation
team
● Line break suggestions

Screenshot: Fisheye

Mantis
● 1.1
– Several commit hooks for actions in Mantis
– Commits as comments
● 1.2
– Source browser plugin (WebSVN)
– Connects change sets to tickets

Screenshot: Mantis 1.2