Your SlideShare is downloading. ×
0
t3lib_div refactoring
t3lib_div refactoring
t3lib_div refactoring
t3lib_div refactoring
t3lib_div refactoring
t3lib_div refactoring
t3lib_div refactoring
Upcoming SlideShare
Loading in...5
×

Thanks for flagging this SlideShare!

Oops! An error has occurred.

×
Saving this for later? Get the SlideShare app to save on your phone or tablet. Read anywhere, anytime – even offline.
Text the download link to your phone
Standard text messaging rates apply

t3lib_div refactoring

347

Published on

Slides for the T3DD11 workshop about t3lib_div refactoring

Slides for the T3DD11 workshop about t3lib_div refactoring

0 Comments
0 Likes
Statistics
Notes
  • Be the first to comment

  • Be the first to like this

No Downloads
Views
Total Views
347
On Slideshare
0
From Embeds
0
Number of Embeds
0
Actions
Shares
0
Downloads
2
Comments
0
Likes
0
Embeds 0
No embeds

Report content
Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

Cancel
No notes for slide

Transcript

  • 1. Hands ont3lib_div
  • 2. Some numbers• 5921 lines• > 170 methods• ≈ 30 methods with correct PHPDoc• 39 warnings + 175 weak warnings http://bit.ly/pg8Stp
  • 3. Code Coverage• 26 % = 46/176 functions • Link http://bit.ly/pg8Stp
  • 4. Organizational Mess• modifyHTMLColor• strtoupper• array_merge_recursive_overrule• writeFile• linkThisUrl• imageMagickCommand http://bit.ly/pg8Stp
  • 5. Course Of Action• Public Google Doc with List of All Methods• Note your moves there• Add your name to the function you work on http://bit.ly/pg8Stp
  • 6. Course Of Action II• Look at the method and what it does – Is it still needed? Else: Deprecate – Does the name match? Else: Find a new one – Is it covered with unit tests? Else: Write some – Where does the function belong?• Note your findings in the Doc http://bit.ly/pg8Stp
  • 7. Course Of Action III• Move and rename the function• Run the unit tests• Leave a skeleton of the old function, – Deprecate it – Call the new function inside• Replace occurrences in the Core• Push to Gerrit :-) http://bit.ly/pg8Stp

×