Fluid für Frontend-Entwickler

405 views
359 views

Published on

Kurzpr

Published in: Technology, Sports
0 Comments
0 Likes
Statistics
Notes
  • Be the first to comment

  • Be the first to like this

No Downloads
Views
Total views
405
On SlideShare
0
From Embeds
0
Number of Embeds
3
Actions
Shares
0
Downloads
2
Comments
0
Likes
0
Embeds 0
No embeds

No notes for slide

Fluid für Frontend-Entwickler

  1. 1. Hands on t3lib_div
  2. 2. Some numbers <ul><li>5921 lines
  3. 3. > 170 methods
  4. 4. ≈ 30 methods with correct PHPDoc
  5. 5. 39 warnings + 175 weak warnings </li></ul>
  6. 6. Code Coverage <ul><li>26 % = 46/176 functions </li></ul><ul><li>Link </li></ul>
  7. 7. Organizational Mess <ul><li>modifyHTMLColor
  8. 8. strtoupper
  9. 9. array_merge_recursive_overrule
  10. 10. writeFile
  11. 11. linkThisUrl
  12. 12. imageMagickCommand </li></ul>
  13. 13. Course Of Action <ul><li>Public Google Doc with List of All Methods
  14. 14. Note your moves there
  15. 15. Add your name to the function you work on </li></ul>
  16. 16. Course Of Action II <ul><li>Look at the method and what it does </li><ul><li>Is it still needed? Else: Deprecate
  17. 17. Does the name match? Else: Find a new one
  18. 18. Is it covered with unit tests? Else: Write some
  19. 19. Where does the function belong? </li></ul><li>Note your findings in the Doc </li></ul>
  20. 20. Course Of Action III <ul><li>Move and rename the function
  21. 21. Run the unit tests
  22. 22. Leave a skeleton of the old function, </li><ul><li>Deprecate it
  23. 23. Call the new function inside </li></ul><li>Replace occurrences in the Core
  24. 24. Push to Gerrit :-) </li></ul>

×