Introduction to Code Reviews

30 April, 2009
Introduction to Code Reviewsby Mel Gerats

Definitionhttp://en.wikipedia.org/wiki/Code_review
Code review is systematic examination (often as peer review) of computer source code intended to find and fix mistakes overlooked in the initial development phase, improving both the overall quality of software and the developers' skills.
30 April, 2009
Introduction to Code Reviews, by Mel Gerats
2

Why
30 April, 2009
3

30 April, 2009
4
Why
Improve quality of code
Share Knowledge
Check conformance
Verify completeness
Educate
Reach a consensus
Try other approaches
…

30 April, 2009
5
What?
Inspection
Team Review
Pair programming
Walkthrough
Peer review
Ad hoc

30 April, 2009
6
Inspection, Team Review
Formal
Planned, prepared
Clear roles (moderator, author, reviewers, note taker…)
Goal: find defects

30 April, 2009
7
Walkthrough
Author takes the lead
Less detail
Higher level
Reviewers take notes
Goal: knowledge sharing, find defects

30 April, 2009
8
Pair Programming
Lessformal
Share knowledge
Short sessions
1 task
Goal: Prevent defects, share knowledge

30 April, 2009
9
Peer review
Informal
Asynchronous
One or more people
Find defects, improve quality

30 April, 2009
10
Ad Hoc
Can you take a look at this?
Goal: second opinion

30 April, 2009
11
How
Peer reviews
Pair Programming
Ad hoc

30 April, 2009
12
How: Review
Code, not the programmer
Substance, not style
Constructive criticism

30 April, 2009
13
How: Pair Programming
Short sessions
One problem at a time
Plan!

30 April, 2009
14
Resources
IDesign Coding Standard
Effective Code Reviews Without the Pain
Pair ProgrammingonWikipedia
http://www.processimpact.com/pubs.shtml#pr
Seven Truths About Peer Reviews
Seven Deadly Sins of Software Reviews
When Two Eyes Aren’t Enough
http://stackoverflow.com/questions/tagged/code-review
http://en.wikipedia.org/wiki/Code_review

15
30 April, 2009