Smell in Rails Apps (in Sapporo RubyKaigi03)

Smell in Rails Apps2010 12 6

2010 12 6

Yasuko Ohba2010 12 6

2010 12 6

It’s My Birthday2010 12 6

Today’s Talk2010 12 6

Requested topic is Rails2010 12 6

I have not tried much new things this year...2010 12 6

Still using Rails 22010 12 6

What are the points I improved this year?2010 12 6

Code Reviews2010 12 6

Refactoring2010 12 6

ﬁnd good (might not be best) designs / solutions in early stage2010 12 6

Avoid traps2010 12 6

I’ll talk about points of those activities2010 12 6

Where to start your code review ?2010 12 6

Design documents2010 12 6

2010 12 6

Written goals2010 12 6

“A user can ﬁnd his or her articles by words in title or body”2010 12 6

“Articles Search (there would be another feature for dates)”2010 12 6

With Some Details Without Other Topics2010 12 6

Diagrams for complexity2010 12 6

About status2010 12 6

Venn diagram is good draft Shared deleted2010 12 6

URL design in DOCUMENT2010 12 6

We use wiki for URLs URL2010 12 6

Write URLs look like real2010 12 6

2010 12 6

/admin/:controller/:id ?2010 12 6

Look real URLs and feel nice or not2010 12 6

2010 12 6

Use only 4 verbs2010 12 6

2010 12 6

Get WHAT Create WHAT Update WHAT Delete WHAT2010 12 6

Use whatever nouns2010 12 6

2010 12 6

borrow a book2010 12 6

2010 12 6

Book2010 12 6

borrow Book User2010 12 6

borrow Book User Well, we change it after all...2010 12 6

Book2010 12 6

of borrowing Book2010 12 6

of borrowing User Book create2010 12 6

of borrowing User Book create Create2010 12 6

Think in REST lang.2010 12 6

2010 12 6

Different Resources & Features from one model Resources A model class /a /a/b /a/c2010 12 6

2010 12 6

Controller Filters2010 12 6

ﬁlters too less too much2010 12 6

ﬁlters Not DRY too less too much2010 12 6

ﬁlters Not DRY Complex too less too much2010 12 6

before-ﬁlters as conditions, not just pre-tasks2010 12 6

2010 12 6

choose simpler one ?2010 12 6

Use :only always !2010 12 6

You can easily check which ﬁlter for which action2010 12 6

It’s hard to understand those do not appear2010 12 6

What ﬁlters for :show ?2010 12 6

Think about future2010 12 6

:except is effective on future actions2010 12 6

2010 12 6

Do you like adding ﬁlters or removing ﬁlters ?2010 12 6

2010 12 6

rescue errors2010 12 6

rescues in actions are rare2010 12 6

People from Java often rescue errors too much2010 12 6

checks and modiﬁcations of parameters2010 12 6

There might be better ways2010 12 6

if params[:skip_preview] == 1 ...2010 12 6

if params[:skip_preview] == 1 ... params[:book][:skip_preview]2010 12 6

if params[:skip_preview] == 1 ... params[:book][:skip_preview] attr_accessor :skip_preview ... if skip_preview? ...2010 12 6

2010 12 6

Most transaction blocks in controllers are not really necessary2010 12 6

Use AR callbacks Move it into an original method in the model2010 12 6

Abstraction2010 12 6

ApplicationController filters, utilities Admin::BaseController filters, utilities Admin::UsersController actions filters, utilities2010 12 6

ApplicationController actions filters, utilities Admin::BaseController actions filters, utilities Admin::UsersController actions filters, utilities2010 12 6

Controller A B C Controller Controller A B C A B D2010 12 6

Controller A B C Controller Controller A B C A B ? D2010 12 6

Controller A B C view ? Controller Controller A B C A B ? view D view2010 12 6

Sharing actions is tough2010 12 6

Be prudent to share actions2010 12 6

Use mix-in for action sharing2010 12 6

Share views using partials, not via abstraction2010 12 6

Module Module C A B Controller Controller A B C A B D2010 12 6

Module Module C A B Controller Controller A B C A B view D view partial views2010 12 6

2010 12 6

Protect model from evil params # {:book => {:user_id => 10, ...}} Book.create(params[:book])2010 12 6

attr_protected :hashed_password, :salt, :activated attr_accessible :name, :email2010 12 6

Choose simpler one?2010 12 6

Use attr_protected always !2010 12 6

Smell in Rails Apps (in Sapporo RubyKaigi03)

by nay on Dec 05, 2010

Accessibility

Categories

Tags

Upload Details

Usage Rights

1 Embed 2

Statistics

Smell in Rails Apps (in Sapporo RubyKaigi03) — Presentation Transcript