Никита Манько “Code review”

  • 205 views
Uploaded on

 

  • Full Name Full Name Comment goes here.
    Are you sure you want to
    Your message goes here
    Be the first to comment
    Be the first to like this
No Downloads

Views

Total Views
205
On Slideshare
0
From Embeds
0
Number of Embeds
3

Actions

Shares
Downloads
1
Comments
0
Likes
0

Embeds 0

No embeds

Report content

Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

Cancel
    No notes for slide

Transcript

  • 1. What is code review?
  • 2. When do you need to use codereview on your project?
  • 3. Points that might be the reason: Too much boilerplate code (any changes are very risky) External API need to be changed (just little bit) Too much too complex business logicrules Code smells (again? After it was just refactored) High load – only one simple line could f**k up all system In each development iteration the number of bugs is more then in previous one when the duck grunted
  • 4. Bonus points Each developer want to refactor everything on his own way When you fix one bug and you introduce N bugs (where N >= 2) Only you can changefix your own code Too much shitty code
  • 5. How to code review
  • 6. Types Over-the-shoulder Email pass-around Pair programming Tool-assisted code review
  • 7. Timeline TDD/unit test for critical functionality Automatic code analysis – common conventions Fish eye – tool similar to github functionality UI tests (for regression) Performance tests (not to f**k up on mass event) Over-the-shoulder code review + elements of pair programming – this is really works