Get a Second Opinion with Code review

Get a Second Opinion with Code Review Adobe MAX 2010 FITC Unconference October 26, 2010

Who Am I? Kathryn Rotondo SDK/Channel Developer at litl ﬂashionista.org @krotondo

What is Code Review?

Beneﬁts

Sharing

Learning

Tidyness

Error Prevention

Time Saving

Code Reviews http://www.google.com/enterprise/marketplace/viewListing? productListingId=5143210+12982233047309328439

Rietveld Script http://code.google.com/appengine/ articles/rietveld.html

FlexFormatter http://sourceforge.net/projects/ﬂexformatter/ AnyEdit http://andrei.gmxhome.de/anyedit/

Process

Process 1. Developer makes changes/commits in local workspace

Process 1. Developer makes changes/commits in local workspace 2. Developer uploads patch for review using upload.py

Process 1. Developer makes changes/commits in local workspace 2. Developer uploads patch for review using upload.py 3. Email is automatically sent to reviewers

Process 1. Developer makes changes/commits in local workspace 2. Developer uploads patch for review using upload.py 3. Email is automatically sent to reviewers 4. Reviewer visits website and browses side-by-side diffs

Process 1. Developer makes changes/commits in local workspace 2. Developer uploads patch for review using upload.py 3. Email is automatically sent to reviewers 4. Reviewer visits website and browses side-by-side diffs 5. Reviewer inserts inline comments and publishes comment summary

Process 1. Developer makes changes/commits in local workspace 2. Developer uploads patch for review using upload.py 3. Email is automatically sent to reviewers 4. Reviewer visits website and browses side-by-side diffs 5. Reviewer inserts inline comments and publishes comment summary 6. Developer responds to comments/uploads update for review

Process 1. Developer makes changes/commits in local workspace 2. Developer uploads patch for review using upload.py 3. Email is automatically sent to reviewers 4. Reviewer visits website and browses side-by-side diffs 5. Reviewer inserts inline comments and publishes comment summary 6. Developer responds to comments/uploads update for review 7. Lather, rinse, repeat as necessary

Process 1. Developer makes changes/commits in local workspace 2. Developer uploads patch for review using upload.py 3. Email is automatically sent to reviewers 4. Reviewer visits website and browses side-by-side diffs 5. Reviewer inserts inline comments and publishes comment summary 6. Developer responds to comments/uploads update for review 7. Lather, rinse, repeat as necessary 8. Developer pushes approved patch to central repo

Summary

Questions?

Photo Credits Brian Cantoni http://www.flickr.com/photos/cantoni/4679568335/ Allie Caulfield http://www.flickr.com/photos/wm_archiv/3048852294/

http://flashionista.org	99
http://www.scottjanousek.com	18

Get a Second Opinion with Code review

by krotondo on Oct 30, 2010

Accessibility

Categories

Tags

Upload Details

Usage Rights

2 Embeds 117

Statistics

Get a Second Opinion with Code review — Presentation Transcript