Your SlideShare is downloading. ×
  • Like

Thanks for flagging this SlideShare!

Oops! An error has occurred.


Now you can save presentations on your phone or tablet

Available for both IPhone and Android

Text the download link to your phone

Standard text messaging rates apply

Code Review for Systems Administrators


Elizabeth Krumbach Joseph from HP Public Cloud presents Code for Review for Systems Administrators at OSCON 2013.

Elizabeth Krumbach Joseph from HP Public Cloud presents Code for Review for Systems Administrators at OSCON 2013.

Published in Technology
  • Full Name Full Name Comment goes here.
    Are you sure you want to
    Your message goes here
    Be the first to comment
    Be the first to like this
No Downloads


Total Views
On SlideShare
From Embeds
Number of Embeds



Embeds 0

No embeds

Report content

Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

    No notes for slide


  • 1. Code Review for Systems Administrators Elizabeth Krumbach Joseph <>, HP Cloud Services Twitter: @pleia2
  • 2. OpenStack Infrastructure Team Our job is to make sure the OpenStack developers can do their job.
  • 3. OpenStack Code Review (and CI) Challenges Lots of individual projects All projects must work together Changes should never break the master Code should be syntactically clean Testing should be completely automated
  • 4. What we're using Launchpad Git Gerrit Zuul* Jenkins (with jenkins-job-builder*, devstack-gate*) * Started by the OpenStack Infrastructure team
  • 5. Workflow
  • 6. What we use it for All core OpenStack projects StackForge projects Documentation Systems Administration!
  • 7. What we do
  • 8. What we do (redux) Continuous Integration systems Cacti Logstash IRC Bots Etherpad Paste Planet Puppet Dashboard Mailing Lists Various smaller web services Wiki
  • 9. Everything we do is in public Anyone on the internet can look at our changes Anyone can sign up for a code review account Anyone can write code reviews
  • 10. What Systems Adminstrators Check flake8 (pep 8 and pyflakes) puppet parser validate puppet-lint
  • 11. Peer Review Multiple eyes on changes prior to merging Good infrastructure for developing new solutions (particularly for a distributed team) No special process to go through for commit access Trains us to be collaborative by default
  • 12. Automated deployment! Change gets checked in ...Either puppet master gets updated and applies change ...Or vcsrepo module in puppet pulls in latest version of project
  • 13. Can you really manage via git commits? Cacti to keep an eye on server usage Puppet dashboard so you can watch your changes get applied (or not!) Thorough, specific documentation at
  • 14. Limitations Sometimes you just need to log into a server More difficult for complicated migrations, upgrades Passwords need to be more privately managed
  • 15. Questions Contact Elizabeth Krumbach Joseph <> @pleia2 on Twitter Slides linked on Openstack CI Resources