• Share
  • Email
  • Embed
  • Like
  • Save
  • Private Content
Code reviews - Leave your ego at the door
 

Code reviews - Leave your ego at the door

on

  • 2,332 views

Presentation I held internally at Bigpoint, at the PHP Unconference 2012 in Hamburg (19/08/2012) and at the Barcamp Hamburg (11/03/2012)

Presentation I held internally at Bigpoint, at the PHP Unconference 2012 in Hamburg (19/08/2012) and at the Barcamp Hamburg (11/03/2012)

Statistics

Views

Total Views
2,332
Views on SlideShare
1,578
Embed Views
754

Actions

Likes
0
Downloads
18
Comments
0

2 Embeds 754

http://www.starside.de 490
http://starside.de 264

Accessibility

Upload Details

Uploaded via as Microsoft PowerPoint

Usage Rights

© All Rights Reserved

Report content

Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

Cancel
  • Full Name Full Name Comment goes here.
    Are you sure you want to
    Your message goes here
    Processing…
Post Comment
Edit your comment

    Code reviews - Leave your ego at the door Code reviews - Leave your ego at the door Presentation Transcript

    • Code Peer ReviewsLeave your ego at the doorFrank SonsSenior Software Engineer
    • So, what’s this about? Introducing Reviews Collective code ownership Some ways to review code Beware the dragons! 2
    • A short introduction to reviews Forget about the code for the moment… 3
    • What’s the idea? Peer review methods are employed to maintain standards, improve performance and provide credibility. 4
    • Reviews aren’t limited to code… 5
    • Back to code reviews… IBM: Inspection introduced in 1970s Google: 20% rule used for reviews 6
    • „That‘s not my code!“Collective code ownership is a mindset 7
    • What about the ego? „Everyone has the right and freedom to totally suck in private.“ 8
    • Forget about your ego! „Attempt to be awesome in public and embrace the suck!“ 9
    • Reviews are knowledge sharing! 10
    • Share within your team… Product knowledge Technical knowledge Coding Standards Transparency 11
    • How to reviewA comprehensive overview 12
    • Ad hoc Just ask someone Takes only a few minutes Happens everywhere Little impact beyond problem Completely informal 13
    • Peer deskcheck / passaround Asking someone for input Can be done asynchronous Author is not present Good for mentoring and coaching Very informal 14
    • Pair programming Agile approach Driver and navigator Rapid iterations Cultural change needed Informal review 15
    • Walkthrough Author explains code Code reading Ideal to present and educate Risk of overlooking critical code Informal, no defined process 16
    • Team review Used to judge product Check against specifications Preparation needed Review collects data and input Planned and structured 17
    • Inspection Most formal approach Industry standard Specific roles and trained inspectors Checklist Moderated review 18
    • “Inspection Walkthrough” Reader doesn‘t know code Experienced dev for „eagle eye“ view Author explains and answers questions Specific code section No leads involved 19
    • Beware the dragons! It can be tricky… 20
    • Egoless! My ego is not tied to my „perfect“ or „imperfect“ work product. 21
    • Avoid the dragons No fingerpointing Leave the egos at the door Resistance to change Lack of knowledge Cultural issues 22
    • Some things to keep in mind Three to seven participants Not longer than two hours Manager should be involved in planning Find problems, not solutions Review coverage vs. project size 23
    • JUST DO IT! 24
    • This helps… 25
    • I hope you had a good time! Reviews can help your team Reviews are all about the mindset Don‘t fear the dragons 26
    • Thanks! 27
    • Bigpoint GmbH Frank SonsSenior Software Engineer Drehbahn 47-48 20354 Hamburg Germany Tel +49 40.88 14 13 - 0Fax +49 40.88 14 13 - 11 f.sons@bigpoint.net www.bigpoint.net Find us on 28