使用Rails best practices做代码审查

rails_best_practicesﬂyerhzm@gmail.com Proprietary and Conﬁden/al. © 2010 Aurora Feint. 1

•  a.k.a Richard Huang • hDp://huangzhimin.com • hDp://twiDer.com/flyerhzm • hDp://github.com/flyerhzm• OpenFeint Proprietary and Confiden/al. © 2010 Aurora Feint. 2

rails_best_practices gem• rails • 24 • • Proprietary and Conﬁden/al. © 2010 Aurora Feint. 3

rails-bestpractices.com• • 63 • gem • gem Proprietary and Conﬁden/al. © 2010 Aurora Feint. 4

rails_best_practices gem Proprietary and Conﬁden/al. © 2010 Aurora Feint. 5

Proprietary and Conﬁden/al. © 2010 Aurora Feint. 6

rails••• Proprietary and Conﬁden/al. © 2010 Aurora Feint. 7

Java• checkstyle Proprietary and Conﬁden/al. © 2010 Aurora Feint. 8

Ruby• Saikuro ‐ • Flog ‐ • Flay ‐ • Reek ‐  code smell Proprietary and Conﬁden/al. © 2010 Aurora Feint. 9

rails_best_practices gem• rails check list Proprietary and Conﬁden/al. © 2010 Aurora Feint. 10

rails_best_practices gem Proprietary and Conﬁden/al. © 2010 Aurora Feint. 11

rails_best_practice gem Proprietary and Conﬁden/al. © 2010 Aurora Feint. 12

rbp gem sexpProprietary and Conﬁden/al. © 2010 Aurora Feint.

sexp class Post < ActiveRecord::Base attr_accessor :editable ends(:class, :Post, s(:colon2, s(:const, :ActiveRecord), :Base), s(:scope, s(:call, nil, :attr_accessor, s(:arglist, s(:lit, :editable)) ) )) Proprietary and Conﬁden/al. © 2010 Aurora Feint. 14

sexp def test puts "hello world" ends(:defn, :test, s(:args), s(:scope, s(:block, s(:call, nil, :puts, s(:arglist, s(:str, "hello world")) ) ) )) Proprietary and Conﬁden/al. © 2010 Aurora Feint. 15

if i > 10 puts "more than ten" else puts "less than or equal to ten" ends(:if, s(:call, s(:call, nil, :i, s(:arglist)), :>, s(:arglist, s(:lit, 10)) ), s(:call, nil, :puts, s(:arglist, s(:str, "more than ten")) ), s(:call, nil, :puts, s(:arglist, s(:str, "less than or equal to ten")) )) Proprietary and Conﬁden/al. © 2010 Aurora Feint. 16

Play with sexp ruby_parserProprietary and Conﬁden/al. © 2010 Aurora Feint. 17

• • trailing white space • tab spaces Proprietary and Conﬁden/al. © 2010 Aurora Feint. 18

(prepare)• • models • model associa/ons • model aDributes • mailers Proprietary and Conﬁden/al. © 2010 Aurora Feint. 19

(review)• • use model virtual aDribute • use query aDribute • always add db index • ...... Proprietary and Conﬁden/al. © 2010 Aurora Feint. 20

• rails_best_prac/ces• rails_best_prac/ces ‐‐format html• rails_best_prac/ces ‐f html ‐‐with‐textmate• rails_best_prac/ces ‐f html ‐‐with‐mvim Proprietary and Conﬁden/al. © 2010 Aurora Feint. 23

• rails best prac/ces  hDp://rails‐bestprac/ces.com/ • rails_best_prac/ces hDps://github.com/ﬂyerhzm/rails_best_prac/ces• rails_best_prac/ces hDp://rdoc.rails‐bestprac/ces.com/03/23/11 Proprietary and Conﬁden/al. © 2010 Aurora Feint. 26

OpenFeint• mobile game social network  ( 7 )••• mailto: hr@openfeint.cn Proprietary and Conﬁden/al. © 2010 Aurora Feint. 28

http://huangzhimin.com	893
http://www.huangzhimin.com	96
http://github.chunchu.org	49
http://flyerhzm.github.com	42
http://feeds.feedburner.com	31
http://localhost	17
http://yangha.me	5
http://webcache.googleusercontent.com	4
http://cache.baidu.com	3
http://xianguo.com	2
http://dontaskcece.github.com	1
http://gnuhub.com	1
http://translate.googleusercontent.com	1
http://10.228.25.16	1
http://huangzhimin.com} {778142565\|\|\|pingback	1
http://aqoon.local	1
http://fanyi.youdao.com	1
http://git.chunchu.org	1
http://snapshot.soso.com	1

使用Rails best practices做代码审查

by Richard Huang on Mar 27, 2011

Accessibility

Categories

Tags

Upload Details

Usage Rights

19 Embeds 1,151

Statistics

使用Rails best practices做代码审查 — Presentation Transcript