• Save
Coder  Presentation
Upcoming SlideShare
Loading in...5
×
 

Coder Presentation

on

  • 2,254 views

 

Statistics

Views

Total Views
2,254
Views on SlideShare
2,254
Embed Views
0

Actions

Likes
1
Downloads
1
Comments
0

0 Embeds 0

No embeds

Accessibility

Upload Details

Uploaded via as OpenOffice

Usage Rights

© All Rights Reserved

Report content

Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

Cancel
  • Full Name Full Name Comment goes here.
    Are you sure you want to
    Your message goes here
    Processing…
Post Comment
Edit your comment

Coder  Presentation Coder Presentation Presentation Transcript

  • Barcelona DrupalCon Code Review is not just for Standards
  • (INSERT PICTURE OF BARCELONA) (maybe Gaudi House on Catalunya) Code Review is not just for Standards By Doug Green [email_address] [email_address]
  • http://drupal.org/project/coder Code Review is not just for Standards
    • Coder Module
    • History
    • Developer Module, built for you (and me)
    • What does it do?
    • Credit code-style.pl
    • Credit contributors: webchick, nancyw
    • Style Review
    • Upgrade Reviews (4.7.x, 5.x, 6.x)
    • Security Reviews
    • Performance Reviews
    • Types of Reviews
    Code Review is not just for Standards
    • Not what this talk is about
    • But some simple hints
    • Style Review
    Code Review is not just for Standards
    • $var .' followed by a quote'
    • 'quote followed by a '. $var
    • while ($space_before_left_paren)
    • while ($space_after_right_paren) {
    • indent 2 spaces, don't use tabs
    • don't end with a ?>
    • don't use camelCase or CamelCase
    • Common Style Problems
    • See http://drupal.org/node/318
    Code Review is not just for Standards
    • FAPI
    • Menu
    • Schema API
    • Info File changes
    • ... much much more ...
    • Drupal 5.x -> 6.x
    • See http://drupal.org/node/114774
    Code Review is not just for Standards
    • Run from Drupal 5
    • Run from Drupal 6 (recommended)
    • Catches Quite a Bit...
    • But it's just a tool that makes suggestions
    • You are Smarter than Coder
    • Drupal 5.x -> 6.x Upgrade Review
    • We've got 10 minutes...
    • Let's Upgrade a Module Now!
    Code Review is not just for Standards
    • Coder Engine
    • What is a Review?
    • What is a Rule?
    • What is a Regular Expression?
    • How does Coder Work?
    Code Review is not just for Standards
    • regex
    • grep, grep_invert, callback
    • Rule Types
    Code Review is not just for Standards
    • php (default)
    • html
    • quote
    • doublequote
    • comment
    • all
    • Rule Sources
    Code Review is not just for Standards
  • array( '#type' => 'regex', '#value' => '_form_alters*($', ... ),
    • Example Rule:
    • See http://drupal.org/node/144172
    Code Review is not just for Standards
  • array( '#type' => 'regex', '#function' => '_menu$', '#value' => '$items[]s*=', ... ),
    • Another Example Rule:
    • See http://drupal.org/node/144172
    Code Review is not just for Standards
  • array( '#type' => 'regex', '#value' => 'global $locale', ... ),
    • One More Example:
    • See http://drupal.org/node/144172
    Code Review is not just for Standards
    • Coderis only as good as the Rules
    • Lot's of contributors
    • But 1 Developer (so far)
    • Please submit ideas
    • Please submit Review/Rules Patches
    • You can do it!
    • Really :)
    • It's your tool, and I need help
    • Really !
    • Why All the Examples Doug?
    Code Review is not just for Standards
    • Security
    • Performance
    • Potential
    Code Review is not just for Standards
  • [email_address] http://drupal.org/project/coder Code Review is not just for Standards