Effective Code Reviews

594
-1

Published on

Code reviews don’t have to be battlegrounds. Over the years, I discovered that some of my practices simply ended up working better than others. Here are a handful of tips for getting the most out of your code reviews.

Published in: Technology
0 Comments
0 Likes
Statistics
Notes
  • Be the first to comment

  • Be the first to like this

No Downloads
Views
Total Views
594
On Slideshare
0
From Embeds
0
Number of Embeds
3
Actions
Shares
0
Downloads
0
Comments
0
Likes
0
Embeds 0
No embeds

No notes for slide
  • The forums on codeproject.com recently had a discussion thread about code reviews. Here are a handful of the bad experiences.
  • Use code review software to conduct your reviews. It gives you a chance to understand more code context than a live walkthrough, it gives you an opportunity to filter your thoughts, and it provides a mechanism for archiving and summarizing your decisions so that you can review them even years later.
  • Asking questions generally produces better results than simply telling someone what you think they did wrong. If you find a real defect, though, you can still play the trump card. Just use them sparingly.
  • Senior level programmers don’t get a free pass – their code should be reviewed, too! Even the most experienced developers can get tunnel vision on a project. Reviewing a senior developer’s code also can provide excellent learning opportunities for everyone on the team.
  • Effective Code Reviews

    1. 1. Code Reviews
    2. 2. Code Review Nightmares• Content one day implementing a feature and now three "I spent Goes Here days and counting on the code review." - Nemanja Trifunovic (Source)• "...they dilute the engineers sense of ownership of his work" - Fran Porretto (Source)• "Every code review Ive been in has been a complete waste of valuable development time. It usually turned into "Why did you do it this way???? My way is better... " - Kevin Marois (typos corrected - Source)
    3. 3. Code Review Software• Content Goes Here Understand the context• Filter your thoughts• Archive and Summary
    4. 4. Ask Questions• Content Goes Here The author has already wrestled with coding decisions• Asking questions facilitates intelligent discussion• The trump card
    5. 5. Everyone Reviews Everything• Content passes! No free Goes Here• Tunnel vision is real• Opportunities to learn
    6. 6. More Information• Content Goes HereCode Review blog series:http://www.hitthebits.com/p/code-reviews.htmlTwitter:@djleedsMy Blog:www.HitTheBits.comMy Team’s Blog:www.DevelopWithPurpose.com
    7. 7. Thank you

    ×