Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Upcoming SlideShare
Loading in...5

Drupal Patch Reviews: Get good reviews, give good reviews. Faster.



pdf export for jam's drupal camp.

pdf export for jam's drupal camp.

also at https://github.com/zendoodles/slide-decks/blob/jam/patch-review/index.html



Total Views
Views on SlideShare
Embed Views



2 Embeds 205

https://www.acquia.com 164
http://www.acquia.com 41


Upload Details

Uploaded via as Adobe PDF

Usage Rights

© All Rights Reserved

Report content

Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

  • Full Name Full Name Comment goes here.
    Are you sure you want to
    Your message goes here
Post Comment
Edit your comment

Drupal Patch Reviews: Get good reviews, give good reviews. Faster. Drupal Patch Reviews: Get good reviews, give good reviews. Faster. Presentation Transcript

  • Patch Reviews Thanks ZenDoodles and xjm
  • YesCT Cathy Theys @YesCT Cheppers, Gittip I review patches, mostly for core these days. And do other stuff like plan sprints and mentor.
  • (https://www.youtube.com/watch?v=NvV38nJObIE&t=12m57s)
  • Getting patch reviews Also: how to find reviews
  • Be specific, what kind of review?
  • Use tags needs JavaScript review needs architectural review, needs usability review, needs manual testing, needs screenshot
  • Up-to-date Issue Summary https://drupal.org/contributor-tasks/write-issue-summary
  • Automatic instructions work in progress at https://drupal.org/node/2013222
  • Contributor task documents http://drupal.org/contributor-tasks/review http://drupal.org/contributor-tasks/do-accessibility-review
  • Metas
  • simplytest.me url pattern is: /project/drupal/8.x? patch[]= http://simplytest.me/qa#developers
  • Give good reviews
  • Doing patch reviews
  • Finding issues to review
  • first simple! success! novice? initiatives metas? focus?
  • Core initiatives https://drupal.org/community-initiatives/drupal-core and https://drupal.org/node/2107085
  • Doing patch reviews
  • Full frontal nicety
  • Supportive specific include links support improvement ask questions educate
  • http://dreditor.org
  • Does it work? fixes the issue stays in scope no regressions
  • Edit
  • Does it make sense? readable? comments? is there a better way?
  • Strategy Scale say what say how
  • Strategy Kinds of reviews update the issue summary update needs tags
  • Process cannot unread perfect is enemy of good
  • documentation issue summary time in-code API docs (1354) hook_help() change records http://drupal.org/list-changes/drupal
  • Performance Don't guess profile!
  • Accessibility
  • bug WCAG ATAG text color contrast form fields are labeled keyboard-usable (javascript)
  • Usability UI changes need usability review before and after screenshots
  • Testing check coverage ask for new tests verify tests-only fails
  • Coding Style no tabs, trailing 1354 link! to docs
  • drupal.org/documentation/git/interdiff
  • Read and check concerns? addressed?
  • read, read, read fix simple for scope for understanding
  • IDE
  • Resources drupalize.me/guides/drupal-community-tools-and-core-mentoring
  • Resources drupalladder.org/
  • Resources drupal.org/contributortasks/review xjm.drupalgardens.com/reviewguide
  • Action drupal mentoring office hours #drupal-contribute drupical.com
  • Thanks! https://drupal.org/node/2013222 https://drupal.org/core-mentoring