Patch Reviews
Thanks ZenDoodles and xjm
YesCT

Cathy Theys
@YesCT
Cheppers, Gittip

I review patches, mostly for core these days.
And do other stuff like plan spr...
(https://www.youtube.com/watch?v=NvV38nJObIE&t=12m57s)
Getting patch reviews
Also: how to find reviews
Be specific,
what kind of review?
Use tags
needs JavaScript review
needs architectural review,
needs usability review,
needs manual testing,
needs screensho...
Up-to-date Issue Summary
https://drupal.org/contributor-tasks/write-issue-summary
Automatic instructions
work in progress at
https://drupal.org/node/2013222
Contributor task
documents

http://drupal.org/contributor-tasks/review
http://drupal.org/contributor-tasks/do-accessibilit...
Metas
simplytest.me url
pattern is:

/project/drupal/8.x?
patch[]=
http://simplytest.me/qa#developers
Give good reviews
Doing patch reviews
Finding issues to
review
first simple! success!
novice?
initiatives
metas?
focus?
Core initiatives
https://drupal.org/community-initiatives/drupal-core
and https://drupal.org/node/2107085
Doing patch reviews
Full frontal nicety
Supportive
specific
include links
support improvement
ask questions
educate
http://dreditor.org
Does it work?
fixes the issue
stays in scope
no regressions
Edit
Does it make sense?
readable?
comments?
is there a better way?
Strategy
Scale
say what
say how
Strategy

Kinds of reviews
update the issue summary
update needs tags
Process
cannot unread
perfect is enemy of good
documentation
issue summary
time
in-code API docs (1354)
hook_help()
change records
http://drupal.org/list-changes/drupal
Performance
Don't guess
profile!
Accessibility
bug
WCAG
ATAG
text color contrast
form fields are labeled
keyboard-usable (javascript)
Usability
UI changes need usability
review
before and after screenshots
Testing
check coverage
ask for new tests
verify tests-only fails
Coding Style
no tabs, trailing
1354
link! to docs
drupal.org/documentation/git/interdiff
Read and check
concerns?
addressed?
read, read, read
fix simple
for scope
for understanding
IDE
Resources
drupalize.me/guides/drupal-community-tools-and-core-mentoring
Resources
drupalladder.org/
Resources

drupal.org/contributortasks/review
xjm.drupalgardens.com/reviewguide
Action
drupal mentoring office hours
#drupal-contribute
drupical.com
Thanks!

https://drupal.org/node/2013222
https://drupal.org/core-mentoring
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Drupal Patch Reviews: Get good reviews, give good reviews. Faster.
Upcoming SlideShare
Loading in …5
×

Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

697 views
627 views

Published on

pdf export for jam's drupal camp.

also at https://github.com/zendoodles/slide-decks/blob/jam/patch-review/index.html

0 Comments
2 Likes
Statistics
Notes
  • Be the first to comment

No Downloads
Views
Total views
697
On SlideShare
0
From Embeds
0
Number of Embeds
271
Actions
Shares
0
Downloads
48
Comments
0
Likes
2
Embeds 0
No embeds

No notes for slide

Drupal Patch Reviews: Get good reviews, give good reviews. Faster.

  1. 1. Patch Reviews Thanks ZenDoodles and xjm
  2. 2. YesCT Cathy Theys @YesCT Cheppers, Gittip I review patches, mostly for core these days. And do other stuff like plan sprints and mentor.
  3. 3. (https://www.youtube.com/watch?v=NvV38nJObIE&t=12m57s)
  4. 4. Getting patch reviews Also: how to find reviews
  5. 5. Be specific, what kind of review?
  6. 6. Use tags needs JavaScript review needs architectural review, needs usability review, needs manual testing, needs screenshot
  7. 7. Up-to-date Issue Summary https://drupal.org/contributor-tasks/write-issue-summary
  8. 8. Automatic instructions work in progress at https://drupal.org/node/2013222
  9. 9. Contributor task documents http://drupal.org/contributor-tasks/review http://drupal.org/contributor-tasks/do-accessibility-review
  10. 10. Metas
  11. 11. simplytest.me url pattern is: /project/drupal/8.x? patch[]= http://simplytest.me/qa#developers
  12. 12. Give good reviews
  13. 13. Doing patch reviews
  14. 14. Finding issues to review
  15. 15. first simple! success! novice? initiatives metas? focus?
  16. 16. Core initiatives https://drupal.org/community-initiatives/drupal-core and https://drupal.org/node/2107085
  17. 17. Doing patch reviews
  18. 18. Full frontal nicety
  19. 19. Supportive specific include links support improvement ask questions educate
  20. 20. http://dreditor.org
  21. 21. Does it work? fixes the issue stays in scope no regressions
  22. 22. Edit
  23. 23. Does it make sense? readable? comments? is there a better way?
  24. 24. Strategy Scale say what say how
  25. 25. Strategy Kinds of reviews update the issue summary update needs tags
  26. 26. Process cannot unread perfect is enemy of good
  27. 27. documentation issue summary time in-code API docs (1354) hook_help() change records http://drupal.org/list-changes/drupal
  28. 28. Performance Don't guess profile!
  29. 29. Accessibility
  30. 30. bug WCAG ATAG text color contrast form fields are labeled keyboard-usable (javascript)
  31. 31. Usability UI changes need usability review before and after screenshots
  32. 32. Testing check coverage ask for new tests verify tests-only fails
  33. 33. Coding Style no tabs, trailing 1354 link! to docs
  34. 34. drupal.org/documentation/git/interdiff
  35. 35. Read and check concerns? addressed?
  36. 36. read, read, read fix simple for scope for understanding
  37. 37. IDE
  38. 38. Resources drupalize.me/guides/drupal-community-tools-and-core-mentoring
  39. 39. Resources drupalladder.org/
  40. 40. Resources drupal.org/contributortasks/review xjm.drupalgardens.com/reviewguide
  41. 41. Action drupal mentoring office hours #drupal-contribute drupical.com
  42. 42. Thanks! https://drupal.org/node/2013222 https://drupal.org/core-mentoring

×