Code Review Quickstart

  • 1,864 views
Uploaded on

Start your team reviewing your programming work. Become a better programmer!

Start your team reviewing your programming work. Become a better programmer!

More in: Technology
  • Full Name Full Name Comment goes here.
    Are you sure you want to
    Your message goes here
    Be the first to comment
No Downloads

Views

Total Views
1,864
On Slideshare
0
From Embeds
0
Number of Embeds
1

Actions

Shares
Downloads
1
Comments
0
Likes
3

Embeds 0

No embeds

Report content

Flagged as inappropriate Flag as inappropriate
Flag as inappropriate

Select your reason for flagging this presentation as inappropriate.

Cancel
    No notes for slide

Transcript

  • 1. 15 Minute Code Review Quickstartbrian d foy, brian.d.foy@gmail.com The Perl Review
  • 2. Makebetter programmers not better programs
  • 3. Choose a reason• Inspect work• Mentor junior members• Sharpen senior members• Cross-pollinate ideas• Find bugs
  • 4. Start small• Start with small goals• Make it a regular, expected event• Reach a goal? Extend it.• Refine and document the process
  • 5. Set boundaries• Be nice• Limit the scope and depth of code• Limit the time for each item• Don’t ambush• Don’t make corrections• End on time
  • 6. Review code that...• compiles• passes its tests • is covered by the tests • is profiled• is under development
  • 7. Stay on target• Make a checklist• Show up prepared• Facilitate discussion but defer arguments• Quash digressions (send to hallway track)• Note problems and move on
  • 8. Starter checklist• Is documented• Everyone understands • what it does • how it does it • why it does it that way• Follows local style
  • 9. Steal from others• Effective Code Reviews Without the Pain http://goo.gl/8bWO• Five Whys http://5whys.com/